From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0F91C5AD7B for ; Mon, 10 Aug 2026 23:45:10 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8113210E1CB; Mon, 10 Aug 2026 23:45:10 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="Af0rZq5K"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by gabe.freedesktop.org (Postfix) with ESMTPS id 94E3610E1B9 for ; Mon, 10 Aug 2026 23:45:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1786405509; x=1817941509; h=date:message-id:from:to:subject:in-reply-to:references: mime-version; bh=fkE9GF0msxR0IM3mLF2leqX3E9KH40iDoLsMHTt9Ugs=; b=Af0rZq5Kf/Kk4lg4jkRMgshbsoNF+3cyoF1Dotnqy6DYfNzPYw5TbVM+ Im9Vf/hRtcIWW3YzwM4UonlO4AiL/pb9mTyStiq/E+YIW/y9wNQKp5TlJ TCDm6eyoPLKWAyTKXaAmZ7Tma1ZEcHt7zMmgwBrJc6zIMwGzEyFSxEfXZ TlIGmMV251wfw0pDxOc0otuuhq2ly4t8nBzSiFW2EamiwpsT59NjHAnMm Eaq3JCvKDRIpeogS8aPdFpwhB8jV0tq6CSAG8Kw1d51Nr14dV5hfL6glp FFL9kFB517/BY1XQz9H/fqG5T0RZyS26kJQbxb/HPvCH9AAN1vP1LofAH Q==; X-CSE-ConnectionGUID: DvkS3fG3RJOKP5IOS4jTdw== X-CSE-MsgGUID: CTnQ2dFETNyGoANymUT9TA== X-IronPort-AV: E=McAfee;i="6800,10657,11871"; a="98080808" X-IronPort-AV: E=Sophos;i="6.25,216,1779174000"; d="scan'208";a="98080808" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2026 16:45:08 -0700 X-CSE-ConnectionGUID: 7mv7Mv95TDy9CFWcRwVbKQ== X-CSE-MsgGUID: asW/EvkwRUSYJ6nsa8NyxQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,216,1779174000"; d="scan'208";a="262675499" Received: from unknown (HELO adixit-MOBL3.intel.com) ([10.241.243.70]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2026 16:45:08 -0700 Date: Mon, 10 Aug 2026 16:45:07 -0700 Message-ID: <87cxvph75o.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Subject: Re: [PATCH v3 0/9] Don't whitelist OA registers unconditionally In-Reply-To: <87a4smovll.wl-ashutosh.dixit@intel.com> References: <20260615224227.34880-1-ashutosh.dixit@intel.com> <87bjd2ozeb.wl-ashutosh.dixit@intel.com> <87a4smovll.wl-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Mon, 22 Jun 2026 19:10:14 -0700, Dixit, Ashutosh wrote: > > On Mon, 22 Jun 2026 17:48:12 -0700, Dixit, Ashutosh wrote: > > > > On Mon, 15 Jun 2026 15:42:18 -0700, Ashutosh Dixit wrote: > > > > > > Whitelisting OA registers unconditionally is a security violation. In this > > > series we resolve this issue as follows: > > > > > > * Set the 'deny' bit (bit 30) for all OA registers, ensuring OA registers > > > are not whitelisted by default after probe/reset/restart > > > * Reset the 'deny' bit when an OA stream is opened and certain conditions > > > are met, whitelisting OA registers only for the duration when OA streams > > > are open for a gt > > > * Set the 'deny' bit again, when OA streams are closed > > > * To manage this scheme, separate out OA whitelists from non-OA whitelists > > > (into separate save-restore lists) > > > > > > v2: Address code review from Umesh. Patches changed in v2 have changelog > > > appended to commit message > > > v3: Minor change to Patch 3 > > > > > > Ashutosh Dixit (9): > > > drm/xe/rtp: Add RING_FORCE_TO_NONPRIV_DENY to OA whitelists > > > drm/xe/rtp: Maintain OA whitelists separately > > > drm/xe/rtp: Keep track of non-OA nonpriv slots > > > drm/xe/rtp: Generalize whitelist_apply_to_hwe > > > drm/xe/rtp: Save OA nonpriv registers to register save/restore lists > > > drm/xe/rtp: Toggle 'deny' bit to (de-)whitelist OA regs > > > drm/xe/rtp: (De-)whitelist OA registers for all hwe's for a gt > > > drm/xe/oa: (De-)whitelist OA registers on OA stream open/release > > > drm/xe/rtp: Ensure locking/ref counting for OA whitelists > > > > I have added the following to all the patches here and merge this series: > > > > Cc: stable@vger.kernel.org # v6.12+ > > Signed-off-by: Ashutosh Dixit > > Sorry I meant: > > Fixes: 828a8eaf37c3 ("drm/xe/oa: Add MMIO trigger support") > Cc: stable@vger.kernel.org # v6.12+ > > > > > So the plan is to propagate this series to the previous LTS kernel versions > > too, in order to plug this security violation related to unconditional OA > > register whitelisting. > > > > I am preparing v6.12 and v6.18 stable kernel version series, based on this > > series. Since these are a bit old, this series needs porting to these old > > kernel versions. These will be sent after this series reaches Linus' > > master. > > This is needed for patches to be added to stable versions. The series has now been applied to all existing stable branches. The version appied to the branches can be seen at the links below: Remote: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git Branches: stable/linux-6.12.y: https://lore.kernel.org/stable/20260805024915.3407033-1-ashutosh.dixit@intel.com/ stable/linux-6.18.y: https://lore.kernel.org/stable/20260805024614.3406679-1-ashutosh.dixit@intel.com/ stable/linux-7.1.y: https://lore.kernel.org/stable/20260805024300.3406307-1-ashutosh.dixit@intel.com/ Thanks. -- Ashutosh