Re: [PATCH v2 1/2] rust: page: add `SafePage` for race-free page access

[Andreas Hindborg <a.hindborg@kernel.org>]

"Miguel Ojeda" <miguel.ojeda.sandonis@gmail.com> writes:

> On Fri, Jun 5, 2026 at 2:49 PM Andreas Hindborg <a.hindborg@kernel.org> wrote:
>>
>>      bindings,
>> -    error::code::*,
>> -    error::Result,
>> +    error::{
>> +        code::*,
>> +        Result, //
>> +    },
>>      types::{
>>          Opaque,
>>          Ownable,
>
>>  use core::{
>>      marker::PhantomData,
>>      mem::ManuallyDrop,
>> -    ops::Deref,
>> +    ops::{Deref, DerefMut},
>>      ptr::{
>>          self,
>>          NonNull, //
>
> The first hunk fixes the imports, but the second introduces an import
> in the wrong style.
>
> I think the first part should be in its own commit, and the second
> should be here but with the correct style.

This was sitting in my tree on top of already fixed imports. I probably
made a mistake when I separated it for submission.

I am looking forward to the day where rustfmt will be able to handle
this for us without the added slashes.

> But I just noticed the first part should also have been done as part
> of your other patch I applied yesterday, so I just rebased to fix
> that:
>
>   dea66841b9f8 ("rust: page: use the "kernel vertical" imports style").
>

Great, just the second part left then!

Best regards,
Andreas Hindborg