Re: [PATCH net-next 5/9] selftests: drv-net: give HW stats sync time extra 25% of margin

[Petr Machata <petrm@nvidia.com>]

Jakub Kicinski <kuba@kernel.org> writes:

> There are transient failures for devices which update stats
> periodically, especially if it's the FW DMA'ing the stats
> rather than host periodic work querying the FW. Wait 25%
> longer than strictly necessary.
>
> For devices which don't report stats-block-usecs we retain
> 25 msec as the default wait time.

Right, because now the default is 0.2, and we apply the 1.25 multiplier.

> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Reviewed-by: Petr Machata <petrm@nvidia.com>

> ---
>  tools/testing/selftests/drivers/net/lib/py/env.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/drivers/net/lib/py/env.py b/tools/testing/selftests/drivers/net/lib/py/env.py
> index 41cc248ac848..39a98eb2592e 100644
> --- a/tools/testing/selftests/drivers/net/lib/py/env.py
> +++ b/tools/testing/selftests/drivers/net/lib/py/env.py
> @@ -285,7 +285,7 @@ from .remote import Remote
>                  if "Operation not supported" not in e.cmd.stderr:
>                      raise
>  
> -            self._stats_settle_time = 0.025 + \
> -                data.get('stats-block-usecs', 0) / 1000 / 1000
> +            self._stats_settle_time = \
> +                1.25 * data.get('stats-block-usecs', 20000) / 1000 / 1000
>  
>          time.sleep(self._stats_settle_time)