From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E5201D26284 for ; Tue, 20 Jan 2026 18:54:39 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1viGs1-0005CW-Ts; Tue, 20 Jan 2026 13:54:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1viGry-0005B7-Mg for qemu-devel@nongnu.org; Tue, 20 Jan 2026 13:54:26 -0500 Received: from smtp-out2.suse.de ([2a07:de40:b251:101:10:150:64:2]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1viGrw-0008N1-Vb for qemu-devel@nongnu.org; Tue, 20 Jan 2026 13:54:26 -0500 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 311F45BCC9; Tue, 20 Jan 2026 18:54:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1768935263; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zHyr4gg040iZBR6fmFVgGACWVxI3UiejJgX8J6l61S4=; b=Acz368kUqv+19nyYJxq8tDyvDQB2a8iqQMvZQsWTfqW6Fkq/PLv40TO4hvIrTfoGceV/v9 KpQkzL9g1vcMMJ+CLENsMWr6hiepdDF9BWucPrRZKErByNEqzDy95wHeKSGQV4ZRCR1RCo plhmDYc3xT2EYgBYUszfK1TbXXNe5y8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1768935263; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zHyr4gg040iZBR6fmFVgGACWVxI3UiejJgX8J6l61S4=; b=of/fGI0rlUHfwYBZZ+dsM5pm0IM6L0lucTEDlxP94BTnG8q0IVgehAgesmj2gh3cD4ZjkM HIABDT13B7WlzIAQ== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1768935263; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zHyr4gg040iZBR6fmFVgGACWVxI3UiejJgX8J6l61S4=; b=Acz368kUqv+19nyYJxq8tDyvDQB2a8iqQMvZQsWTfqW6Fkq/PLv40TO4hvIrTfoGceV/v9 KpQkzL9g1vcMMJ+CLENsMWr6hiepdDF9BWucPrRZKErByNEqzDy95wHeKSGQV4ZRCR1RCo plhmDYc3xT2EYgBYUszfK1TbXXNe5y8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1768935263; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zHyr4gg040iZBR6fmFVgGACWVxI3UiejJgX8J6l61S4=; b=of/fGI0rlUHfwYBZZ+dsM5pm0IM6L0lucTEDlxP94BTnG8q0IVgehAgesmj2gh3cD4ZjkM HIABDT13B7WlzIAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9612E3EA63; Tue, 20 Jan 2026 18:54:22 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id S//hFF7Pb2k2ZQAAD6G6ig (envelope-from ); Tue, 20 Jan 2026 18:54:22 +0000 From: Fabiano Rosas To: Peter Xu Cc: qemu-devel@nongnu.org, Li Zhijian , Hailiang Zhang , Kevin Wolf , Vladimir Sementsov-Ogievskiy , =?utf-8?Q?Daniel_P_=2E?= =?utf-8?Q?_Berrang=C3=A9?= , Zhang Chen , "Dr . David Alan Gilbert" , Prasad Pandit , Paolo Bonzini , Yury Kotov , Juraj Marcin Subject: Re: [PATCH 08/13] migration: Thread-ify precopy vmstate load process In-Reply-To: References: <20251022192612.2737648-1-peterx@redhat.com> <20251022192612.2737648-9-peterx@redhat.com> <87y0m7df46.fsf@suse.de> <871pju1wlv.fsf@suse.de> <87fr89psu5.fsf@suse.de> <87jyxhmdp6.fsf@suse.de> Date: Tue, 20 Jan 2026 15:54:19 -0300 Message-ID: <87cy34ktd0.fsf@suse.de> MIME-Version: 1.0 Content-Type: text/plain X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.995]; MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; MISSING_XM_UA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[nongnu.org,fujitsu.com,xfusion.com,redhat.com,yandex-team.ru,gmail.com,treblig.org]; RCPT_COUNT_TWELVE(0.00)[13]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_DN_SOME(0.00)[] Received-SPF: pass client-ip=2a07:de40:b251:101:10:150:64:2; envelope-from=farosas@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Peter Xu writes: > On Fri, Jan 16, 2026 at 06:48:21PM -0300, Fabiano Rosas wrote: >> Another one for the pile: >> >> #5 0x00007f0beda4fb32 in __assert_fail (assertion=0x55b8c3ed8cb8 "mode >= 0 ...) at assert.c:103 >> #6 0x000055b8c3a1d7a9 in migrate_mode () at ../migration/options.c:882 >> #7 0x000055b8c3a1084e in fill_source_migration_info (info=0x55b8f1291650) at ../migration/migration.c:1322 >> #8 0x000055b8c3a10cae in qmp_query_migrate (errp=0x7fff5742ae80) at ../migration/migration.c:1438 >> #9 0x000055b8c3d4bc2a in qmp_marshal_query_migrate (args=0x55b8f11f2280, ret=0x7f0becd25da8, errp=0x7f0becd25da0) at qapi/qapi-commands-migration.c:48 >> #10 0x000055b8c3d9a13b in do_qmp_dispatch_bh (opaque=0x7f0becd25e40) at ../qapi/qmp-dispatch.c:128 >> #11 0x000055b8c3dc6366 in aio_bh_call (bh=0x55b8f12922d0) at ../util/async.c:173 >> #12 0x000055b8c3dc6482 in aio_bh_poll (ctx=0x55b8f10741e0) at ../util/async.c:220 >> #13 0x000055b8c3da9832 in aio_poll (ctx=0x55b8f10741e0, blocking=false) at ../util/aio-posix.c:719 >> #14 0x000055b8c3cea017 in monitor_cleanup () at ../monitor/monitor.c:676 >> #15 0x000055b8c39ef646 in qemu_cleanup (status=0) at ../system/runstate.c:999 >> #16 0x000055b8c3cec38e in qemu_default_main (opaque=0x0) at ../system/main.c:51 >> #17 0x000055b8c3cec430 in main (argc=33, argv=0x7fff5742b208) at >> #../system/main.c:93 >> >> (gdb) p/x mode >> $8 = 0xcccccccc > > What's the reproducer? Is it easy to reproduce? > Just hammering some make check instances in parallel, as usual. > I wonder if current_migration released already, or if monitor should still > process any QMP handler if the VM is shutting down.. > monitor_cleanup says it will continue dispatching and just never send a response to the command. It seems migration will need it's own way of tracking this. Maybe as a first step we could clear current_migration at migration_instance_finalize(). (I see device-introspect-test doesn't like it. I'll look into it) > Is this only happening after this series applied? I can't yet see how the > threadify affected it.. No, sorry, I posted here because I think this affects this series' assumptions about the BQL.