All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Les Boys <lesboyspp43@outlook.com>
Cc: "linux-wpan@vger.kernel.org" <linux-wpan@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"alex.aring@gmail.com" <alex.aring@gmail.com>,
	"stefan@datenfreihafen.org" <stefan@datenfreihafen.org>
Subject: Re: [PATCH v1 2/2] net/ieee802154: use channel mask macros replace the hard-coded magic number
Date: Tue, 25 Nov 2025 16:11:11 +0100	[thread overview]
Message-ID: <87cy56uoz4.fsf@bootlin.com> (raw)
In-Reply-To: <SA2PR10MB44609D98484539F0A5948C8DA6D1A@SA2PR10MB4460.namprd10.prod.outlook.com> (Les Boys's message of "Tue, 25 Nov 2025 09:41:30 +0000")

Hello,

On 25/11/2025 at 09:41:30 GMT, Les Boys <lesboyspp43@outlook.com> wrote:

> This commit replaced all the hard-coded magic numbers to macros defined in
> previous commit.

Can you please slightly rephrase into "Replace all the..."

Maybe the title can be shortened a little bit as well.

While I'm fine with this addition (I haven't checked all values), we
would need a proper name and Signed-off-by tag.

Thanks,
Miquèl

  reply	other threads:[~2025-11-25 15:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-25  8:56 [PATCH v1 0/2] ieee802154: use macros to replace hard-coded channel masks Les Boys
2025-11-25  9:36 ` [PATCH v1 1/2] include: add macros for ieee 802.15.4 " Les Boys
2025-11-25  9:41   ` [PATCH v1 2/2] net/ieee802154: use channel mask macros replace the hard-coded magic number Les Boys
2025-11-25 15:11     ` Miquel Raynal [this message]
2025-11-26  6:14       ` [PATCH v2 1/2] include: add macros for ieee 802.15.4 channel masks Les Boys
2025-11-26  6:16       ` [PATCH v2 2/2] net/ieee802154: use channel mask macros replace the hard-coded magic number Les Boys

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cy56uoz4.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=alex.aring@gmail.com \
    --cc=lesboyspp43@outlook.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wpan@vger.kernel.org \
    --cc=stefan@datenfreihafen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.