From: Markus Armbruster <armbru@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: qemu-devel@nongnu.org, Fabiano Rosas <farosas@suse.de>,
Juraj Marcin <jmarcin@redhat.com>
Subject: Re: [PATCH] migration/qmp: Update "resume" flag doc in "migrate" command
Date: Thu, 23 Oct 2025 07:47:11 +0200 [thread overview]
Message-ID: <87cy6eb25c.fsf@pond.sub.org> (raw)
In-Reply-To: <20251022190425.2730441-1-peterx@redhat.com> (Peter Xu's message of "Wed, 22 Oct 2025 15:04:25 -0400")
Peter Xu <peterx@redhat.com> writes:
> It wasn't obvious how the resume flag should be used when staring at the
> QAPI doc. Enrich it to be crystal clear.
>
> Reported-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> qapi/migration.json | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/qapi/migration.json b/qapi/migration.json
> index be0f3fcc12..48856078db 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -1732,7 +1732,10 @@
> # @detach: this argument exists only for compatibility reasons and is
> # ignored by QEMU
> #
> -# @resume: resume one paused migration, default "off". (since 3.0)
> +# @resume: when set, resume one paused postcopy migration, using the new
Scratch "one" unless there can be more than one.
> +# URI/channels specified to replace the old/broken channels. The user
> +# should make sure the migration is in "postcopy-paused" state before
> +# the resume request. Default "off". (since 3.0)
> #
> # Features:
> #
What happens when migration is not in state "postcopy-paused"?
Remind me, how can migration get into and out of this state?
next prev parent reply other threads:[~2025-10-23 5:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-22 19:04 [PATCH] migration/qmp: Update "resume" flag doc in "migrate" command Peter Xu
2025-10-23 5:47 ` Markus Armbruster [this message]
2025-10-23 13:55 ` Peter Xu
2025-10-23 14:04 ` Markus Armbruster
2025-10-23 14:27 ` Peter Xu
2025-10-23 17:20 ` Markus Armbruster
2025-10-23 18:35 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cy6eb25c.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=farosas@suse.de \
--cc=jmarcin@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.