From: Takashi Iwai <tiwai@suse.de>
To: Thorsten Blum <thorsten.blum@linux.dev>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Julia Lawall <Julia.Lawall@inria.fr>,
"Dr. David Alan Gilbert" <linux@treblig.org>,
Wentao Liang <vulab@iscas.ac.cn>, Takashi Iwai <tiwai@suse.de>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda: Improve local variable data type in snd_hda_get_num_devices()
Date: Wed, 13 Aug 2025 17:45:01 +0200 [thread overview]
Message-ID: <87cy8zw7ia.wl-tiwai@suse.de> (raw)
In-Reply-To: <20250813103418.164110-2-thorsten.blum@linux.dev>
On Wed, 13 Aug 2025 12:34:16 +0200,
Thorsten Blum wrote:
>
> Use 'int' instead of 'unsigned int' because the local variable 'parm'
> can be negative.
>
> While an unsigned integer is harmless in practice due to the implicit
> type conversion, it's safer and more idiomatic to use a signed integer
> to properly check for -1.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Applied now. Thanks.
Takashi
prev parent reply other threads:[~2025-08-13 15:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 10:34 [PATCH] ALSA: hda: Improve local variable data type in snd_hda_get_num_devices() Thorsten Blum
2025-08-13 15:45 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cy8zw7ia.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=Julia.Lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux@treblig.org \
--cc=perex@perex.cz \
--cc=thorsten.blum@linux.dev \
--cc=tiwai@suse.com \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.