All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: noble228@gmail.com
Cc: tiwai@suse.com, perex@perex.cz, hulianqin@vivo.com,
	lina+kernel@asahilina.net, cyan.vtb@gmail.com,
	dan.carpenter@linaro.org, bsevens@google.com,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
	"noble.yang" <noble.yang@comtrue-inc.com>
Subject: Re: [PATCH] ALSA: usb-audio: Add DSD support for Comtrue USB Audio device
Date: Thu, 31 Jul 2025 11:15:51 +0200	[thread overview]
Message-ID: <87cy9gsou0.wl-tiwai@suse.de> (raw)
In-Reply-To: <20250731081559.10842-1-noble228@gmail.com>

On Thu, 31 Jul 2025 10:15:59 +0200,
noble228@gmail.com wrote:
> 
> From: "noble.yang" <noble.yang@comtrue-inc.com>
> 

Could you fill the patch description?  You already wrote enough
information in the original post, and put the text here.

> --- a/sound/usb/quirks.c
> +++ b/sound/usb/quirks.c
> @@ -2408,6 +2408,8 @@ static const struct usb_audio_quirk_flags_table quirk_flags_table[] = {
>  		   QUIRK_FLAG_DSD_RAW),
>  	VENDOR_FLG(0x2d87, /* Cayin device */
>  		   QUIRK_FLAG_DSD_RAW),
> +        VENDOR_FLG(0x2fc6, /* Comture-inc devices */

The indentation doesn't look right.  Try to use tabs.


thanks,

Takashi

  reply	other threads:[~2025-07-31  9:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-31  8:15 [PATCH] ALSA: usb-audio: Add DSD support for Comtrue USB Audio device noble228
2025-07-31  9:15 ` Takashi Iwai [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-07-31 11:06 noble228
2025-07-31 15:01 ` Takashi Iwai
2025-07-31  4:51 noble.yang
2025-07-31  5:39 ` Takashi Iwai
2025-07-31  5:50   ` noble.yang
2025-07-31  5:51     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cy9gsou0.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=bsevens@google.com \
    --cc=cyan.vtb@gmail.com \
    --cc=dan.carpenter@linaro.org \
    --cc=hulianqin@vivo.com \
    --cc=lina+kernel@asahilina.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=noble.yang@comtrue-inc.com \
    --cc=noble228@gmail.com \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.