All of lore.kernel.org
 help / color / mirror / Atom feed
From: Collin Funk <collin.funk1@gmail.com>
To: Carlo Arenas <carenas@gmail.com>
Cc: "brian m. carlson" <sandals@crustytoothpaste.net>,
	 Justin Tobler <jltobler@gmail.com>,
	 git@vger.kernel.org,  Junio C Hamano <gitster@pobox.com>,
	 Taylor Blau <me@ttaylorr.com>,
	 semtlenori@gmail.com
Subject: Re: [PATCH 1/1] http: don't send C or POSIX in Accept-Language
Date: Fri, 11 Jul 2025 15:17:26 -0700	[thread overview]
Message-ID: <87cya6xthl.fsf@gmail.com> (raw)
In-Reply-To: <CAPUEsphkzaibm2FMBoj-9nbFch7UgRvyvmzErmno0z+2k5X+OA@mail.gmail.com>

Carlo Arenas <carenas@gmail.com> writes:

>> I don't want to implement language tag parsing here since we don't need
>> to do that.  I would like to do the simple thing to prevent commonly
>> used locales that don't represent actual language tags from being
>> included and not overengineer this design
>
> I think that your design of filtering C and POSIX accomplishes that,
> even if it might seem like hardcoding those two values is a little dirty.

Thanks for correcting me regarding language tag length Carlo.

I guess I am fine with filtering out "C" and "POSIX" now. Not perfect,
but I think everyone agrees that we don't want to maintain a database of
language tags just for this.

Collin

  reply	other threads:[~2025-07-11 22:17 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-10 22:16 [PATCH 0/1] Filter C and POSIX out of Accept-Language brian m. carlson
2025-07-10 22:16 ` [PATCH 1/1] http: don't send C or POSIX in Accept-Language brian m. carlson
2025-07-10 22:47   ` Junio C Hamano
2025-07-10 23:08     ` brian m. carlson
2025-07-11 15:23   ` Justin Tobler
2025-07-11 17:02     ` Collin Funk
2025-07-11 20:57       ` Carlo Marcelo Arenas Belón
2025-07-11 21:29         ` brian m. carlson
2025-07-11 22:12           ` Carlo Arenas
2025-07-11 22:17             ` Collin Funk [this message]
2025-07-11 18:32     ` Junio C Hamano
2025-07-11 20:22       ` Carlo Marcelo Arenas Belón
2025-07-15  4:38   ` Eli Schwartz
2025-07-10 22:45 ` [PATCH 0/1] Filter C and POSIX out of Accept-Language Junio C Hamano
2025-07-10 23:08   ` brian m. carlson
2025-07-10 23:26     ` Collin Funk
2025-07-11  2:49       ` [External] " Han Young
2025-07-11 16:46         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cya6xthl.fsf@gmail.com \
    --to=collin.funk1@gmail.com \
    --cc=carenas@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jltobler@gmail.com \
    --cc=me@ttaylorr.com \
    --cc=sandals@crustytoothpaste.net \
    --cc=semtlenori@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.