From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35E48C83F03 for ; Fri, 4 Jul 2025 14:57:09 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXhiy-0000qG-LU; Fri, 04 Jul 2025 10:49:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXhit-0000Vv-Ev for qemu-devel@nongnu.org; Fri, 04 Jul 2025 10:49:08 -0400 Received: from smtp-out1.suse.de ([195.135.223.130]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXhir-0000vg-OB for qemu-devel@nongnu.org; Fri, 04 Jul 2025 10:49:07 -0400 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 00287211A2; Fri, 4 Jul 2025 14:49:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751640543; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=U8SZh0rOPjup85DuMeh0/kTZzd4nWo9n+jCNMsKY1Z4=; b=SSu7zxnkuuViJ+N25e3H2Hyq1p7/ov8nmgt/IHyS8Rd1hQLHa2nM7IFM6QbXHTQCIek7rl RR5ZdCIc0yH3dGn+jHAagOJIHT2cuw9i1JtkVvFFDPuVgW0YPw5tlM3vO94Wxhs/Y30XBR RUJl6nmch3HGQxiS8CGbUeFX/Hx4n1s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751640543; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=U8SZh0rOPjup85DuMeh0/kTZzd4nWo9n+jCNMsKY1Z4=; b=Zg6AlSgb0Ou2UQO/Cmnk0QaR74RbqYu2wv/ucRmMS35vnp70vN5miNHCmEp2qw5EpoqnIT R/+7zP/r7KFHLrCw== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=SSu7zxnk; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Zg6AlSgb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751640543; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=U8SZh0rOPjup85DuMeh0/kTZzd4nWo9n+jCNMsKY1Z4=; b=SSu7zxnkuuViJ+N25e3H2Hyq1p7/ov8nmgt/IHyS8Rd1hQLHa2nM7IFM6QbXHTQCIek7rl RR5ZdCIc0yH3dGn+jHAagOJIHT2cuw9i1JtkVvFFDPuVgW0YPw5tlM3vO94Wxhs/Y30XBR RUJl6nmch3HGQxiS8CGbUeFX/Hx4n1s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751640543; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=U8SZh0rOPjup85DuMeh0/kTZzd4nWo9n+jCNMsKY1Z4=; b=Zg6AlSgb0Ou2UQO/Cmnk0QaR74RbqYu2wv/ucRmMS35vnp70vN5miNHCmEp2qw5EpoqnIT R/+7zP/r7KFHLrCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8354313A71; Fri, 4 Jul 2025 14:49:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id JIMpE97pZ2jwfQAAD6G6ig (envelope-from ); Fri, 04 Jul 2025 14:49:02 +0000 From: Fabiano Rosas To: Markus Armbruster Cc: qemu-devel@nongnu.org, berrange@redhat.com, Peter Xu , Eric Blake Subject: Re: [PATCH v2 16/24] migration: Add capabilities into MigrationParameters In-Reply-To: <8734bckq6n.fsf@pond.sub.org> References: <20250630195913.28033-1-farosas@suse.de> <20250630195913.28033-17-farosas@suse.de> <87jz4sz5b6.fsf@pond.sub.org> <87h5zs3xng.fsf@suse.de> <8734bckq6n.fsf@pond.sub.org> Date: Fri, 04 Jul 2025 11:48:56 -0300 Message-ID: <87cyag3tbb.fsf@suse.de> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 00287211A2 X-Rspamd-Action: no action X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_VIA_SMTP_AUTH(0.00)[]; MISSING_XM_UA(0.00)[]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_RATELIMITED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,suse.de:dkim,suse.de:mid,suse.de:email]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received]; DKIM_TRACE(0.00)[suse.de:+] Received-SPF: pass client-ip=195.135.223.130; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.218, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Markus Armbruster writes: > Fabiano Rosas writes: > >> Markus Armbruster writes: >> >>> Fabiano Rosas writes: >>> >>>> Add capabilities to MigrationParameters. This structure will hold all >>>> migration options. Capabilities will go away in the next patch. >>>> >>>> Also add capabilities to MigrationParameter as the enum needs to be >>>> kept in sync with MigrationParameters. This affects the parsing of >>>> migration HMP commands so make the necessary additions there too. >>>> >>>> From this point on, both QMP and HMP versions of >>>> migrate-set-parameters and query-migrate-parameters gain the ability >>>> to work with capabilities. >>>> >>>> With MigrationParameters now having members for each capability, the >>>> migration capabilities commands (query-migrate-capabilities, >>>> migrate-set-capabilities) will soon be deprecated. Add a set of >>>> helpers to convert between the old MigrationCapability representation >>>> and the new representation as members of MigrationParameters. >>>> >>>> Signed-off-by: Fabiano Rosas >>> >>> [...] >>> >>>> diff --git a/qapi/migration.json b/qapi/migration.json >>>> index 40e00fb86e..3d3f5624c5 100644 >>>> --- a/qapi/migration.json >>>> +++ b/qapi/migration.json >>>> @@ -763,7 +763,14 @@ >>>> 'vcpu-dirty-limit', >>>> 'mode', >>>> 'zero-page-detection', >>>> - 'direct-io'] } >>>> + 'direct-io', 'xbzrle', 'rdma-pin-all', 'auto-converge', >>>> + 'zero-blocks', 'events', 'postcopy-ram', 'x-colo', >>>> + 'release-ram', 'return-path', 'pause-before-switchover', >>>> + 'multifd', 'dirty-bitmaps', 'postcopy-blocktime', >>>> + 'late-block-activate', 'x-ignore-shared', >>>> + 'validate-uuid', 'background-snapshot', >>>> + 'zero-copy-send', 'postcopy-preempt', >>>> + 'switchover-ack', 'dirty-limit', 'mapped-ram' ] } >>> >>> This is MigrateParameter. Different order than in MigrationParameters. >>> Intentional? >>> >> >> I think you mean the pre-existing difference in the order of the >> compression options multifd-*-level? I'll fix that. > > I noticed the new members are in a different order than in > MigrationParameters. I didn't notice the existing members differ, too. > Sorry, I don't see it, we must be looking at different things. >> If it's something else, it eludes my gaze. > > No. > > Thanks!