From: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
To: "Nirjhar Roy (IBM)" <nirjhar.roy.lists@gmail.com>,
fstests@vger.kernel.org
Cc: linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
ojaswin@linux.ibm.com, djwong@kernel.org, zlang@kernel.org,
david@fromorbit.com, nirjhar.roy.lists@gmail.com
Subject: Re: [PATCH v2 2/2] new: Replace "status=0; exit 0" with _exit 0
Date: Sat, 17 May 2025 11:28:38 +0530 [thread overview]
Message-ID: <87cyc7wzg1.fsf@gmail.com> (raw)
In-Reply-To: <463f1f99c7b9ced218f62ea9fc048c2e645227c5.1747306604.git.nirjhar.roy.lists@gmail.com>
"Nirjhar Roy (IBM)" <nirjhar.roy.lists@gmail.com> writes:
> We should now start using _exit 0 for every new test
> that we add.
>
Right every test now sources common/exit in _begin_test() preamble.
So we may as well start using _exit for new tests.
Looks good to me. Please feel free to add:
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
> Signed-off-by: Nirjhar Roy (IBM) <nirjhar.roy.lists@gmail.com>
> Reviewed-by: Zorro Lang <zlang@redhat.com>
> ---
> new | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/new b/new
> index 636648e2..dff69265 100755
> --- a/new
> +++ b/new
> @@ -176,8 +176,7 @@ exit
> #echo "If failure, check \$seqres.full (this) and \$seqres.full.ok (reference)"
>
> # success, all done
> -status=0
> -exit
> +_exit 0
> End-of-File
>
> sleep 2 # latency to read messages to this point
> --
> 2.34.1
prev parent reply other threads:[~2025-05-17 6:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-15 11:00 [PATCH v2 0/2] new: Improvements to new script Nirjhar Roy (IBM)
2025-05-15 11:00 ` [PATCH v2 1/2] new: Add a new parameter (name/emailid) in the "new" script Nirjhar Roy (IBM)
2025-05-17 2:48 ` Ritesh Harjani
2025-05-19 5:21 ` Nirjhar Roy (IBM)
2025-05-20 23:31 ` Dave Chinner
2025-05-21 5:22 ` Nirjhar Roy (IBM)
2025-05-22 0:51 ` Dave Chinner
2025-05-22 4:50 ` Nirjhar Roy (IBM)
2025-05-15 11:00 ` [PATCH v2 2/2] new: Replace "status=0; exit 0" with _exit 0 Nirjhar Roy (IBM)
2025-05-17 5:58 ` Ritesh Harjani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cyc7wzg1.fsf@gmail.com \
--to=ritesh.list@gmail.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=nirjhar.roy.lists@gmail.com \
--cc=ojaswin@linux.ibm.com \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.