Re: [PATCH 1/2] util: fix msan findings in keyval

[Markus Armbruster <armbru@redhat.com>]

Nabih Estefan <nabihestefan@google.com> writes:

> From: Peter Foley <pefoley@google.com>
>
> e.g.
> I	2025-02-28 09:51:05.240071-0800		624	stream.go:47	qemu: Uninitialized value was created by an allocation of 'key_in_cur.i' in the stack frame
> I	2025-02-28 09:51:05.240187-0800		624	stream.go:47	qemu: #0 0xaaaac49f489c in keyval_parse_one third_party/qemu/util/keyval.c:190:5
>
> Signed-off-by: Peter Foley <pefoley@google.com>
> Signed-off-by: Nabih Estefan <nabihestefan@google.com>
> ---
>  util/keyval.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/util/keyval.c b/util/keyval.c
> index a70629a481..f33c64079d 100644
> --- a/util/keyval.c
> +++ b/util/keyval.c
> @@ -187,7 +187,7 @@ static const char *keyval_parse_one(QDict *qdict, const char *params,
>  {
>      const char *key, *key_end, *val_end, *s, *end;
>      size_t len;
> -    char key_in_cur[128];
> +    char key_in_cur[128] = {};
>      QDict *cur;
>      int ret;
>      QObject *next;

Prior review of Peter's patch concluded this must be false positive:
https://lore.kernel.org/qemu-devel/14168384-ecdb-4c05-8267-ac5ef1c46fe9@redhat.com/