All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Ramon Fontes <ramonreisfontes@gmail.com>
Cc: davem@davemloft.net,  kuba@kernel.org,  pabeni@redhat.com,
	linux-wpan@vger.kernel.org,  alex.aring@gmail.com,
	netdev@vger.kernel.org
Subject: Re: [PATCH] mac802154_hwsim: define perm_extended_addr initialization
Date: Wed, 26 Mar 2025 11:12:01 +0100	[thread overview]
Message-ID: <87cye4qexa.fsf@bootlin.com> (raw)
In-Reply-To: <20250325165312.26938-1-ramonreisfontes@gmail.com> (Ramon Fontes's message of "Tue, 25 Mar 2025 13:53:12 -0300")

Hello Ramon,

On 25/03/2025 at 13:53:12 -03, Ramon Fontes <ramonreisfontes@gmail.com> wrote:

> This establishes an initialization method for perm_extended_addr, aligning it with the approach used in mac80211_hwsim.

You are now enforcing an (almost) static value, is that the intended
behaviour? If yes I would like a better explanation of why this is
relevant and how you picked eg. 0x02 as prefix to justify the change.

In general I am not opposed, even though I kind of liked the idea of
generating random addresses, especially since hwsim is not the only one
to do that and having a simulator that behaves like regular device
drivers actually makes sense IMO.

Also, please wrap the commit log.

> Signed-off-by: Ramon Fontes <ramonreisfontes@gmail.com>

Thanks,
Miquèl

  reply	other threads:[~2025-03-26 10:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-25 16:53 [PATCH] mac802154_hwsim: define perm_extended_addr initialization Ramon Fontes
2025-03-26 10:12 ` Miquel Raynal [this message]
2025-03-26 10:34   ` Ramon Fontes
2025-03-26 17:00     ` Miquel Raynal
  -- strict thread matches above, loose matches on Subject: below --
2025-03-26 18:09 Ramon Fontes
2025-03-26 22:49 ` Alexander Aring
2025-03-26 23:24   ` Ramon Fontes
2025-03-29 14:20 Ramon Fontes
2025-03-31  8:15 ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cye4qexa.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=alex.aring@gmail.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-wpan@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=ramonreisfontes@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.