All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Sai Teja Pottumuttu <sai.teja.pottumuttu@intel.com>
Cc: <igt-dev@lists.freedesktop.org>, <umesh.nerlige.ramappa@intel.com>
Subject: Re: [PATCH i-g-t] tests/intel/xe_oa: Keep OA user buffer size dynamic
Date: Mon, 17 Mar 2025 10:46:09 -0700	[thread overview]
Message-ID: <87cyef35zy.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20250317173028.3186378-1-sai.teja.pottumuttu@intel.com>

On Mon, 17 Mar 2025 10:30:28 -0700, Sai Teja Pottumuttu wrote:
>
> non-zero-reason OA test has a hardcoded user buffer size for
> any kernel OA buffer. This makes the test act differently for
> different sizes. Thus make the user buffer size to be in line
> with the kernel OA buffer being allocated.
>
> Signed-off-by: Sai Teja Pottumuttu <sai.teja.pottumuttu@intel.com>
> ---
>  tests/intel/xe_oa.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c
> index 9bc62c5b9..fbf4034aa 100644
> --- a/tests/intel/xe_oa.c
> +++ b/tests/intel/xe_oa.c
> @@ -2480,7 +2480,7 @@ test_non_zero_reason(const struct drm_xe_engine_class_instance *hwe, size_t oa_b
>		.num_properties = ARRAY_SIZE(properties) / 2,
>		.properties_ptr = to_user_pointer(properties),
>	};
> -	uint32_t buf_size = 3 * 65536 * report_size;
> +	uint32_t buf_size = 3 * oa_buffer_size ?: buffer_fill_size;

Shouldn't this be:

	3 * (oa_buffer_size ?: buffer_fill_size);

  reply	other threads:[~2025-03-17 17:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-17 17:30 [PATCH i-g-t] tests/intel/xe_oa: Keep OA user buffer size dynamic Sai Teja Pottumuttu
2025-03-17 17:46 ` Dixit, Ashutosh [this message]
2025-03-17 18:02 ` ✓ Xe.CI.BAT: success for " Patchwork
2025-03-17 18:20 ` ✓ i915.CI.BAT: " Patchwork
2025-03-18  9:46 ` ✗ Xe.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cyef35zy.wl-ashutosh.dixit@intel.com \
    --to=ashutosh.dixit@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=sai.teja.pottumuttu@intel.com \
    --cc=umesh.nerlige.ramappa@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.