From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Pierrick Bouvier" <pierrick.bouvier@linaro.org>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Thomas Huth" <thuth@redhat.com>
Subject: Re: [RFC PATCH 01/11] system: Extract target-specific globals to their own compilation unit
Date: Tue, 11 Mar 2025 10:24:14 +0000 [thread overview]
Message-ID: <87cyen6f1t.fsf@draig.linaro.org> (raw)
In-Reply-To: <20250305005225.95051-2-philmd@linaro.org> ("Philippe Mathieu-Daudé"'s message of "Wed, 5 Mar 2025 01:52:15 +0100")
Philippe Mathieu-Daudé <philmd@linaro.org> writes:
> We shouldn't use target specific globals for machine properties.
> These ones could be desugarized, as explained in [*]. While
> certainly doable, not trivial nor my priority for now. Just move
> them to a different file to clarify they are *globals*, like the
> generic globals residing in system/globals.c.
>
> [*] https://lore.kernel.org/qemu-devel/e514d6db-781d-4afe-b057-9046c70044dc@redhat.com/
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
next prev parent reply other threads:[~2025-03-11 10:25 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-05 0:52 [RFC PATCH 00/11] qemu: Remove TARGET_NAME definition Philippe Mathieu-Daudé
2025-03-05 0:52 ` [RFC PATCH 01/11] system: Extract target-specific globals to their own compilation unit Philippe Mathieu-Daudé
2025-03-05 1:20 ` Pierrick Bouvier
2025-03-05 1:33 ` Philippe Mathieu-Daudé
2025-03-05 1:41 ` Pierrick Bouvier
2025-03-11 10:24 ` Alex Bennée [this message]
2025-03-05 0:52 ` [RFC PATCH 02/11] system: Open-code qemu_init_arch_modules() using target_name() Philippe Mathieu-Daudé
2025-03-05 2:27 ` Richard Henderson
2025-03-05 0:52 ` [RFC PATCH 03/11] system: Introduce QemuArchBit enum Philippe Mathieu-Daudé
2025-03-05 1:23 ` Pierrick Bouvier
2025-03-05 1:31 ` Philippe Mathieu-Daudé
2025-03-05 1:36 ` Pierrick Bouvier
2025-03-05 1:39 ` Philippe Mathieu-Daudé
2025-03-05 2:27 ` Richard Henderson
2025-03-05 8:55 ` Daniel P. Berrangé
2025-03-05 9:00 ` Daniel P. Berrangé
2025-03-05 0:52 ` [RFC PATCH 04/11] system: Replace arch_type global by qemu_arch_available() helper Philippe Mathieu-Daudé
2025-03-05 2:29 ` Richard Henderson
2025-03-05 0:52 ` [RFC PATCH 05/11] include: Expose QemuArchBit enum to user emulation Philippe Mathieu-Daudé
2025-03-05 2:43 ` Richard Henderson
2025-03-05 0:52 ` [RFC PATCH 06/11] include: Declare target_name() in common "qemu/arch_info.h" Philippe Mathieu-Daudé
2025-03-05 2:44 ` Richard Henderson
2025-03-05 0:52 ` [RFC PATCH 07/11] plugins/loader: populate target_name with target_name() Philippe Mathieu-Daudé
2025-03-05 0:52 ` [RFC PATCH 08/11] tests/qtest: Replace TARGET_NAME -> target_name() Philippe Mathieu-Daudé
2025-03-05 3:02 ` Richard Henderson
2025-03-05 0:52 ` [RFC PATCH 09/11] user: " Philippe Mathieu-Daudé
2025-03-05 0:52 ` [RFC PATCH 10/11] qemu: Introduce qemu_arch_name() helper Philippe Mathieu-Daudé
2025-03-05 1:32 ` BALATON Zoltan
2025-03-05 1:36 ` Philippe Mathieu-Daudé
2025-03-05 2:05 ` BALATON Zoltan
2025-03-05 2:23 ` Richard Henderson
2025-03-05 8:59 ` Daniel P. Berrangé
2025-03-05 0:52 ` [RFC PATCH 11/11] qemu: Remove C definitions of TARGET_NAME Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cyen6f1t.fsf@draig.linaro.org \
--to=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.