From: Kalle Valo <kvalo@kernel.org>
To: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
Cc: <ath12k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
Dan Carpenter <dan.carpenter@linaro.org>
Subject: Re: [PATCH v4 3/4] wifi: ath12k: Remove ath12k_get_num_hw() helper function
Date: Tue, 14 Jan 2025 20:31:33 +0200 [thread overview]
Message-ID: <87cygpp7qy.fsf@kernel.org> (raw)
In-Reply-To: <20250112071630.4059410-4-quic_periyasa@quicinc.com> (Karthikeyan Periyasamy's message of "Sun, 12 Jan 2025 12:46:29 +0530")
Karthikeyan Periyasamy <quic_periyasa@quicinc.com> writes:
> Currently, the ath12k_get_num_hw() helper function takes the device handle
> as an argument. Here, the number of hardware is retrieved from the group
> handle. Demanding the device handle from the caller is unnecessary since
> in some cases the group handle is already available. Additionally, there
> is no longer a need for multiple indirections to get the number of
> hardware. Therefore, remove this helper function and directly use
> ag->num_hw. This change also fixes the below Smatch static checker
> warning.
>
> Smatch warning:
> ath12k_mac_destroy() error: we previously assumed 'ab' could be null
>
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1
>
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Closes: https://lore.kernel.org/ath12k/3e705de0-67d1-4437-97ff-4828d83ae2af@stanley.mountain/
> Closes: https://scan7.scan.coverity.com/#/project-view/52682/11354?selectedIssue=1602340
> Fixes: a343d97f27f5 ("wifi: ath12k: move struct ath12k_hw from per device to group")
> Signed-off-by: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
Acked-by: Kalle Valo <kvalo@kernel.org>
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2025-01-14 19:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-12 7:16 [PATCH v4 0/4] wifi: ath12k: Fix the static checker warning Karthikeyan Periyasamy
2025-01-12 7:16 ` [PATCH v4 1/4] wifi: ath12k: Refactor ath12k_hw set helper function argument Karthikeyan Periyasamy
2025-01-14 18:28 ` Kalle Valo
2025-01-14 18:29 ` Kalle Valo
2025-01-12 7:16 ` [PATCH v4 2/4] wifi: ath12k: Refactor the ath12k_hw get " Karthikeyan Periyasamy
2025-01-14 18:30 ` Kalle Valo
2025-01-12 7:16 ` [PATCH v4 3/4] wifi: ath12k: Remove ath12k_get_num_hw() helper function Karthikeyan Periyasamy
2025-01-13 16:12 ` Jeff Johnson
2025-01-14 18:31 ` Kalle Valo [this message]
2025-01-12 7:16 ` [PATCH v4 4/4] wifi: ath12k: Fix uninitialized variable access in ath12k_mac_allocate() function Karthikeyan Periyasamy
2025-01-14 18:32 ` Kalle Valo
2025-01-14 20:54 ` [PATCH v4 0/4] wifi: ath12k: Fix the static checker warning Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cygpp7qy.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ath12k@lists.infradead.org \
--cc=dan.carpenter@linaro.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_periyasa@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.