From: Markus Armbruster <armbru@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org,
eblake@redhat.com, devel@lists.libvirt.org, hreitz@redhat.com,
kwolf@redhat.com, jsnow@redhat.com, pkrempa@redhat.com
Subject: Re: [PATCH v3 6/7] qapi/block-core: deprecate block-job-change
Date: Thu, 07 Nov 2024 08:37:13 +0100 [thread overview]
Message-ID: <87cyj7mr4m.fsf@pond.sub.org> (raw)
In-Reply-To: <20241002140616.561652-7-vsementsov@yandex-team.ru> (Vladimir Sementsov-Ogievskiy's message of "Wed, 2 Oct 2024 17:06:15 +0300")
Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> writes:
> That's a first step to move on newer job-* APIs.
>
> The difference between block-job-change and job-change is in
> find_block_job_locked() vs find_job_locked() functions. What's
> different?
>
> 1. find_block_job_locked() finds only block jobs, whereas
> find_job_locked() finds any kind of job. job-change is a
> compatible extension of block-job-change.
>
> 2. find_block_job_locked() reports DeviceNotActive on failure, when
> find_job_locked() reports GenericError. Since the kind of error
> reported isn't documented for either command, and clients
> shouldn't rely on undocumented error details, job-change is a
> compatible replacement for block-job-change.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Acked-by: Markus Armbruster <armbru@redhat.com>
next prev parent reply other threads:[~2024-11-07 7:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-02 14:06 [PATCH v3 0/7] introduce job-change qmp command Vladimir Sementsov-Ogievskiy
2024-10-02 14:06 ` [PATCH v3 1/7] qapi: rename BlockJobChangeOptions to JobChangeOptions Vladimir Sementsov-Ogievskiy
2024-10-02 14:06 ` [PATCH v3 2/7] blockjob: block_job_change_locked(): check job type Vladimir Sementsov-Ogievskiy
2024-10-02 14:06 ` [PATCH v3 3/7] qapi: block-job-change: make copy-mode parameter optional Vladimir Sementsov-Ogievskiy
2024-10-22 12:35 ` Kevin Wolf
2024-10-29 11:32 ` Vladimir Sementsov-Ogievskiy
2024-10-02 14:06 ` [PATCH v3 4/7] blockjob: move change action implementation to job from block-job Vladimir Sementsov-Ogievskiy
2024-10-22 13:00 ` Kevin Wolf
2024-10-02 14:06 ` [PATCH v3 5/7] qapi: add job-change Vladimir Sementsov-Ogievskiy
2024-10-22 13:03 ` Kevin Wolf
2024-10-02 14:06 ` [PATCH v3 6/7] qapi/block-core: deprecate block-job-change Vladimir Sementsov-Ogievskiy
2024-11-07 7:37 ` Markus Armbruster [this message]
2024-10-02 14:06 ` [PATCH v3 7/7] iotests/mirror-change-copy-mode: switch to job-change command Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cyj7mr4m.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=devel@lists.libvirt.org \
--cc=eblake@redhat.com \
--cc=hreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=pkrempa@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.