From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB795335D3 for ; Fri, 1 Nov 2024 13:20:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730467223; cv=none; b=ehRUdqb0JbhaWvqx4Cm0r3AviRKQ7OrJcA6CJLoNYvSC3OnWMrAk7FBdYG0V+HOswSTxMnGdnl1hHePUIfZsdAIPu5arUbfFnvNKWfT4ldUrapIQY6zo+Ggk3Q+sn3HXutrKsPd4WSqB2aDwrsonSQqSGNm1Sb5Jc6TdpYmWQrs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730467223; c=relaxed/simple; bh=Ib8c0+yuO2W2Ly0kNs6PCZE+6yi5m+yTERQ1KrasL38=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=f0NS0fYKpUbQN1mqZ30sVGBUyL/4lsIWhhdt4RvBIFyNfACUAq+XkChSrWqvktaQ/+7rX2Ar67HeSX5BaH9Krl0orNZQ5J2AERMgHGzsAKDeCke3jdpkPlLGtwu3Mybbf2pWVuIIuPAU4gQCDIa4nR7q+anQYI4WhMEGNWctSF8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=UeP8CHfs; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UeP8CHfs" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730467220; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ib8c0+yuO2W2Ly0kNs6PCZE+6yi5m+yTERQ1KrasL38=; b=UeP8CHfsqcotZPPLvKPPdKM5UVRjgHqfOW1Sq2sB1CHTjCKzer6M5De8RXqzYQsfcMgFQS eTnWi52hfpUg8Ojbva3+FWY34byu5V8115sjq2zW2dD9WfRQUhNkuW/IV/8+RaQpNKrphT l3M9EkWy+JQctJbbyo7BVJCJnqkYMTM= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-170-T-NXYRUGMl6TnPbZMD1p-Q-1; Fri, 01 Nov 2024 09:20:18 -0400 X-MC-Unique: T-NXYRUGMl6TnPbZMD1p-Q-1 Received: by mail-ed1-f69.google.com with SMTP id 4fb4d7f45d1cf-5c943824429so1274140a12.1 for ; Fri, 01 Nov 2024 06:20:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730467218; x=1731072018; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ib8c0+yuO2W2Ly0kNs6PCZE+6yi5m+yTERQ1KrasL38=; b=e/haCOjUsFC95JTAxybuKQX2e4gn2WeUR17vwXJI4wO+BFZcTN2sMSCDCdO/25af0o N9FKP4M3KQ4mXqsIdJaEc3TZxJdvZXfw8x4JrTiHp192LRqiO0ebAfMDv/9GEd9tlYef Zg8RRl3LQSO33E5iA0X3tDS6anaD2XXt7KZJWMt5nn4/i0797UcMP1KTaegZvHXO015l m1vkgSraCDld7kK1b1BHAz85nCZT8ilG8biTPfp7v5x4sz+spzjGaZ2DC47gsuhgPy6F o+Y6Pf1280fA+4NxBPunFxk9XZCKppdv/YjQEjob9UhuVkuHdoi9UwlAIHMQtbBqmvAf EtIw== X-Forwarded-Encrypted: i=1; AJvYcCUe1djgx6HOYwZ9Hj6Xi6Tt6UebF0WXezxV192YtmRwE4TSeq9LUfBSD3eSI8ChDrzSms8=@vger.kernel.org X-Gm-Message-State: AOJu0YyTiTFSSIfJyDA5J2bKUqTQJBaNYxBxNcYKu0S3lVIGRkTofibT 4CbnX4GZAvn5XsdXIfsHgTRjoUfAnHoXuBazyt5zQBsZzjOOEeDOR2IwBqt+IOih9yjln9YHUkj 2p0+K3AWRDnFlV+GeanaHmHwSKIYfGXLkD2/QduFKm2v5WGpwkw== X-Received: by 2002:a05:6402:1ed5:b0:5cb:6ca4:f4cd with SMTP id 4fb4d7f45d1cf-5cbbf8796ddmr18547512a12.7.1730467217646; Fri, 01 Nov 2024 06:20:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFn2LPy1gUSuHKruS07GtqCmqVzlHOCD3B7tPcLNUXMz/VgPBnOw/2+LoemulFTTN8uCfv4sg== X-Received: by 2002:a05:6402:1ed5:b0:5cb:6ca4:f4cd with SMTP id 4fb4d7f45d1cf-5cbbf8796ddmr18547486a12.7.1730467217170; Fri, 01 Nov 2024 06:20:17 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([2a0c:4d80:42:443::2]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5ceac74c6a3sm1513563a12.1.2024.11.01.06.20.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Nov 2024 06:20:15 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 1A99E164B96C; Fri, 01 Nov 2024 14:20:13 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Alexander Lobakin , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Alexander Lobakin , Alexei Starovoitov , Daniel Borkmann , John Fastabend , Andrii Nakryiko , Maciej Fijalkowski , Stanislav Fomichev , Magnus Karlsson , nex.sw.ncis.osdt.itp.upstreaming@intel.com, bpf@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v3 13/18] xsk: allow attaching XSk pool via xdp_rxq_info_reg_mem_model() In-Reply-To: <20241030165201.442301-14-aleksander.lobakin@intel.com> References: <20241030165201.442301-1-aleksander.lobakin@intel.com> <20241030165201.442301-14-aleksander.lobakin@intel.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Fri, 01 Nov 2024 14:20:13 +0100 Message-ID: <87cyjf9jle.fsf@toke.dk> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Alexander Lobakin writes: > When you register an XSk pool as XDP Rxq info memory model, you then > need to manually attach it after the registration. > Let the user combine both actions into one by just passing a pointer > to the pool directly to xdp_rxq_info_reg_mem_model(), which will take > care of calling xsk_pool_set_rxq_info(). This looks similar to how a > &page_pool gets registered and reduce repeating driver code. > > Acked-by: Maciej Fijalkowski > Signed-off-by: Alexander Lobakin Reviewed-by: Toke H=C3=B8iland-J=C3=B8rgensen