From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Subject: Re: [PATCH 5/5] drm/i915/bios: Extract soc/intel_rom.c
Date: Mon, 23 Sep 2024 12:13:53 +0300 [thread overview]
Message-ID: <87cyku7mwe.fsf@intel.com> (raw)
In-Reply-To: <Zu2qr4hk5eelFboL@intel.com>
On Fri, 20 Sep 2024, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Thu, Sep 12, 2024 at 03:44:32PM +0300, Jani Nikula wrote:
>> Just nitpicking, but should this (and rom reads above) now sanity check
>> offset+size against rom->size? IDK if it's worth it for such a simple
>> thing. The caller is supposed to know what it's doing.
>
> I considered that but decided to cut my losses before I
> end up designing a whole new kernel subsystem.
Good call. :)
BR,
Jani.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2024-09-23 9:14 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 13:42 [PATCH 0/5] drm/i915/bios: Refactor ROM access Ville Syrjala
2024-09-10 13:42 ` [PATCH 1/5] drm/i915/bios: Add some size checks to SPI VBT read Ville Syrjala
2024-09-12 11:56 ` Jani Nikula
2024-09-10 13:42 ` [PATCH 2/5] drm/i915/bios: Round PCI ROM VBT allocation to multiple of 4 Ville Syrjala
2024-09-12 11:57 ` Jani Nikula
2024-09-10 13:42 ` [PATCH 3/5] drm/i915/bios: Extract intel_spi_read16() Ville Syrjala
2024-09-12 12:02 ` Jani Nikula
2024-09-20 17:00 ` Ville Syrjälä
2024-09-10 13:42 ` [PATCH 4/5] drm/i915/bios: Extract vbt_signature[] Ville Syrjala
2024-09-12 12:15 ` Jani Nikula
2024-09-20 16:59 ` Ville Syrjälä
2024-09-23 9:12 ` Jani Nikula
2024-09-23 14:22 ` Ville Syrjälä
2024-09-23 14:24 ` Jani Nikula
2024-09-23 14:29 ` Ville Syrjälä
2024-09-10 13:42 ` [PATCH 5/5] drm/i915/bios: Extract soc/intel_rom.c Ville Syrjala
2024-09-12 12:44 ` Jani Nikula
2024-09-20 17:02 ` Ville Syrjälä
2024-09-23 9:13 ` Jani Nikula [this message]
2024-09-10 15:21 ` ✓ CI.Patch_applied: success for drm/i915/bios: Refactor ROM access Patchwork
2024-09-10 15:21 ` ✗ CI.checkpatch: warning " Patchwork
2024-09-10 15:22 ` ✓ CI.KUnit: success " Patchwork
2024-09-10 15:34 ` ✓ CI.Build: " Patchwork
2024-09-10 15:37 ` ✓ CI.Hooks: " Patchwork
2024-09-10 15:39 ` ✗ CI.checksparse: warning " Patchwork
2024-09-10 16:21 ` ✓ CI.BAT: success " Patchwork
2024-09-10 17:29 ` ✗ Fi.CI.CHECKPATCH: warning " Patchwork
2024-09-10 17:29 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-09-10 17:46 ` ✓ Fi.CI.BAT: success " Patchwork
2024-09-10 18:20 ` ✗ CI.FULL: failure " Patchwork
2024-09-11 9:10 ` ✗ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cyku7mwe.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.