From: Kalle Valo <kvalo@kernel.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: ath12k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH RFC 2/4] wifi: ath12k: cleanup unneeded labels
Date: Thu, 05 Sep 2024 20:09:02 +0300 [thread overview]
Message-ID: <87cylihvtd.fsf@kernel.org> (raw)
In-Reply-To: <1605f1b7d2267444370af84c37a3856f6b158c71.camel@sipsolutions.net> (Johannes Berg's message of "Wed, 21 Aug 2024 19:20:05 +0200")
Johannes Berg <johannes@sipsolutions.net> writes:
> On Wed, 2024-08-21 at 18:37 +0300, Kalle Valo wrote:
>>
>> /* TODO: Recalc radar detection */
>> -
>> -unlock:
>> }
>
> I guess this is the sparse warning, but I think this is an error at
> least in clang without removing the label or putting a ; after the
> label, so you might want to fix it in the same patch.
Good point, clang gives two warnings on patch 1:
drivers/net/wireless/ath/ath12k/mac.c:7560:1: warning: label at end of compound statement is a C23 extension [-Wc23-drivers/net/wireless/ath/ath12k/mac.c:8376:1: warning: unused label 'exit' [-Wunused-label]
I'll fix these in v2.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-09-05 17:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-21 15:37 [PATCH RFC 0/4] wifi: ath12k: switch to using wiphy_lock() Kalle Valo
2024-08-21 15:37 ` [PATCH RFC 1/4] wifi: ath12k: switch to using wiphy_lock() and remove ar->conf_mutex Kalle Valo
2024-08-22 5:46 ` Baochen Qiang
2024-09-05 16:52 ` Kalle Valo
2024-08-21 15:37 ` [PATCH RFC 2/4] wifi: ath12k: cleanup unneeded labels Kalle Valo
2024-08-21 16:55 ` Jeff Johnson
2024-09-05 16:49 ` Kalle Valo
2024-08-21 17:20 ` Johannes Berg
2024-09-05 17:09 ` Kalle Valo [this message]
2024-08-21 15:37 ` [PATCH RFC 3/4] wifi: ath12k: ath12k_mac_op_set_key(): remove exit label Kalle Valo
2024-08-21 15:37 ` [PATCH RFC 4/4] wifi: ath12k: convert struct ath12k_sta::update_wk to use struct wiphy_work Kalle Valo
2024-08-22 6:19 ` Baochen Qiang
2024-09-05 16:58 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cylihvtd.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ath12k@lists.infradead.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.