From: Jani Nikula <jani.nikula@intel.com>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>,
intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH 2/4] drm/xe/display: Remove i915_drv.h include
Date: Wed, 04 Sep 2024 10:27:22 +0300 [thread overview]
Message-ID: <87cyljubdx.fsf@intel.com> (raw)
In-Reply-To: <20240903223803.380711-3-rodrigo.vivi@intel.com>
On Tue, 03 Sep 2024, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> Change HAS_DISPLAY towards intel_display and remove one of the
> last includes of i915_drv.h in Xe.
>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/xe/display/xe_display.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/display/xe_display.c b/drivers/gpu/drm/xe/display/xe_display.c
> index c93b753fc88e..65331bbbc068 100644
> --- a/drivers/gpu/drm/xe/display/xe_display.c
> +++ b/drivers/gpu/drm/xe/display/xe_display.c
> @@ -13,7 +13,6 @@
> #include <uapi/drm/xe_drm.h>
>
> #include "soc/intel_dram.h"
> -#include "i915_drv.h" /* FIXME: HAS_DISPLAY() depends on this */
> #include "intel_acpi.h"
> #include "intel_audio.h"
> #include "intel_bw.h"
> @@ -34,7 +33,7 @@
>
> static bool has_display(struct xe_device *xe)
> {
> - return HAS_DISPLAY(xe);
> + return HAS_DISPLAY(&xe->display);
> }
>
> /**
--
Jani Nikula, Intel
next prev parent reply other threads:[~2024-09-04 7:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 22:37 [PATCH 0/4] drm/xe/display: Clean-up PM sequences Rodrigo Vivi
2024-09-03 22:38 ` [PATCH 1/4] drm/xe/display: Spin-off xe_display runtime/d3cold sequences Rodrigo Vivi
2024-09-03 22:38 ` [PATCH 2/4] drm/xe/display: Remove i915_drv.h include Rodrigo Vivi
2024-09-04 7:27 ` Jani Nikula [this message]
2024-09-03 22:38 ` [PATCH 3/4] drm/xe/display: Kill useless has_display Rodrigo Vivi
2024-09-04 7:33 ` Jani Nikula
2024-09-04 15:22 ` Rodrigo Vivi
2024-09-04 16:08 ` Jani Nikula
2024-09-03 22:38 ` [PATCH 4/4] drm/xe/display: Reduce and streamline d3cold display sequence Rodrigo Vivi
2024-09-04 5:39 ` Anshuman Gupta
2024-09-04 15:24 ` Rodrigo Vivi
2024-09-03 22:43 ` ✓ CI.Patch_applied: success for drm/xe/display: Clean-up PM sequences Patchwork
2024-09-03 22:44 ` ✓ CI.checkpatch: " Patchwork
2024-09-03 22:45 ` ✓ CI.KUnit: " Patchwork
2024-09-03 22:57 ` ✓ CI.Build: " Patchwork
2024-09-03 22:59 ` ✓ CI.Hooks: " Patchwork
2024-09-03 23:00 ` ✓ CI.checksparse: " Patchwork
2024-09-03 23:20 ` ✓ CI.BAT: " Patchwork
2024-09-03 23:24 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-09-04 3:14 ` ✓ CI.FULL: success " Patchwork
2024-09-04 9:02 ` [PATCH 0/4] " Jani Nikula
2024-09-04 15:16 ` Rodrigo Vivi
2024-09-04 16:02 ` ✓ Fi.CI.BAT: success for drm/xe/display: Clean-up PM sequences (rev2) Patchwork
2024-09-05 13:50 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cyljubdx.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.