From: Peter Korsgaard <peter@korsgaard.com>
To: Fiona Klute via buildroot <buildroot@buildroot.org>
Cc: Bernd Kuhls <bernd@kuhls.net>, Fiona Klute <fiona.klute@gmx.de>,
"Yann E . MORIN" <yann.morin.1998@free.fr>
Subject: Re: [Buildroot] [PATCH v2 1/1] package/dnsmasq: Fix init script restart command
Date: Sat, 08 Jun 2024 18:59:00 +0200 [thread overview]
Message-ID: <87cyorxtez.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20240531185328.2586537-1-fiona.klute@gmx.de> (Fiona Klute via buildroot's message of "Fri, 31 May 2024 20:53:28 +0200")
>>>>> "Fiona" == Fiona Klute via buildroot <buildroot@buildroot.org> writes:
> I have had constant issues restarting dnsmasq. Stop works, start fails
> because the new instance can't bind the socket. Another restart
> immediately after works just fine:
> # /etc/init.d/S80dnsmasq restart
> Stopping dnsmasq: OK
> Starting dnsmasq:
> dnsmasq: failed to create listening socket for 192.168.128.1: Address in use
> FAIL
> # /etc/init.d/S80dnsmasq restart
> Stopping dnsmasq: FAIL
> Starting dnsmasq: OK
> Solve this by waiting for process to actually stop before returning
> from the stop command. Clean up the PID file after to avoid potential
> issues with the PID being reused after stop. The wait could also be
> placed inside the restart block, but putting it into the stop block
> has the advantage that it also avoids similar issues for any other
> callers.
> Signed-off-by: Fiona Klute <fiona.klute+wiwa@gmx.de>
> ---
> Changes v1 -> v2:
> Read $PIDFILE only once per iteration, to avoid errors if it
> disappears between checks. Suggested by Yann E. MORIN.
Committed to 2024.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-06-08 16:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-31 18:53 [Buildroot] [PATCH v2 1/1] package/dnsmasq: Fix init script restart command Fiona Klute via buildroot
2024-06-01 20:19 ` Yann E. MORIN
2024-06-08 16:59 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cyorxtez.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=bernd@kuhls.net \
--cc=buildroot@buildroot.org \
--cc=fiona.klute@gmx.de \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.