From: Peter Korsgaard <peter@korsgaard.com>
To: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
Cc: linux-usb@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] usb: gadget: composite: fix OS descriptors w_value logic
Date: Tue, 23 Apr 2024 08:50:05 +0200 [thread overview]
Message-ID: <87cyqglgiq.fsf@48ers.dk> (raw)
In-Reply-To: <ee546f65-2f72-40ac-9b10-aea469e9ebab@collabora.com> (Andrzej Pietrasiewicz's message of "Mon, 22 Apr 2024 21:09:03 +0200")
>>>>> "Andrzej" == Andrzej Pietrasiewicz <andrzej.p@collabora.com> writes:
> Hi Peter,
> W dniu 4.04.2024 o 12:06, Peter Korsgaard pisze:
>> The OS descriptors logic had the high/low byte of w_value inverted, causing
>> the extended properties to not be accessible for interface != 0.
> Out of curiosity - did you run into problems running some USB gadget,
> and if yes, what was it? Or is this patch a result of a code and documentation
> review without actually running a gadget?
I had issues with getting Windows to accept the OS descriptors when the
function I wanted to use with WinUSB was not the first (= interface 0)
function in a composite device together with HID and mass storage.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2024-04-23 6:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-04 10:06 [PATCH] usb: gadget: composite: fix OS descriptors w_value logic Peter Korsgaard
2024-04-22 19:09 ` Andrzej Pietrasiewicz
2024-04-23 6:50 ` Peter Korsgaard [this message]
[not found] <AS8PR05MB84857AB3DC49395AEC7C235990932@AS8PR05MB8485.eurprd05.prod.outlook.com>
2024-09-03 11:14 ` Vrastil, Michal
2024-09-03 11:23 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cyqglgiq.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=andrzej.p@collabora.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.