From: Petr Machata <petrm@nvidia.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>,
<edumazet@google.com>, <pabeni@redhat.com>, <shuah@kernel.org>,
<petrm@nvidia.com>, <linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH net-next 4/6] selftests: net: print full exception on failure
Date: Fri, 12 Apr 2024 10:02:57 +0200 [thread overview]
Message-ID: <87cyqvf1ic.fsf@nvidia.com> (raw)
In-Reply-To: <20240411012815.174400-5-kuba@kernel.org>
Jakub Kicinski <kuba@kernel.org> writes:
> Instead of a summary line print the full exception.
> This makes debugging Python tests much easier.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Petr Machata <petrm@nvidia.com>
> @@ -85,7 +86,8 @@ KSFT_RESULT = None
> totals['xfail'] += 1
> continue
> except Exception as e:
> - for line in str(e).split('\n'):
> + tb = traceback.format_exc()
> + for line in tb.strip().split('\n'):
(The strip is necessary to get rid of trailing newlines.)
> ksft_pr("Exception|", line)
> ktap_result(False, cnt, case)
> totals['fail'] += 1
next prev parent reply other threads:[~2024-04-12 8:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 1:28 [PATCH net-next 0/6] selftests: net: exercise page pool reporting via netlink Jakub Kicinski
2024-04-11 1:28 ` [PATCH net-next 1/6] net: netdevsim: add some fake page pool use Jakub Kicinski
2024-04-11 1:28 ` [PATCH net-next 2/6] tools: ynl: don't return None for dumps Jakub Kicinski
2024-04-11 10:12 ` Donald Hunter
2024-04-11 1:28 ` [PATCH net-next 3/6] selftests: net: print report check location in python tests Jakub Kicinski
2024-04-12 7:45 ` Petr Machata
2024-04-11 1:28 ` [PATCH net-next 4/6] selftests: net: print full exception on failure Jakub Kicinski
2024-04-12 8:02 ` Petr Machata [this message]
2024-04-11 1:28 ` [PATCH net-next 5/6] selftests: net: support use of NetdevSimDev under "with" in python Jakub Kicinski
2024-04-12 8:07 ` Petr Machata
2024-04-11 1:28 ` [PATCH net-next 6/6] selftests: net: exercise page pool reporting via netlink Jakub Kicinski
2024-04-12 8:20 ` Petr Machata
2024-04-12 13:48 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cyqvf1ic.fsf@nvidia.com \
--to=petrm@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.