From: Kalle Valo <kvalo@kernel.org>
To: nbd@nbd.name
Cc: lorenzo.bianconi@redhat.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] wifi: mt76: mt7915: workaround dubious x | !y warning
Date: Mon, 25 Mar 2024 19:22:38 +0200 [thread overview]
Message-ID: <87cyri1b1d.fsf@kernel.org> (raw)
In-Reply-To: <20240325155838.1558680-1-kvalo@kernel.org> (Kalle Valo's message of "Mon, 25 Mar 2024 17:58:38 +0200")
Kalle Valo <kvalo@kernel.org> writes:
> Sparse warns:
>
> drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c:526:9: warning: dubious: x | !y
>
> Workaround it by using the '?' operator. Compile tested only.
>
> Signed-off-by: Kalle Valo <kvalo@kernel.org>
> ---
> v2:
>
> * use parenthesis
Felix&Lorenzo, if this looks ok to you I would like to take this
directly to wireless-next. I'm aiming that the next wireless-next pull
request is sparse warning free :)
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-03-25 17:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 15:58 [PATCH v2] wifi: mt76: mt7915: workaround dubious x | !y warning Kalle Valo
2024-03-25 17:22 ` Kalle Valo [this message]
2024-03-27 14:38 ` Lorenzo Bianconi
2024-03-28 13:08 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cyri1b1d.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.