From: Marc Zyngier <maz@kernel.org>
To: Oliver Upton <oliver.upton@linux.dev>
Cc: kvmarm@lists.linux.dev, James Morse <james.morse@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Zenghui Yu <yuzenghui@huawei.com>, Will Deacon <will@kernel.org>
Subject: Re: [PATCH 3/3] KVM: arm64: Do not disable preemption in kvm_vcpu_pmu_restore_guest()
Date: Wed, 06 Mar 2024 09:52:56 +0000 [thread overview]
Message-ID: <87cys7r8jr.wl-maz@kernel.org> (raw)
In-Reply-To: <20240305184840.636212-4-oliver.upton@linux.dev>
On Tue, 05 Mar 2024 18:48:40 +0000,
Oliver Upton <oliver.upton@linux.dev> wrote:
>
> The caller has already disabled preemption, no need to nest further.
A quick survey indicates that it doesn't seem to be the case, I'm
afraid. access_pmu_evtyper() and access_pmcnten() both seem to be
preemptible.
Which probably means that these spots are doing the wrong thing and
that we should instead turn it into a KVM_REQ_RESYNC_PMU_EL0 request.
Then the preemption can be actually dropped, and even replaced by an
assertion.
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2024-03-06 9:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 18:48 [PATCH 0/3] KVM: arm64: PMU fixes for nVHE, protected mode Oliver Upton
2024-03-05 18:48 ` [PATCH 1/3] KVM: arm64: pkvm: Actually enable/disable PMU events when running vCPU Oliver Upton
2024-03-06 10:06 ` Marc Zyngier
2024-03-06 10:18 ` Oliver Upton
2024-03-06 13:23 ` Fuad Tabba
2024-03-05 18:48 ` [PATCH 2/3] KVM: arm64: Fix host-programmed guest events in nVHE Oliver Upton
2024-03-06 9:59 ` Marc Zyngier
2024-03-05 18:48 ` [PATCH 3/3] KVM: arm64: Do not disable preemption in kvm_vcpu_pmu_restore_guest() Oliver Upton
2024-03-06 9:52 ` Marc Zyngier [this message]
2024-03-06 9:54 ` Oliver Upton
2024-03-26 13:44 ` (subset) [PATCH 0/3] KVM: arm64: PMU fixes for nVHE, protected mode Oliver Upton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cys7r8jr.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=james.morse@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=oliver.upton@linux.dev \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.