From: Peter Korsgaard <peter@korsgaard.com>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Pierre-Jean Texier <texier.pj2@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/libarchive: fix uclibc build with libiconv (again)
Date: Sat, 13 Jan 2024 11:33:26 +0100 [thread overview]
Message-ID: <87cyu5wmix.fsf@48ers.dk> (raw)
In-Reply-To: <20240106091149.57205-1-fontaine.fabrice@gmail.com> (Fabrice Fontaine's message of "Sat, 6 Jan 2024 10:11:49 +0100")
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Commit 7991d2c48a859f9c0333ade8192868c21b1a8a31 wrongly removed patch
> added by commit 1e8cce6f2b1936dbda9d63ddf4f41acf59a64113, advocating
> that upstream applied a different "solution", this "solution" was
> already tested on buildroot with commit
> 9525bc7e64e8f44c31ab9dfd3f516ecb35982429 and is utterly broken as stated
> in:
> https://github.com/libarchive/libarchive/pull/1825#issuecomment-1403537856
> https://github.com/libarchive/libarchive/pull/1825#issuecomment-1437451472
> https://github.com/libarchive/libarchive/issues/1819#issuecomment-1439962521
> https://github.com/libarchive/libarchive/issues/1841#issuecomment-1426628554
> https://github.com/libarchive/libarchive/pull/1813#issuecomment-1396373372
> As a result, build failures are again raised by uclibc-ng with libiconv
> on fwup/gvfs/...:
> configure: error: Requires libarchive. Libarchive must be built with zlib support.
> [...]
> Run-time dependency libarchive found: NO (tried cmake)
> ../output-1/build/gvfs-1.48.1/meson.build:405:2: ERROR: Dependency
> lookup for libarchive with method 'pkgconfig' failed: Could not
> generate cargs for libarchive:
> Package iconv was not found in the pkg-config search path.
> Perhaps you should add the directory containing `iconv.pc'
> to the PKG_CONFIG_PATH environment variable
> Package 'iconv', required by 'libarchive', not found
> So revert the upstream "solution", put back previous patch and let's
> hope that upstream improve their skills in pkg-config and static
> building but they probably don't really care about it...
> Fixes:
> - http://autobuild.buildroot.org/results/0f5058634ecc2ffae3993f6f4513d8ce75e6c02f
> - http://autobuild.buildroot.org/results/20fc291ef7e37ee8bd553976cbe841e53345680b
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2023.11.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-01-13 10:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-06 9:11 [Buildroot] [PATCH 1/1] package/libarchive: fix uclibc build with libiconv (again) Fabrice Fontaine
2024-01-13 10:33 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cyu5wmix.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=texier.pj2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.