From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DAB21C197A0 for ; Mon, 20 Nov 2023 10:07:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9140610E38A; Mon, 20 Nov 2023 10:07:17 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id 25EF810E38A; Mon, 20 Nov 2023 10:07:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700474835; x=1732010835; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=jJIlMZpuwkKpDkHcK/QWHDOVBSdGTpjF0AQ7LQOFB3o=; b=S0Z3SZjy72VCeFY1HIhJa2cr4nN3rzpQmmn6UrA7epLHh2cZZ8ROs1jc u0EjBpLxEqPQswh15mVdClJwkuHCLzKg1AJIQ35ejOvfC9S+sZ7N3Ud5P w63nggsleBtoMQKiAfghsEIxtg2AZcR0JLxqcvRFOX+fLoeuZntK94XR9 ackHzgZWSIepmso8cbK2tCIwWKl7qulUCThG/DIHPb6eTy2vjaA2GgVsD rWicei6My6w+F8egTVUyl0H1EvCnk8igO96BrCjFXHh+9tR+neAPE0WDV xO5HXmoBwhGPwJqZJ/bFd5M3xwOm22J42ocgMDRTwJIBv9E2AAv2eBd0o w==; X-IronPort-AV: E=McAfee;i="6600,9927,10899"; a="10265500" X-IronPort-AV: E=Sophos;i="6.04,213,1695711600"; d="scan'208";a="10265500" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Nov 2023 02:04:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10899"; a="836699534" X-IronPort-AV: E=Sophos;i="6.04,213,1695711600"; d="scan'208";a="836699534" Received: from avmoskal-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.40.194]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Nov 2023 02:04:01 -0800 From: Jani Nikula To: Tvrtko Ursulin , Intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org In-Reply-To: <20231113085457.199053-2-tvrtko.ursulin@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20231113085457.199053-1-tvrtko.ursulin@linux.intel.com> <20231113085457.199053-2-tvrtko.ursulin@linux.intel.com> Date: Mon, 20 Nov 2023 12:03:58 +0200 Message-ID: <87cyw4pwq9.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915: Add __rcu annotation to cursor when iterating client objects X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tvrtko Ursulin Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, 13 Nov 2023, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > __rcu annotation is needed to avoid the sparse warnings such as: > > .../i915_drm_client.c:92:9: sparse: sparse: incompatible types in comparison expression (different address spaces): > .../i915_drm_client.c:92:9: sparse: struct list_head [noderef] __rcu * > .../i915_drm_client.c:92:9: sparse: struct list_head * > > Signed-off-by: Tvrtko Ursulin > Fixes: 968853033d8a ("drm/i915: Implement fdinfo memory stats printing") > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202311110610.h0m6ydI5-lkp@intel.com/ > Cc: Andi Shyti > Cc: Aravind Iddamsetty Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/i915_drm_client.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_drm_client.c b/drivers/gpu/drm/i915/i915_drm_client.c > index be9acfd9410e..fa6852713bee 100644 > --- a/drivers/gpu/drm/i915/i915_drm_client.c > +++ b/drivers/gpu/drm/i915/i915_drm_client.c > @@ -78,7 +78,7 @@ static void show_meminfo(struct drm_printer *p, struct drm_file *file) > struct drm_i915_private *i915 = fpriv->i915; > struct drm_i915_gem_object *obj; > struct intel_memory_region *mr; > - struct list_head *pos; > + struct list_head __rcu *pos; > unsigned int id; > > /* Public objects. */ -- Jani Nikula, Intel