From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8EA0CC4332F for ; Fri, 3 Nov 2023 14:01:44 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id D456B2A88A for ; Fri, 3 Nov 2023 14:01:43 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id B90B7986C41 for ; Fri, 3 Nov 2023 14:01:43 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id A5077986C3A; Fri, 3 Nov 2023 14:01:43 +0000 (UTC) Mailing-List: contact virtio-comment-help@lists.oasis-open.org; run by ezmlm List-ID: Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 95BA1986C3B for ; Fri, 3 Nov 2023 14:01:43 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com X-MC-Unique: yUF-GppFOBiqGZm_kXLCiw-1 From: Cornelia Huck To: Heng Qi , virtio-comment@lists.oasis-open.org Cc: "Michael S . Tsirkin" , Jason Wang , Yuri Benditovich , Satananda Burla , Parav Pandit , Xuan Zhuo In-Reply-To: Organization: "Red Hat GmbH, Sitz: Werner-von-Siemens-Ring 12, D-85630 Grasbrunn, Handelsregister: Amtsgericht =?utf-8?Q?M=C3=BCnchen=2C?= HRB 153243, =?utf-8?Q?Gesch=C3=A4ftsf=C3=BChrer=3A?= Ryan Barnhart, Charles Cachera, Michael O'Neill, Amy Ross" References: User-Agent: Notmuch/0.37 (https://notmuchmail.org) Date: Fri, 03 Nov 2023 15:01:34 +0100 Message-ID: <87cywrq6kh.fsf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Subject: Re: [virtio-comment] [PATCH v5] virtio-net: support the RSS context On Fri, Nov 03 2023, Heng Qi wrote: > Commit 84a1d9c48200 ("net: ethtool: extend RXNFC API to support RSS spreading of > filter matches") adds support for RSS context as a destination for receive flow filters > (see WIP work: https://lists.oasis-open.org/archives/virtio-comment/202308/msg00194.html). > > An RSS context consists of configurable parameters specified by receive-side scaling. > > Some use cases: > 1. When users want some data flows to be steered to specific multiple rxqs, they can set > receive flow filter rules for these data flows to an RSS context with desired rxqs. > 2. Traffic isolation. Used when users want the traffic of certain applications to occupy > several queues without being distubed. > > How to set/configure an RSS context: > Assuming no RSS context has been created before. > 1. ethtool -X eth0 context new start 5 equal 8 > > This command creates an RSS context with an id=1 for eth0, and fills in the indirection > table with rxq indexes 5-8 circularly. The hash key and hash types reuse the default > RSS configuration. > > Then, we can use 'ethtool -x eth0 context 1' to query the above configuration. > > 2. ethtool -X eth0 context new start 6 equal 7 \ > hkey 8f:bf:dd:11:23:58:d2:8a:00:31:d0:32:a3:b5:1f:\ > 1f:e4:d1:fe:47:7f:64:42:fd:d0:61:16:b8:b0:f9:71:e8:2d:36:7f:18:dd:4d:c8:f3 > > This command creates an RSS context with an id=2 for eth0, and fills in the indirection > table with rxq indexes 6-7 circularly. The hash key is 8f:bf:dd:11:23:58:d2:8a:00:31:d0\ > :32:a3:b5:1f:1f:e4:d1:fe:47:7f:64:42:fd:d0:61:16:b8:b0:f9:71:e8:2d:36:7f:18:dd:4d:c8:f3. > Hash types reuse the default RSS configuration. > > 3. ethtool -N eth0 rx-flow-hash tcp4 sdfn context 1 > > This command specifies the hash types for the RSS context whose id=1 on eth0. > Now this RSS context only has the hash key to reuse the default RSS configuration. > > 4. ethtool -N eth0 flow-type udp4 src-ip 1.1.1.1 context 1 > > This command configures a receive flow filter rule for eth0, and the data flow matching > this rule will continue to select the final rxq according to the RSS context configuration > with id=1. > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/178 > Signed-off-by: Heng Qi > Signed-off-by: Parav Pandit > Acked-by: Satananda Burla > --- > v4->v5: > 1. Use 'u8 reserved[6]' instead of u16 padding to align the structure. > > v3->v4: > 1. Rebase to Xuan's device stats patch. > > v2->v3: > 1. Process Satananda's comments and add his ack tag. > 2. Add link to fix issue and optimize commit log. > > v1->v2: > 1. u8 to le16 for field rss_ctx_id. > 2. Add normativation when device resetting. @Yuri Benditovich > 3. Use ctrlq cmd to query rss context capability instead of reading config space. @Parav Pandit > > device-types/net/description.tex | 85 +++++++++++++++++++++++++ > device-types/net/device-conformance.tex | 1 + > device-types/net/driver-conformance.tex | 1 + > 3 files changed, 87 insertions(+) So, what's the status here? The github issue still points to the previous version (where you had asked for opening a vote.) There's only the padding change in this version... can I get some ack from net folks on whether this is ready for a vote? This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: virtio-comment-subscribe@lists.oasis-open.org Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org List help: virtio-comment-help@lists.oasis-open.org List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/