All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: Fabiano Rosas <farosas@suse.de>
Cc: qemu-devel@nongnu.org, "Fam Zheng" <fam@euphon.net>,
	qemu-block@nongnu.org,
	"Daniel P . Berrangé" <berrange@redhat.com>,
	"Hailiang Zhang" <zhanghailiang@xfusion.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Peter Xu" <peterx@redhat.com>,
	"Li Zhijian" <lizhijian@fujitsu.com>,
	"Leonardo Bras" <leobras@redhat.com>
Subject: Re: [PATCH 01/12] qemu-file: We only call qemu_file_transferred_* on the sending side
Date: Wed, 25 Oct 2023 11:00:54 +0200	[thread overview]
Message-ID: <87cyx3f54p.fsf@secure.mitica> (raw)
In-Reply-To: <87a5s8szlz.fsf@suse.de> (Fabiano Rosas's message of "Tue, 24 Oct 2023 14:24:08 -0300")

Fabiano Rosas <farosas@suse.de> wrote:
> Juan Quintela <quintela@redhat.com> writes:
>
>> Remove the increase in qemu_file_fill_buffer() and add asserts to
>> qemu_file_transferred* functions.
>
> Patch looks ok, but I would rewrite the whole commit message like this:
>
> Don't increment qemu_file_transferred at qemu_file_fill_buffer
>
> We only call qemu_file_transferred_* on the sending side. Remove the
> increment at qemu_file_fill_buffer() and add asserts to
> qemu_file_transferred* functions.

Changed the commint text.

Thanks,



  reply	other threads:[~2023-10-25  9:02 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-24 15:10 [PATCH 00/12] migration: Yet another round of atomic counters Juan Quintela
2023-10-24 15:10 ` [PATCH 01/12] qemu-file: We only call qemu_file_transferred_* on the sending side Juan Quintela
2023-10-24 17:24   ` Fabiano Rosas
2023-10-25  9:00     ` Juan Quintela [this message]
2023-10-24 15:10 ` [PATCH 02/12] qemu_file: Use a stat64 for qemu_file_transferred Juan Quintela
2023-10-24 17:34   ` Fabiano Rosas
2023-10-24 18:14   ` Eric Blake
2023-10-25  9:01     ` Juan Quintela
2023-10-24 15:10 ` [PATCH 03/12] qemu_file: total_transferred is not used anymore Juan Quintela
2023-10-24 17:35   ` Fabiano Rosas
2023-10-24 15:10 ` [PATCH 04/12] migration: Use the number of transferred bytes directly Juan Quintela
2023-10-24 17:40   ` Fabiano Rosas
2023-10-24 15:10 ` [PATCH 05/12] qemu_file: Remove unused qemu_file_transferred() Juan Quintela
2023-10-24 17:40   ` Fabiano Rosas
2023-10-24 15:10 ` [PATCH 06/12] qemu-file: Remove _noflush from qemu_file_transferred_noflush() Juan Quintela
2023-10-24 17:42   ` Fabiano Rosas
2023-10-24 15:10 ` [PATCH 07/12] migration: migration_transferred_bytes() don't need the QEMUFile Juan Quintela
2023-10-24 15:10 ` [PATCH 08/12] migration: migration_rate_limit_reset() " Juan Quintela
2023-10-24 15:10 ` [PATCH 09/12] qemu-file: Simplify qemu_file_get_error() Juan Quintela
2023-10-24 15:10 ` [PATCH 10/12] migration: Use migration_transferred_bytes() Juan Quintela
2023-10-24 17:46   ` Fabiano Rosas
2023-10-24 15:10 ` [PATCH 11/12] migration: Remove transferred atomic counter Juan Quintela
2023-10-24 17:48   ` Fabiano Rosas
2023-10-24 15:10 ` [PATCH 12/12] qemu-file: Make qemu_fflush() return errors Juan Quintela
2023-10-24 17:56   ` Fabiano Rosas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cyx3f54p.fsf@secure.mitica \
    --to=quintela@redhat.com \
    --cc=berrange@redhat.com \
    --cc=fam@euphon.net \
    --cc=farosas@suse.de \
    --cc=leobras@redhat.com \
    --cc=lizhijian@fujitsu.com \
    --cc=peterx@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=zhanghailiang@xfusion.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.