Re: [PATCH v3 3/4] migration: Deprecate block migration

[Juan Quintela <quintela@redhat.com>]

Markus Armbruster <armbru@redhat.com> wrote:
> Juan Quintela <quintela@redhat.com> writes:
>
>> It is obsolete.  It is better to use driver-mirror with NBD instead.
>
> drive-mirror
>
> Several more below.

Done.

>> +# Features:
>> +#
>> +# @deprecated: @disk migration is deprecated.  Use driver-mirror
>> +#     with NBD instead.
>> +#
>
> Suggest:
>
>    # @deprecated: Member @disk is deprecated because block migration is.

Done.

>>  # Since: 0.14
>>  ##
>>  { 'struct': 'MigrationInfo',
>>    'data': {'*status': 'MigrationStatus', '*ram': 'MigrationStats',
>> -           '*disk': 'MigrationStats',
>> +           '*disk': { 'type': 'MigrationStats', 'features': ['deprecated'] },
>>             '*vfio': 'VfioStats',
>>             '*xbzrle-cache': 'XBZRLECacheStats',
>>             '*total-time': 'int',
>> @@ -526,6 +531,9 @@
>>  #
>>  # Features:
>>  #
>> +# @deprecated: @block migration is deprecated.  Use driver-mirror
>> +#     with NBD instead.
>> +#
>
> Suggest:
>
>    # @deprecated: Member @block is deprecated.  Use drrive-mirror with
>    # NBD instead.

Done.

>>  # @unstable: Members @x-colo and @x-ignore-shared are experimental.
>>  #
>>  # Since: 1.2
>> @@ -535,7 +543,8 @@
>>             'compress', 'events', 'postcopy-ram',
>>             { 'name': 'x-colo', 'features': [ 'unstable' ] },
>>             'release-ram',
>> -           'block', 'return-path', 'pause-before-switchover', 'multifd',
>> +           { 'name': 'block', 'features': [ 'deprecated' ] },
>> +           'return-path', 'pause-before-switchover', 'multifd',
>>             'dirty-bitmaps', 'postcopy-blocktime', 'late-block-activate',
>>             { 'name': 'x-ignore-shared', 'features': [ 'unstable' ] },
>>             'validate-uuid', 'background-snapshot',
>> @@ -826,6 +835,9 @@
>>  #
>>  # Features:
>>  #
>> +# @deprecated: Member @block-incremental is obsolete. Use
>> +#     driver-mirror with NBD instead.
>> +#
>
> Wait!  This is what PATCH 1 tells users to use instead of deprecated
> @inc.  You need to update that deprecation note to point to a
> non-deprecated replacement.

I don't have.
I want to deprecate the whole thing.
But the options are more urgent to deprecate/remove.  They are
implemented in a very hacky way.  Even for migration/qemu standards.

Later, Juan.