From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF897C83F14 for ; Tue, 29 Aug 2023 07:39:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233703AbjH2Hir (ORCPT ); Tue, 29 Aug 2023 03:38:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233725AbjH2HiU (ORCPT ); Tue, 29 Aug 2023 03:38:20 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2D2C132; Tue, 29 Aug 2023 00:38:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693294697; x=1724830697; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=7xbIuAVv6BRYk1f4b+LCb+VtGRsblUZaWwZkr0s2oa0=; b=liawHG+5vekYu4rkUywU+qoo4MNKKB01hy6wZ7oY7gUJGc7yX9u9h2YX mHdTCI+ft7gJSFj0qHK2Bvx4TKBAh0m42hR+vzOKcH9pdHbhtEAgSHMlj 5b2JWM/A6Yybk2VHZWQRwQJfP5QWzEQp9jOtzYDJ6kO+zxzHD0wA2EpYU CI53mz5WScBeqCkb7gNVJc75n/oz/SVpdDoo0TaTe1yHfOz5LPjTt2xIM KA5xuBU6KBnpq7ZlQY3MnR5HXVvM8T0O3qJIAuzdeps1/SxJwwRbMA4GT laI0ogFEQC/o+IH1FDclLyAtJQtFFSfEmRx21oXsnGacyjel71QAQeO0Z Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10816"; a="375263854" X-IronPort-AV: E=Sophos;i="6.02,210,1688454000"; d="scan'208";a="375263854" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Aug 2023 00:38:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10816"; a="853178928" X-IronPort-AV: E=Sophos;i="6.02,210,1688454000"; d="scan'208";a="853178928" Received: from mnefedov-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.32.206]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Aug 2023 00:38:11 -0700 From: Jani Nikula To: Bjorn Andersson , Krzysztof Kozlowski Cc: Vlastimil Babka , Geert Uytterhoeven , Guru Das Srinagesh , Masahiro Yamada , Nick Desaulniers , Andrew Morton , Nicolas Schier , Konstantin Ryabitsev , Kees Cook , Bjorn Andersson , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, Will Deacon , Greg Kroah-Hartman , quic_pkondeti@quicinc.com, linux-kernel@vger.kernel.org, kernel@quicinc.com, workflows@vger.kernel.org, tools@linux.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v3 1/1] scripts: Add add-maintainer.py In-Reply-To: <20230828165038.GB818859@hu-bjorande-lv.qualcomm.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <141b9fcab2208ace3001df4fc10e3dfd42b9f5d9.1693037031.git.quic_gurus@quicinc.com> <87jztf37ny.fsf@intel.com> <20230828133554.GA818859@hu-bjorande-lv.qualcomm.com> <9aec0740-2482-d3ad-caf2-5e6278a050b3@suse.cz> <89c73602-43f1-30a4-ad58-637aadacd653@linaro.org> <20230828165038.GB818859@hu-bjorande-lv.qualcomm.com> Date: Tue, 29 Aug 2023 10:38:08 +0300 Message-ID: <87cyz62t9b.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon, 28 Aug 2023, Bjorn Andersson wrote: > On Mon, Aug 28, 2023 at 05:23:58PM +0200, Krzysztof Kozlowski wrote: >> On 28/08/2023 17:14, Vlastimil Babka wrote: >> > On 8/28/23 15:48, Geert Uytterhoeven wrote: >> >> Hi Bjorn, >> >> >> >> On Mon, Aug 28, 2023 at 3:37=E2=80=AFPM Bjorn Andersson >> >> wrote: >> >>> On Mon, Aug 28, 2023 at 11:14:41AM +0300, Jani Nikula wrote: >> >>>> On Sat, 26 Aug 2023, Guru Das Srinagesh wr= ote: >> >>>>> This script runs get_maintainer.py on a given patch file (or multi= ple >> >>>>> patch files) and adds its output to the patch file in place with t= he >> >>>>> appropriate email headers "To: " or "Cc: " as the case may be. The= se new >> >>>>> headers are added after the "From: " line in the patch. >> >>>> >> >>>> FWIW, I personally prefer tooling to operate on git branches and co= mmits >> >>>> than patches. For me, the patches are just an intermediate step in >> >>>> getting the commits from my git branch to the mailing list. That's = not >> >>>> where I add the Cc's, but rather in the commits in my local branch, >> >>>> where they're preserved. YMMV. >> >>>> >> >>> >> >>> May I ask how you add/carry the recipients in a commit? >> >> >> >> I guess below a "---" line in the commit description? >> >=20 >> > Does that do anything special in commit log? I'd expect (and I do it t= hat >> > way) it's rather just adding a >>=20 >> It does. It goes away. > > Afaict, it's verbatim copied into the .patch, which would mean that it > goes away when the patch is applied on the other side. > > But it's still going to be in the email (followed by another ---), so > unless there's another step later in the process that cleans this up I > it looks ugly, and not very useful - unless I'm missing something. > >> >=20 >> > Cc: Name >> >=20 >> > in the tag area where s-o-b, reviewed-by etc are added. >>=20 >> Why storing autogenerated scripts/get_maintainer.pl CC-entries in commit >> msg? The non-maintainer-output but the automated output? There is no >> single need to store automated output of get_maintainers.pl in the git >> log. It can be easily re-created at any given time, thus its presence in >> the git history is redundant and obfuscates the log. >>=20 > > Fully agree to this. In particular if the patch is going to be sent as > part of a series the recipients list won't be accurate for any patch. > > The case I was looking for was the case where I want to make sure to > include a specific person, beyond the get_maintainers output. So pretty > much the usual Cc: tag in the commit message, but I don't necessarily > want to write this fact into the git history. The point is, I *never* use get_maintainer.pl output as-is. BR, Jani. --=20 Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1C774C83F12 for ; Tue, 29 Aug 2023 07:38:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ekbxons4wHz3IfNwidsTCo7SCIFWCMSBmmD3gH9r2Cc=; b=PrWME4C1AO9ovq kosaTGK3XFQEG5U4+fHXsJbRitXH0ALzRtre+2lXBxT7b5XmJ7T4igP3w/KqLFoYSmireIcr/uglt csheqAqB8d9AgqfST7cCkfqCnKsBhbRcmpcXKG7JswbBzxzlYhYfOZEE9rSlDCseTbh1suPhh2PFk OMVXT6vz6DDFTwVdJtoVgc73ncDuj+5B52D7nE3psVtbnW83UozrSvO3xXX8rD0ioH+trhutO8Sj9 IkyYHJU5k7KajmLtXENgF1fg9lsiHx7uODVI8h+bXw8JtnCkgkR+FNoLDGuWHbrIBnxX9T5bYGbRJ /mfYwj+hed5RbZ1lxVWA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qatIs-00AwtU-0Q; Tue, 29 Aug 2023 07:38:22 +0000 Received: from mgamail.intel.com ([192.55.52.115]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qatIo-00Awsi-29 for linux-arm-kernel@lists.infradead.org; Tue, 29 Aug 2023 07:38:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693294698; x=1724830698; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=7xbIuAVv6BRYk1f4b+LCb+VtGRsblUZaWwZkr0s2oa0=; b=CSkx6qiqZk4IL3Yz8zktdjj8jbn0IXQfGY2b9gIzwn8vYAbF7yAABpOP BcCPFl5vjZRkDCOS4ydS1Jf0Ezntymj3zz01SljZYUc0rSCKKx47zanH0 YCQ2w8bzWzeJM1PqUKMgo2Jw0jBudQZGmQoWOSeAwy5O4q1p4cJWcI55P GTDBQ+YZv+t7lO49RwFPBGTo1Y0sVxmRPVjPysnIT7Bg6bO1ZYqe7p4ac A1RUzU7uDcGjNgzxcjEr55OAHRqz9XXw+k4sRnjOX2z4KHakoyKRCy2Sn Wg3kzGbH1pc2GaIijrrS7STxDQT5uXkCudWop2TN7AmikwjNCJcyO3Ajo A==; X-IronPort-AV: E=McAfee;i="6600,9927,10816"; a="375263855" X-IronPort-AV: E=Sophos;i="6.02,210,1688454000"; d="scan'208";a="375263855" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Aug 2023 00:38:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10816"; a="853178928" X-IronPort-AV: E=Sophos;i="6.02,210,1688454000"; d="scan'208";a="853178928" Received: from mnefedov-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.32.206]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Aug 2023 00:38:11 -0700 From: Jani Nikula To: Bjorn Andersson , Krzysztof Kozlowski Cc: Vlastimil Babka , Geert Uytterhoeven , Guru Das Srinagesh , Masahiro Yamada , Nick Desaulniers , Andrew Morton , Nicolas Schier , Konstantin Ryabitsev , Kees Cook , Bjorn Andersson , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, Will Deacon , Greg Kroah-Hartman , quic_pkondeti@quicinc.com, linux-kernel@vger.kernel.org, kernel@quicinc.com, workflows@vger.kernel.org, tools@linux.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v3 1/1] scripts: Add add-maintainer.py In-Reply-To: <20230828165038.GB818859@hu-bjorande-lv.qualcomm.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <141b9fcab2208ace3001df4fc10e3dfd42b9f5d9.1693037031.git.quic_gurus@quicinc.com> <87jztf37ny.fsf@intel.com> <20230828133554.GA818859@hu-bjorande-lv.qualcomm.com> <9aec0740-2482-d3ad-caf2-5e6278a050b3@suse.cz> <89c73602-43f1-30a4-ad58-637aadacd653@linaro.org> <20230828165038.GB818859@hu-bjorande-lv.qualcomm.com> Date: Tue, 29 Aug 2023 10:38:08 +0300 Message-ID: <87cyz62t9b.fsf@intel.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230829_003818_715776_6BEC26DE X-CRM114-Status: GOOD ( 29.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAyOCBBdWcgMjAyMywgQmpvcm4gQW5kZXJzc29uIDxxdWljX2Jqb3JhbmRlQHF1aWNp bmMuY29tPiB3cm90ZToKPiBPbiBNb24sIEF1ZyAyOCwgMjAyMyBhdCAwNToyMzo1OFBNICswMjAw LCBLcnp5c3p0b2YgS296bG93c2tpIHdyb3RlOgo+PiBPbiAyOC8wOC8yMDIzIDE3OjE0LCBWbGFz dGltaWwgQmFia2Egd3JvdGU6Cj4+ID4gT24gOC8yOC8yMyAxNTo0OCwgR2VlcnQgVXl0dGVyaG9l dmVuIHdyb3RlOgo+PiA+PiBIaSBCam9ybiwKPj4gPj4KPj4gPj4gT24gTW9uLCBBdWcgMjgsIDIw MjMgYXQgMzozN+KAr1BNIEJqb3JuIEFuZGVyc3Nvbgo+PiA+PiA8cXVpY19iam9yYW5kZUBxdWlj aW5jLmNvbT4gd3JvdGU6Cj4+ID4+PiBPbiBNb24sIEF1ZyAyOCwgMjAyMyBhdCAxMToxNDo0MUFN ICswMzAwLCBKYW5pIE5pa3VsYSB3cm90ZToKPj4gPj4+PiBPbiBTYXQsIDI2IEF1ZyAyMDIzLCBH dXJ1IERhcyBTcmluYWdlc2ggPHF1aWNfZ3VydXNAcXVpY2luYy5jb20+IHdyb3RlOgo+PiA+Pj4+ PiBUaGlzIHNjcmlwdCBydW5zIGdldF9tYWludGFpbmVyLnB5IG9uIGEgZ2l2ZW4gcGF0Y2ggZmls ZSAob3IgbXVsdGlwbGUKPj4gPj4+Pj4gcGF0Y2ggZmlsZXMpIGFuZCBhZGRzIGl0cyBvdXRwdXQg dG8gdGhlIHBhdGNoIGZpbGUgaW4gcGxhY2Ugd2l0aCB0aGUKPj4gPj4+Pj4gYXBwcm9wcmlhdGUg ZW1haWwgaGVhZGVycyAiVG86ICIgb3IgIkNjOiAiIGFzIHRoZSBjYXNlIG1heSBiZS4gVGhlc2Ug bmV3Cj4+ID4+Pj4+IGhlYWRlcnMgYXJlIGFkZGVkIGFmdGVyIHRoZSAiRnJvbTogIiBsaW5lIGlu IHRoZSBwYXRjaC4KPj4gPj4+Pgo+PiA+Pj4+IEZXSVcsIEkgcGVyc29uYWxseSBwcmVmZXIgdG9v bGluZyB0byBvcGVyYXRlIG9uIGdpdCBicmFuY2hlcyBhbmQgY29tbWl0cwo+PiA+Pj4+IHRoYW4g cGF0Y2hlcy4gRm9yIG1lLCB0aGUgcGF0Y2hlcyBhcmUganVzdCBhbiBpbnRlcm1lZGlhdGUgc3Rl cCBpbgo+PiA+Pj4+IGdldHRpbmcgdGhlIGNvbW1pdHMgZnJvbSBteSBnaXQgYnJhbmNoIHRvIHRo ZSBtYWlsaW5nIGxpc3QuIFRoYXQncyBub3QKPj4gPj4+PiB3aGVyZSBJIGFkZCB0aGUgQ2Mncywg YnV0IHJhdGhlciBpbiB0aGUgY29tbWl0cyBpbiBteSBsb2NhbCBicmFuY2gsCj4+ID4+Pj4gd2hl cmUgdGhleSdyZSBwcmVzZXJ2ZWQuIFlNTVYuCj4+ID4+Pj4KPj4gPj4+Cj4+ID4+PiBNYXkgSSBh c2sgaG93IHlvdSBhZGQvY2FycnkgdGhlIHJlY2lwaWVudHMgaW4gYSBjb21taXQ/Cj4+ID4+Cj4+ ID4+IEkgZ3Vlc3MgYmVsb3cgYSAiLS0tIiBsaW5lIGluIHRoZSBjb21taXQgZGVzY3JpcHRpb24/ Cj4+ID4gCj4+ID4gRG9lcyB0aGF0IGRvIGFueXRoaW5nIHNwZWNpYWwgaW4gY29tbWl0IGxvZz8g SSdkIGV4cGVjdCAoYW5kIEkgZG8gaXQgdGhhdAo+PiA+IHdheSkgaXQncyByYXRoZXIganVzdCBh ZGRpbmcgYQo+PiAKPj4gSXQgZG9lcy4gSXQgZ29lcyBhd2F5Lgo+Cj4gQWZhaWN0LCBpdCdzIHZl cmJhdGltIGNvcGllZCBpbnRvIHRoZSAucGF0Y2gsIHdoaWNoIHdvdWxkIG1lYW4gdGhhdCBpdAo+ IGdvZXMgYXdheSB3aGVuIHRoZSBwYXRjaCBpcyBhcHBsaWVkIG9uIHRoZSBvdGhlciBzaWRlLgo+ Cj4gQnV0IGl0J3Mgc3RpbGwgZ29pbmcgdG8gYmUgaW4gdGhlIGVtYWlsIChmb2xsb3dlZCBieSBh bm90aGVyIC0tLSksIHNvCj4gdW5sZXNzIHRoZXJlJ3MgYW5vdGhlciBzdGVwIGxhdGVyIGluIHRo ZSBwcm9jZXNzIHRoYXQgY2xlYW5zIHRoaXMgdXAgSQo+IGl0IGxvb2tzIHVnbHksIGFuZCBub3Qg dmVyeSB1c2VmdWwgLSB1bmxlc3MgSSdtIG1pc3Npbmcgc29tZXRoaW5nLgo+Cj4+ID4gCj4+ID4g Q2M6IE5hbWUgPGVtYWlsPgo+PiA+IAo+PiA+IGluIHRoZSB0YWcgYXJlYSB3aGVyZSBzLW8tYiwg cmV2aWV3ZWQtYnkgZXRjIGFyZSBhZGRlZC4KPj4gCj4+IFdoeSBzdG9yaW5nIGF1dG9nZW5lcmF0 ZWQgc2NyaXB0cy9nZXRfbWFpbnRhaW5lci5wbCBDQy1lbnRyaWVzIGluIGNvbW1pdAo+PiBtc2c/ IFRoZSBub24tbWFpbnRhaW5lci1vdXRwdXQgYnV0IHRoZSBhdXRvbWF0ZWQgb3V0cHV0PyBUaGVy ZSBpcyBubwo+PiBzaW5nbGUgbmVlZCB0byBzdG9yZSBhdXRvbWF0ZWQgb3V0cHV0IG9mIGdldF9t YWludGFpbmVycy5wbCBpbiB0aGUgZ2l0Cj4+IGxvZy4gSXQgY2FuIGJlIGVhc2lseSByZS1jcmVh dGVkIGF0IGFueSBnaXZlbiB0aW1lLCB0aHVzIGl0cyBwcmVzZW5jZSBpbgo+PiB0aGUgZ2l0IGhp c3RvcnkgaXMgcmVkdW5kYW50IGFuZCBvYmZ1c2NhdGVzIHRoZSBsb2cuCj4+IAo+Cj4gRnVsbHkg YWdyZWUgdG8gdGhpcy4gSW4gcGFydGljdWxhciBpZiB0aGUgcGF0Y2ggaXMgZ29pbmcgdG8gYmUg c2VudCBhcwo+IHBhcnQgb2YgYSBzZXJpZXMgdGhlIHJlY2lwaWVudHMgbGlzdCB3b24ndCBiZSBh Y2N1cmF0ZSBmb3IgYW55IHBhdGNoLgo+Cj4gVGhlIGNhc2UgSSB3YXMgbG9va2luZyBmb3Igd2Fz IHRoZSBjYXNlIHdoZXJlIEkgd2FudCB0byBtYWtlIHN1cmUgdG8KPiBpbmNsdWRlIGEgc3BlY2lm aWMgcGVyc29uLCBiZXlvbmQgdGhlIGdldF9tYWludGFpbmVycyBvdXRwdXQuIFNvIHByZXR0eQo+ IG11Y2ggdGhlIHVzdWFsIENjOiB0YWcgaW4gdGhlIGNvbW1pdCBtZXNzYWdlLCBidXQgSSBkb24n dCBuZWNlc3NhcmlseQo+IHdhbnQgdG8gd3JpdGUgdGhpcyBmYWN0IGludG8gdGhlIGdpdCBoaXN0 b3J5LgoKVGhlIHBvaW50IGlzLCBJICpuZXZlciogdXNlIGdldF9tYWludGFpbmVyLnBsIG91dHB1 dCBhcy1pcy4KCkJSLApKYW5pLgoKCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2Ug R3JhcGhpY3MgQ2VudGVyCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxp c3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0 aW5mby9saW51eC1hcm0ta2VybmVsCg==