From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Martinez Canillas Subject: Re: [PATCH v2 6/9] vgacon: clean up global screen_info instances Date: Wed, 19 Jul 2023 16:17:07 +0200 Message-ID: <87cz0ohtp8.fsf@minerva.mail-host-address-is-not-set> References: <20230719123944.3438363-1-arnd@kernel.org> <20230719123944.3438363-7-arnd@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JGI2pK8pfBXV9fdEywa6nAd2atT9pUmcJOJylXKjtXw=; b=MU06RU1zr/+8l1 ft8IJFDdFaoYjSGsTSb+f+b8oye2Ufupz5cVytwFruanbYKjiYqkny8epCnTAf7Nw+by9XNBfV2qk D2QQCd7CInrH1gc1dfbZMOHB/CZpwiWF5XFSd0twarRpt8vmqzVccsieaw97bqz5I2yYEXWZshwfE 51+zU8gyPTXhxlKQ/aMswG+D2j2d+8xw7JprcjzwhPcUxO8fX8tAWOd1KUK2axPoryCECVsujvacA +7vE2mpxyqgJTeFglkUxKvBKZWvpiYZqeNU7lNW+waxjK6ewb+6Xewy8pMMhr1AbZ17t/FzqRVHyt oEQUB2sz1g0z3eLfgvCw==; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689776252; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YjdFQRNR08a24eSSE2jcx3RnjwPdI3D1UG9L8u3hsoE=; b=GvFk42u94xyBV9J1PucXfmkCDMzFCyZcLAkWC5c9vOYRH4oopfQAdW4MGQYpg9pfahugm2 aN7RAmzGq21L7gYfzeHoWn9YIVEs3gTwOUkIhllmk81bMeUw11jA8Zu+arXUxfskCOJNwW 1YV1HGUima4kq1l95WLa7z6dOh5TTGA= In-Reply-To: <20230719123944.3438363-7-arnd@kernel.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-riscv" Errors-To: linux-riscv-bounces+glpr-linux-riscv=m.gmane-mx.org@lists.infradead.org To: Arnd Bergmann , linux-fbdev@vger.kernel.org, Thomas Zimmermann , Helge Deller Cc: Arnd Bergmann , "David S. Miller" , "K. Y. Srinivasan" , Ard Biesheuvel , Borislav Petkov , Brian Cain , Catalin Marinas , Christophe Leroy , Daniel Vetter , Dave Hansen , David Airlie , Deepak Rawat , Dexuan Cui , Dinh Nguyen , Greg Kroah-Hartman , Guo Ren , Haiyang Zhang , Huacai Chen , Ingo Molnar , John Paul Adrian Glaubitz , Khalid Aziz , Linus Walleij , Matt Turner , Max Arnd Bergmann writes: > From: Arnd Bergmann > > To prepare for completely separating the VGA console screen_info from > the one used in EFI/sysfb, rename the vgacon instances and make them > local as much as possible. > > ia64 and arm both have confurations with vgacon and efi, but the contents is this a typo for configurations ? > never overlaps because ia64 has no EFI framebuffer, and arm only has > vga console on legacy platforms without EFI. Renaming these is required > before the EFI screen_info can be moved into drivers/firmware. > > The ia64 vga console is actually registered in two places from > setup_arch(), but one of them is wrong, so drop the one in pcdp.c and > the fix the one in setup.c to use the correct conditional. > s/the fix the/fix the > x86 has to keep them together, as the boot protocol is used to switch > between VGA text console and framebuffer through the screen_info data. > > Signed-off-by: Arnd Bergmann > --- Patch looks good to me, but I'm not that familiar with some of the arches to give a proper reviewed-by. Acked-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08140EB64DA for ; Wed, 19 Jul 2023 14:19:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231587AbjGSOTJ (ORCPT ); Wed, 19 Jul 2023 10:19:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231569AbjGSOSq (ORCPT ); Wed, 19 Jul 2023 10:18:46 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 233A71982 for ; Wed, 19 Jul 2023 07:17:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689776231; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YjdFQRNR08a24eSSE2jcx3RnjwPdI3D1UG9L8u3hsoE=; b=FWguGfwOO+rfjs0fvFjrSrzQ32kjEPT8o8EekxSSjdUeLTnsXWYM0nd6YMEMHuPUN0EVYE lFM0Qbd2QSn5B7CaU296PsZiorG6xTgOmjiO8mppIyDzasutEqBcqNNcUaB86UlJEEIAq5 LWw7EaryBsiA4dajwANVCpkbAmntw5s= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-286-bBcm_UyGNgelwDPEaA6iUg-1; Wed, 19 Jul 2023 10:17:10 -0400 X-MC-Unique: bBcm_UyGNgelwDPEaA6iUg-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-3fb416d7731so39412395e9.2 for ; Wed, 19 Jul 2023 07:17:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689776229; x=1690381029; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YjdFQRNR08a24eSSE2jcx3RnjwPdI3D1UG9L8u3hsoE=; b=Ftl+B8PBh+Dj/6kQSNKE4cN7tjPlkCqQBQP3wAyhdjDJi+d2QIQ+7hKtscbrD5Jr+O 0MEhaiMxOLfzgyjOCRz4RtLSN4rHZ1w96pCFGFo1RPaCuVHBlqznG38wIXkBMWtrR4oe JEHpbel4AWN8DiBuyylLul4dUYO1xvyuLh2cJWx13AGnJJpZh9nuetUZMGxz3qtlBdnI +lgr7aCT+kNwWqZjjHbMkNbix8w+Nhh6WFW1sDiX9Np9ZE3s+dY9ZKly/X1G8PJyoP7W EnuLHaT/s+kkn9Lebag7TrKgMFIA/8Uv7iAhvkas1i2ifEBb2cBOwSRqYf6V+0YJ39nm KTRA== X-Gm-Message-State: ABy/qLbrr1NNreqUxkv72NeDFiVIgi6MGbUrH7c6Ymee2Txz8pmGPg2L RZkoBu3YCVIiR7fYM/u8t5y/sCv2VOb3+w3JlBBVk20SKoyY8oEEsifO/UJ8tLXhXuMl1VI1bvu dB6QEfF+X8rY86QAKoWKO5A== X-Received: by 2002:a05:600c:3651:b0:3fc:627:ea31 with SMTP id y17-20020a05600c365100b003fc0627ea31mr2123094wmq.38.1689776229116; Wed, 19 Jul 2023 07:17:09 -0700 (PDT) X-Google-Smtp-Source: APBJJlHY6b0TgUW8MDG3POksnXdAxeQBRH+KD9U9aN090eyMWJPzhTreLBf0F2Av+qSumHgaL9gGUQ== X-Received: by 2002:a05:600c:3651:b0:3fc:627:ea31 with SMTP id y17-20020a05600c365100b003fc0627ea31mr2123053wmq.38.1689776228833; Wed, 19 Jul 2023 07:17:08 -0700 (PDT) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id h21-20020a1ccc15000000b003fbacc853ccsm1833816wmb.18.2023.07.19.07.17.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Jul 2023 07:17:08 -0700 (PDT) From: Javier Martinez Canillas To: Arnd Bergmann , linux-fbdev@vger.kernel.org, Thomas Zimmermann , Helge Deller Cc: Arnd Bergmann , "David S. Miller" , "K. Y. Srinivasan" , Ard Biesheuvel , Borislav Petkov , Brian Cain , Catalin Marinas , Christophe Leroy , Daniel Vetter , Dave Hansen , David Airlie , Deepak Rawat , Dexuan Cui , Dinh Nguyen , Greg Kroah-Hartman , Guo Ren , Haiyang Zhang , Huacai Chen , Ingo Molnar , John Paul Adrian Glaubitz , Khalid Aziz , Linus Walleij , Matt Turner , Max Filippov , Michael Ellerman , Nicholas Piggin , Palmer Dabbelt , Russell King , Thomas Bogendoerfer , Thomas Gleixner , WANG Xuerui , Wei Liu , Will Deacon , x86@kernel.org, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-efi@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-hyperv@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v2 6/9] vgacon: clean up global screen_info instances In-Reply-To: <20230719123944.3438363-7-arnd@kernel.org> References: <20230719123944.3438363-1-arnd@kernel.org> <20230719123944.3438363-7-arnd@kernel.org> Date: Wed, 19 Jul 2023 16:17:07 +0200 Message-ID: <87cz0ohtp8.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-csky@vger.kernel.org Arnd Bergmann writes: > From: Arnd Bergmann > > To prepare for completely separating the VGA console screen_info from > the one used in EFI/sysfb, rename the vgacon instances and make them > local as much as possible. > > ia64 and arm both have confurations with vgacon and efi, but the contents is this a typo for configurations ? > never overlaps because ia64 has no EFI framebuffer, and arm only has > vga console on legacy platforms without EFI. Renaming these is required > before the EFI screen_info can be moved into drivers/firmware. > > The ia64 vga console is actually registered in two places from > setup_arch(), but one of them is wrong, so drop the one in pcdp.c and > the fix the one in setup.c to use the correct conditional. > s/the fix the/fix the > x86 has to keep them together, as the boot protocol is used to switch > between VGA text console and framebuffer through the screen_info data. > > Signed-off-by: Arnd Bergmann > --- Patch looks good to me, but I'm not that familiar with some of the arches to give a proper reviewed-by. Acked-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78593EB64DA for ; Wed, 19 Jul 2023 14:17:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JGI2pK8pfBXV9fdEywa6nAd2atT9pUmcJOJylXKjtXw=; b=MU06RU1zr/+8l1 ft8IJFDdFaoYjSGsTSb+f+b8oye2Ufupz5cVytwFruanbYKjiYqkny8epCnTAf7Nw+by9XNBfV2qk D2QQCd7CInrH1gc1dfbZMOHB/CZpwiWF5XFSd0twarRpt8vmqzVccsieaw97bqz5I2yYEXWZshwfE 51+zU8gyPTXhxlKQ/aMswG+D2j2d+8xw7JprcjzwhPcUxO8fX8tAWOd1KUK2axPoryCECVsujvacA +7vE2mpxyqgJTeFglkUxKvBKZWvpiYZqeNU7lNW+waxjK6ewb+6Xewy8pMMhr1AbZ17t/FzqRVHyt oEQUB2sz1g0z3eLfgvCw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qM7zj-007hC7-38; Wed, 19 Jul 2023 14:17:35 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qM7zh-007hBV-0S for linux-riscv@lists.infradead.org; Wed, 19 Jul 2023 14:17:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689776252; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YjdFQRNR08a24eSSE2jcx3RnjwPdI3D1UG9L8u3hsoE=; b=GvFk42u94xyBV9J1PucXfmkCDMzFCyZcLAkWC5c9vOYRH4oopfQAdW4MGQYpg9pfahugm2 aN7RAmzGq21L7gYfzeHoWn9YIVEs3gTwOUkIhllmk81bMeUw11jA8Zu+arXUxfskCOJNwW 1YV1HGUima4kq1l95WLa7z6dOh5TTGA= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-317-xz7j3BkzNxaw7DKFllUBWA-1; Wed, 19 Jul 2023 10:17:15 -0400 X-MC-Unique: xz7j3BkzNxaw7DKFllUBWA-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-3fc08d6a40cso39427815e9.0 for ; Wed, 19 Jul 2023 07:17:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689776229; x=1690381029; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YjdFQRNR08a24eSSE2jcx3RnjwPdI3D1UG9L8u3hsoE=; b=lYHYJONwU8niYAiCPqGNMqO7dmFQw/RRQuI1EVCt1Lddn8d1x0jHcExm9sumDh8AwP LHUDdqqTskai3du5o07vwjF8TVAwTVaqb7PsNv+ydU4K3/ni/vERTIQSQ4syWIBjGnd3 dMRzEyUlks3W6yDzdp6GC3HhIVoPoP4nwFppmtVepfJkrYefUjtycNVmloAksqbjBWwt RW6r+sJSWOD3s151dgjECsy96ddnBXYF3A+X5moP/ehns6CbT025PeikjqGL7fLrROdh 0G+qJgBTnFSnXsI9xBBfDHre1iBqjmAoIRmvgZTYNDalKPm9hLrUr1l1J3VximLNsNSI qpcg== X-Gm-Message-State: ABy/qLZTedeVT2c8czoYWGu4Eg/rjCiC8i4bNOVlx4CkkccMiaGGOmYY nXXj0Z4hEw/rTYgfE2/c9AhlK+YS2i9pRPo2H756wND/R3NYr5cxrChvyhETtuaDMjmOK3WgGJJ qG+PppOMwvl5gH0dKHplpD1XFmXHs X-Received: by 2002:a05:600c:3651:b0:3fc:627:ea31 with SMTP id y17-20020a05600c365100b003fc0627ea31mr2123100wmq.38.1689776229115; Wed, 19 Jul 2023 07:17:09 -0700 (PDT) X-Google-Smtp-Source: APBJJlHY6b0TgUW8MDG3POksnXdAxeQBRH+KD9U9aN090eyMWJPzhTreLBf0F2Av+qSumHgaL9gGUQ== X-Received: by 2002:a05:600c:3651:b0:3fc:627:ea31 with SMTP id y17-20020a05600c365100b003fc0627ea31mr2123053wmq.38.1689776228833; Wed, 19 Jul 2023 07:17:08 -0700 (PDT) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id h21-20020a1ccc15000000b003fbacc853ccsm1833816wmb.18.2023.07.19.07.17.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Jul 2023 07:17:08 -0700 (PDT) From: Javier Martinez Canillas To: Arnd Bergmann , linux-fbdev@vger.kernel.org, Thomas Zimmermann , Helge Deller Cc: Arnd Bergmann , "David S. Miller" , "K. Y. Srinivasan" , Ard Biesheuvel , Borislav Petkov , Brian Cain , Catalin Marinas , Christophe Leroy , Daniel Vetter , Dave Hansen , David Airlie , Deepak Rawat , Dexuan Cui , Dinh Nguyen , Greg Kroah-Hartman , Guo Ren , Haiyang Zhang , Huacai Chen , Ingo Molnar , John Paul Adrian Glaubitz , Khalid Aziz , Linus Walleij , Matt Turner , Max Filippov , Michael Ellerman , Nicholas Piggin , Palmer Dabbelt , Russell King , Thomas Bogendoerfer , Thomas Gleixner , WANG Xuerui , Wei Liu , Will Deacon , x86@kernel.org, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-efi@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-hyperv@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v2 6/9] vgacon: clean up global screen_info instances In-Reply-To: <20230719123944.3438363-7-arnd@kernel.org> References: <20230719123944.3438363-1-arnd@kernel.org> <20230719123944.3438363-7-arnd@kernel.org> Date: Wed, 19 Jul 2023 16:17:07 +0200 Message-ID: <87cz0ohtp8.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230719_071733_275903_48549987 X-CRM114-Status: GOOD ( 18.03 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Arnd Bergmann writes: > From: Arnd Bergmann > > To prepare for completely separating the VGA console screen_info from > the one used in EFI/sysfb, rename the vgacon instances and make them > local as much as possible. > > ia64 and arm both have confurations with vgacon and efi, but the contents is this a typo for configurations ? > never overlaps because ia64 has no EFI framebuffer, and arm only has > vga console on legacy platforms without EFI. Renaming these is required > before the EFI screen_info can be moved into drivers/firmware. > > The ia64 vga console is actually registered in two places from > setup_arch(), but one of them is wrong, so drop the one in pcdp.c and > the fix the one in setup.c to use the correct conditional. > s/the fix the/fix the > x86 has to keep them together, as the boot protocol is used to switch > between VGA text console and framebuffer through the screen_info data. > > Signed-off-by: Arnd Bergmann > --- Patch looks good to me, but I'm not that familiar with some of the arches to give a proper reviewed-by. Acked-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3F34EB64DA for ; Wed, 19 Jul 2023 14:18:43 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=PBFPnKRH; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=PBFPnKRH; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4R5dGV1Zcvz3bnr for ; Thu, 20 Jul 2023 00:18:42 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=PBFPnKRH; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=PBFPnKRH; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=170.10.133.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=fmartine@redhat.com; receiver=lists.ozlabs.org) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4R5dDr3mJmz30Q3 for ; Thu, 20 Jul 2023 00:17:16 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689776232; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YjdFQRNR08a24eSSE2jcx3RnjwPdI3D1UG9L8u3hsoE=; b=PBFPnKRHPfxRQZ0KnBfWne0Zv04tU/3OZCyU0RgD1VC9UbR+yX08xfJVl8HtR/B+XOEu/9 iFK1u2pYF5WctsOUv3ROM54TF71ekjIpRqJkgktFXvzOk7b7+XvCdzzRwp6n+s5WqtJEKG DH1ZAnW3FDKZZQ8PIVwDlcTYATlp1Ao= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689776232; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YjdFQRNR08a24eSSE2jcx3RnjwPdI3D1UG9L8u3hsoE=; b=PBFPnKRHPfxRQZ0KnBfWne0Zv04tU/3OZCyU0RgD1VC9UbR+yX08xfJVl8HtR/B+XOEu/9 iFK1u2pYF5WctsOUv3ROM54TF71ekjIpRqJkgktFXvzOk7b7+XvCdzzRwp6n+s5WqtJEKG DH1ZAnW3FDKZZQ8PIVwDlcTYATlp1Ao= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-42-tg6CNeaiNGOaKmjDzKnnkg-1; Wed, 19 Jul 2023 10:17:10 -0400 X-MC-Unique: tg6CNeaiNGOaKmjDzKnnkg-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-3fbe4cecd66so39440475e9.1 for ; Wed, 19 Jul 2023 07:17:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689776229; x=1690381029; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YjdFQRNR08a24eSSE2jcx3RnjwPdI3D1UG9L8u3hsoE=; b=baXihaJyWR7PLZ3YYYXTM4dJ5Br+UcBmnjzVwGt3rjrg7QMZh+Trgz33gUEJ3/opiw tgbbZmZnmW52qiEGU4c3ehbDbjY8rwBpIXpsPi8PCJ8iOjArPI6pnGbIBeavx9ZqVeE8 m16V88DR9E9fdKuXnMexMBaPxMCCOZm9BCvDii8ZngtVRxp04Aw8Ienoi2l7Dbvfr6BE Q8H1/o4Ja3txpjqWRj50YpTvBfuMkAgyApiRd0QHprFA3NJsZVWU2eJ6sv38nowQ2+8F VhVaZ6gchOczP2LPXE5qduZGj0cQ0IdmdrJRzZNnfVl5XWYiTE3fD6qOwMKTZaph3awn +TJQ== X-Gm-Message-State: ABy/qLbd50L1RSxfHJPbw/Pqgti598rOdC/8vRO3WJpEtIxwFLC0A6WI xbzki5OhUBPFkWdjvlO4KL2F9TXR9aizzck3Qvsej7ZopYGAjyvPcdowBRgvMKhIHuWWqB8x+A+ VLOaB/IAHvnUWttZp0STUlcU+WQ== X-Received: by 2002:a05:600c:3651:b0:3fc:627:ea31 with SMTP id y17-20020a05600c365100b003fc0627ea31mr2123093wmq.38.1689776229114; Wed, 19 Jul 2023 07:17:09 -0700 (PDT) X-Google-Smtp-Source: APBJJlHY6b0TgUW8MDG3POksnXdAxeQBRH+KD9U9aN090eyMWJPzhTreLBf0F2Av+qSumHgaL9gGUQ== X-Received: by 2002:a05:600c:3651:b0:3fc:627:ea31 with SMTP id y17-20020a05600c365100b003fc0627ea31mr2123053wmq.38.1689776228833; Wed, 19 Jul 2023 07:17:08 -0700 (PDT) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id h21-20020a1ccc15000000b003fbacc853ccsm1833816wmb.18.2023.07.19.07.17.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Jul 2023 07:17:08 -0700 (PDT) From: Javier Martinez Canillas To: Arnd Bergmann , linux-fbdev@vger.kernel.org, Thomas Zimmermann , Helge Deller Subject: Re: [PATCH v2 6/9] vgacon: clean up global screen_info instances In-Reply-To: <20230719123944.3438363-7-arnd@kernel.org> References: <20230719123944.3438363-1-arnd@kernel.org> <20230719123944.3438363-7-arnd@kernel.org> Date: Wed, 19 Jul 2023 16:17:07 +0200 Message-ID: <87cz0ohtp8.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-hyperv@vger.kernel.org, x86@kernel.org, linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Catalin Marinas , Linus Walleij , Dave Hansen , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, Max Filippov , Will Deacon , linux-efi@vger.kernel.org, Guo Ren , linux-csky@vger.kernel.org, sparclinux@vger.kernel.org, linux-hexagon@vger.kernel.org, WANG Xuerui , "K. Y. Srinivasan" , David Airlie , Ard Biesheuvel , Wei Liu , Huacai Chen , Dexuan Cui , Russell King , Deepak Rawat , Ingo Molnar , Matt Turner , Arnd Bergmann , Haiyang Zhang , Nicholas Piggin , Bor islav Petkov , loongarch@lists.linux.dev, John Paul Adrian Glaubitz , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Khalid Aziz , Brian Cain , Thomas Bogendoerfer , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Dinh Nguyen , linux-riscv@lists.infradead.org, Palmer Dabbelt , Daniel Vetter , linux-alpha@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Arnd Bergmann writes: > From: Arnd Bergmann > > To prepare for completely separating the VGA console screen_info from > the one used in EFI/sysfb, rename the vgacon instances and make them > local as much as possible. > > ia64 and arm both have confurations with vgacon and efi, but the contents is this a typo for configurations ? > never overlaps because ia64 has no EFI framebuffer, and arm only has > vga console on legacy platforms without EFI. Renaming these is required > before the EFI screen_info can be moved into drivers/firmware. > > The ia64 vga console is actually registered in two places from > setup_arch(), but one of them is wrong, so drop the one in pcdp.c and > the fix the one in setup.c to use the correct conditional. > s/the fix the/fix the > x86 has to keep them together, as the boot protocol is used to switch > between VGA text console and framebuffer through the screen_info data. > > Signed-off-by: Arnd Bergmann > --- Patch looks good to me, but I'm not that familiar with some of the arches to give a proper reviewed-by. Acked-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2C6C7EB64DA for ; Wed, 19 Jul 2023 14:17:15 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7454210E4AB; Wed, 19 Jul 2023 14:17:14 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1C7D610E4AB for ; Wed, 19 Jul 2023 14:17:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689776232; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YjdFQRNR08a24eSSE2jcx3RnjwPdI3D1UG9L8u3hsoE=; b=PBFPnKRHPfxRQZ0KnBfWne0Zv04tU/3OZCyU0RgD1VC9UbR+yX08xfJVl8HtR/B+XOEu/9 iFK1u2pYF5WctsOUv3ROM54TF71ekjIpRqJkgktFXvzOk7b7+XvCdzzRwp6n+s5WqtJEKG DH1ZAnW3FDKZZQ8PIVwDlcTYATlp1Ao= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-349-i9JM9At1NkqRV142-cqt7Q-1; Wed, 19 Jul 2023 10:17:10 -0400 X-MC-Unique: i9JM9At1NkqRV142-cqt7Q-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-3fb416d7731so39412435e9.2 for ; Wed, 19 Jul 2023 07:17:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689776229; x=1690381029; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YjdFQRNR08a24eSSE2jcx3RnjwPdI3D1UG9L8u3hsoE=; b=Bo9UDwdapGnIT5wMF5x5GmKWeu9aFJVOwIn1x+CQPk/z1tp559Ot0nGdJmJ2rmbz6p VwKWT34pWjtzr7A//p8UbquJCDpJm+HTZG02nxUANThEfNshJLMLBlZKiqO+IIBG2fp3 eX+absBM1kM3DVInHWd9OxlQmGbD9a/3FKdCv49zB8vkfVU/q4/XrOq5ZCS1aUjyz0LW 7yVqI6qe3JJO3tb+WgSZ8RZnWHs3UGtLx0YhtXzc+GI+d0MgkdsdBug1TB1IXB5n4jgE YuWZwwjz8LIY9dNaPLrtXVf2H3OV7Kme2WM74yeQv7zHZCpMaZzLu6wRkCcV2sjsK3HC c5Dw== X-Gm-Message-State: ABy/qLZxRUYqMLRDQ5Fg8aPRWrAvmOL2ipTmQXXS67Jom+v0F7uOp0Uv BliPhkbFZ2a2EpYdG/WhHySfHbycegRoUGstlhN3BD/zoh2bBEOV8jMibclbntNfWfYLVG8MGc/ lJnan3dEvjsnWXjtqp4QVTR9FEpPd X-Received: by 2002:a05:600c:3651:b0:3fc:627:ea31 with SMTP id y17-20020a05600c365100b003fc0627ea31mr2123084wmq.38.1689776229113; Wed, 19 Jul 2023 07:17:09 -0700 (PDT) X-Google-Smtp-Source: APBJJlHY6b0TgUW8MDG3POksnXdAxeQBRH+KD9U9aN090eyMWJPzhTreLBf0F2Av+qSumHgaL9gGUQ== X-Received: by 2002:a05:600c:3651:b0:3fc:627:ea31 with SMTP id y17-20020a05600c365100b003fc0627ea31mr2123053wmq.38.1689776228833; Wed, 19 Jul 2023 07:17:08 -0700 (PDT) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id h21-20020a1ccc15000000b003fbacc853ccsm1833816wmb.18.2023.07.19.07.17.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Jul 2023 07:17:08 -0700 (PDT) From: Javier Martinez Canillas To: Arnd Bergmann , linux-fbdev@vger.kernel.org, Thomas Zimmermann , Helge Deller Subject: Re: [PATCH v2 6/9] vgacon: clean up global screen_info instances In-Reply-To: <20230719123944.3438363-7-arnd@kernel.org> References: <20230719123944.3438363-1-arnd@kernel.org> <20230719123944.3438363-7-arnd@kernel.org> Date: Wed, 19 Jul 2023 16:17:07 +0200 Message-ID: <87cz0ohtp8.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-hyperv@vger.kernel.org, x86@kernel.org, linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Catalin Marinas , Dave Hansen , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, Max Filippov , Will Deacon , linux-efi@vger.kernel.org, Guo Ren , linux-csky@vger.kernel.org, sparclinux@vger.kernel.org, linux-hexagon@vger.kernel.org, WANG Xuerui , "K. Y. Srinivasan" , Ard Biesheuvel , Wei Liu , Michael Ellerman , Huacai Chen , Dexuan Cui , Russell King , Christophe Leroy , Deepak Rawat , Ingo Molnar , Matt Turner , Arnd Bergmann , Haiyang Zhang , Nicholas Piggin , Borislav Petkov , loongarch@lists.linux.dev, John Paul Adrian Glaubitz , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Khalid Aziz , Brian Cain , Thomas Bogendoerfer , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Dinh Nguyen , linux-riscv@lists.infradead.org, Palmer Dabbelt , linux-alpha@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, "David S. Miller" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Arnd Bergmann writes: > From: Arnd Bergmann > > To prepare for completely separating the VGA console screen_info from > the one used in EFI/sysfb, rename the vgacon instances and make them > local as much as possible. > > ia64 and arm both have confurations with vgacon and efi, but the contents is this a typo for configurations ? > never overlaps because ia64 has no EFI framebuffer, and arm only has > vga console on legacy platforms without EFI. Renaming these is required > before the EFI screen_info can be moved into drivers/firmware. > > The ia64 vga console is actually registered in two places from > setup_arch(), but one of them is wrong, so drop the one in pcdp.c and > the fix the one in setup.c to use the correct conditional. > s/the fix the/fix the > x86 has to keep them together, as the boot protocol is used to switch > between VGA text console and framebuffer through the screen_info data. > > Signed-off-by: Arnd Bergmann > --- Patch looks good to me, but I'm not that familiar with some of the arches to give a proper reviewed-by. Acked-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat