From: Takashi Iwai <tiwai@suse.de>
To: Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH] regmap: maple: Don't sync read-only registers
Date: Tue, 13 Jun 2023 13:09:24 +0200 [thread overview]
Message-ID: <87cz1zehzv.wl-tiwai@suse.de> (raw)
In-Reply-To: <e04053b2-897c-46fa-bd1f-e455e01c6152@sirena.org.uk>
On Tue, 13 Jun 2023 12:59:27 +0200,
Mark Brown wrote:
>
> On Tue, Jun 13, 2023 at 12:34:45PM +0200, Takashi Iwai wrote:
> > Mark Brown wrote:
> > > On Tue, Jun 13, 2023 at 09:45:11AM +0200, Takashi Iwai wrote:
>
> > > This should be in _needs_sync().
>
> > I thought it's a different logic? regacahe_reg_needs_sync() checks
> > only whether it's a default value, and other call paths already check
> > regmap_writeable().
>
> Yeah, but it feels like that's the reason we ran into this issue given
> that you'd expect _needs_sync() to check this too.
>
> > But I can put the check there instead if you still prefer, too.
>
> It should avoid any similar issues in future.
OK, then let me cook the v2.
Takashi
prev parent reply other threads:[~2023-06-13 11:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 7:45 [PATCH] regmap: maple: Don't sync read-only registers Takashi Iwai
2023-06-13 10:16 ` Mark Brown
2023-06-13 10:34 ` Takashi Iwai
2023-06-13 10:59 ` Mark Brown
2023-06-13 11:09 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cz1zehzv.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.