From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD83DC76196 for ; Tue, 11 Apr 2023 06:44:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-reply-to: Date:Subject:Cc:To:From:References:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FgKOER4L16Q+DlREXRc+B9G3g4TmKq14jVe7HWIlOXg=; b=XTlibw7zzzVLjA zoCbv5fwyYZRBa5J0/CFTSgyOm9cYosRe5yodznE1B2VDKoqsXCR7cm8CkSqxSN4HofU5okzXF6XR kJL+Ln9z5TuLofz9xCHhYxJlmjk+mxir6LK7h54IP42QTPr/2STlk5zTtxp/iHh1jLoL8GyRRrYea eqNBgf7YC2CmYAcBoutDvxnta41RMcHRZzicj23LDl+FhULkaz0qcI0jK+P4vZCmk81c4H243rW6a q1alm+4Ilh0ccXlYUGfbGss3DSxkbmXDguemdgIr5dxnBywA25biCG0asiK50uXEaNI2v0WS2+uwU eX35/y//Ewfj+sZl/GaQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pm7jd-00GbdO-0p; Tue, 11 Apr 2023 06:44:09 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pm7ja-00GbcR-0H for linux-arm-kernel@lists.infradead.org; Tue, 11 Apr 2023 06:44:08 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=igor.pengutronix.de) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pm7jV-0005aT-Kz; Tue, 11 Apr 2023 08:44:01 +0200 References: <20230330050408.3806093-1-s.trumtrar@pengutronix.de> <20230330050408.3806093-10-s.trumtrar@pengutronix.de> User-agent: mu4e 1.8.14; emacs 28.2 From: Steffen Trumtrar To: Alexandre TORGUE Cc: linux-stm32@st-md-mailman.stormreply.com, Krzysztof Kozlowski , Maxime Coquelin , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v7 09/10] ARM: dts: stm32: add STM32MP1-based Phytec SoM Date: Tue, 11 Apr 2023 08:42:50 +0200 In-reply-to: Message-ID: <87cz4a5368.fsf@pengutronix.de> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:900:1d::77 X-SA-Exim-Mail-From: s.trumtrar@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230410_234406_126285_F3A6E77F X-CRM114-Status: GOOD ( 12.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Alexandre, Alexandre TORGUE writes: >> + gpu_reserved: gpu@f8000000 { >> + reg = <0xf8000000 0x8000000>; >> + no-map; >> + }; > > It seems that this region is not used. Furthermore if you plan to use it to GPU > note that it doesn't respect YAMl verification. So please remove it. > Ack. Will remove. >> +ðernet0 { >> + pinctrl-0 = <ðernet0_rgmii_pins_d>; >> + pinctrl-1 = <ðernet0_rgmii_sleep_pins_d>; >> + pinctrl-names = "default", "sleep"; >> + phy-mode = "rgmii-id"; >> + max-speed = <1000>; >> + phy-handle = <&phy0>; >> + st,eth-clk-sel; >> + clock-names = "stmmaceth", >> + "mac-clk-tx", >> + "mac-clk-rx", >> + "eth-ck", >> + "syscfg-clk", >> + "ethstp"; >> + clocks = <&rcc ETHMAC>, >> + <&rcc ETHTX>, >> + <&rcc ETHRX>, >> + <&rcc ETHCK_K>, >> + <&rcc SYSCFG>, >> + <&rcc ETHSTP>; > > Why do you re define those clocks ? They are all already defined in > stm32mp151.dtsi > Just an oversight :( Will remove. Thanks, Steffen -- Pengutronix e.K. | Dipl.-Inform. Steffen Trumtrar | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686| Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9312DC7619A for ; Tue, 11 Apr 2023 06:44:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229688AbjDKGoF (ORCPT ); Tue, 11 Apr 2023 02:44:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229536AbjDKGoE (ORCPT ); Tue, 11 Apr 2023 02:44:04 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B608E60 for ; Mon, 10 Apr 2023 23:44:03 -0700 (PDT) Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=igor.pengutronix.de) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pm7jV-0005aT-Kz; Tue, 11 Apr 2023 08:44:01 +0200 References: <20230330050408.3806093-1-s.trumtrar@pengutronix.de> <20230330050408.3806093-10-s.trumtrar@pengutronix.de> User-agent: mu4e 1.8.14; emacs 28.2 From: Steffen Trumtrar To: Alexandre TORGUE Cc: linux-stm32@st-md-mailman.stormreply.com, Krzysztof Kozlowski , Maxime Coquelin , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v7 09/10] ARM: dts: stm32: add STM32MP1-based Phytec SoM Date: Tue, 11 Apr 2023 08:42:50 +0200 In-reply-to: Message-ID: <87cz4a5368.fsf@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:900:1d::77 X-SA-Exim-Mail-From: s.trumtrar@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Alexandre, Alexandre TORGUE writes: >> + gpu_reserved: gpu@f8000000 { >> + reg = <0xf8000000 0x8000000>; >> + no-map; >> + }; > > It seems that this region is not used. Furthermore if you plan to use it to GPU > note that it doesn't respect YAMl verification. So please remove it. > Ack. Will remove. >> +ðernet0 { >> + pinctrl-0 = <ðernet0_rgmii_pins_d>; >> + pinctrl-1 = <ðernet0_rgmii_sleep_pins_d>; >> + pinctrl-names = "default", "sleep"; >> + phy-mode = "rgmii-id"; >> + max-speed = <1000>; >> + phy-handle = <&phy0>; >> + st,eth-clk-sel; >> + clock-names = "stmmaceth", >> + "mac-clk-tx", >> + "mac-clk-rx", >> + "eth-ck", >> + "syscfg-clk", >> + "ethstp"; >> + clocks = <&rcc ETHMAC>, >> + <&rcc ETHTX>, >> + <&rcc ETHRX>, >> + <&rcc ETHCK_K>, >> + <&rcc SYSCFG>, >> + <&rcc ETHSTP>; > > Why do you re define those clocks ? They are all already defined in > stm32mp151.dtsi > Just an oversight :( Will remove. Thanks, Steffen -- Pengutronix e.K. | Dipl.-Inform. Steffen Trumtrar | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686| Fax: +49-5121-206917-5555 |