From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915: Replace wm.max_levels with wm.num_levels and use it everywhere
Date: Fri, 10 Feb 2023 12:37:21 +0200 [thread overview]
Message-ID: <87cz6hx0v2.fsf@intel.com> (raw)
In-Reply-To: <Y+Vu0gWjk1LwVJbT@intel.com>
On Fri, 10 Feb 2023, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Thu, Feb 09, 2023 at 05:40:14PM +0200, Jani Nikula wrote:
>> On Thu, 09 Feb 2023, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
>> > @@ -3229,7 +3216,7 @@ static void ilk_wm_merge(struct drm_i915_private *dev_priv,
>> > merged->fbc_wm_enabled = DISPLAY_VER(dev_priv) >= 6;
>> >
>> > /* merge each WM1+ level */
>> > - for (level = 1; level <= max_level; level++) {
>> > + for (level = 1; level < num_levels - 1; level++) {
>>
>> That's off by one, right?
>
> Whoops. Good eyes.
Thanks for v2, I went ahead and pushed these to drm-intel-next so I can
rebase my wm stuff on top.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2023-02-10 10:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 0:32 [Intel-gfx] [PATCH 1/2] drm/i915: Populate wm.max_level for everyone Ville Syrjala
2023-02-09 0:32 ` [Intel-gfx] [PATCH 2/2] drm/i915: Replace wm.max_levels with wm.num_levels and use it everywhere Ville Syrjala
2023-02-09 15:40 ` Jani Nikula
2023-02-09 22:08 ` Ville Syrjälä
2023-02-10 10:37 ` Jani Nikula [this message]
2023-02-10 10:44 ` Ville Syrjälä
2023-02-09 22:25 ` [Intel-gfx] [PATCH v2 " Ville Syrjala
2023-02-09 1:32 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Populate wm.max_level for everyone Patchwork
2023-02-09 3:15 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915: Populate wm.max_level for everyone (rev2) Patchwork
2023-02-09 3:51 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-02-09 15:40 ` [Intel-gfx] [PATCH 1/2] drm/i915: Populate wm.max_level for everyone Jani Nikula
2023-02-09 22:43 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915: Populate wm.max_level for everyone (rev3) Patchwork
2023-02-09 23:04 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-02-09 23:49 ` [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Populate wm.max_level for everyone (rev2) Patchwork
2023-02-10 17:30 ` [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Populate wm.max_level for everyone (rev3) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cz6hx0v2.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.