All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Dave Taht <dave.taht@gmail.com>, team lnx <teamlnxi8@gmail.com>
Cc: xdp-newbies@vger.kernel.org
Subject: Re: Pause and unpause queue
Date: Sat, 07 Jan 2023 19:48:56 +0100	[thread overview]
Message-ID: <87cz7qyycn.fsf@toke.dk> (raw)
In-Reply-To: <CAA93jw5EJ7OEo9hDJNWn8nLQhO+WezDs-rf+V0mOqUZ8ExAuLQ@mail.gmail.com>

Dave Taht <dave.taht@gmail.com> writes:

> On Sat, Jan 7, 2023 at 10:08 AM team lnx <teamlnxi8@gmail.com> wrote:
>>
>> sure, during xdp redirect i found that sometimes the number of packets
>> arrived are too many for an interface
>
> That is often the case.
>
>> to handle in which case. Hence thought to experiment with tx pause to
>> make room for successive packets and then unpause !
>
> "pauses" are really not how the internet works, there needs to be end
> to end signalling to "slow down", either via packet loss, or marking.
> RFC970 is a good read here.

Actually it is, kinda, at this level: Pausing the TX interface (when the
HWQ is full) is how the regular network stack creates backpressure
against the qdisc, which is what allows fq_codel and friends to
function. This is missing entirely from the XDP redirect path, which is
what we're trying to fix...

-Toke


  reply	other threads:[~2023-01-07 18:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-06  3:00 Pause and unpause queue team lnx
2023-01-06 13:00 ` Toke Høiland-Jørgensen
2023-01-07 18:04   ` team lnx
2023-01-07 18:24     ` Dave Taht
2023-01-07 18:48       ` Toke Høiland-Jørgensen [this message]
2023-01-08  6:02         ` team lnx
2023-01-09 13:27           ` Toke Høiland-Jørgensen
2023-01-07 18:47     ` Toke Høiland-Jørgensen
2023-01-10 10:32       ` Marcus Wichelmann
2023-01-10 15:00         ` Toke Høiland-Jørgensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cz7qyycn.fsf@toke.dk \
    --to=toke@redhat.com \
    --cc=dave.taht@gmail.com \
    --cc=teamlnxi8@gmail.com \
    --cc=xdp-newbies@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.