From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Schwab Date: Sat, 17 Dec 2022 13:50:45 +0100 Subject: [PATCH v3 1/5] lib: utils/irqchip: plic: Fix the off-by-one error in priority save/restore helpers In-Reply-To: (Anup Patel's message of "Sat, 17 Dec 2022 08:51:37 +0530") References: <20221211065424.806478-1-bmeng@tinylab.org> <87a63ufe4a.fsf@linux-m68k.org> <65db953b-fc55-7323-7c8b-754c9b8f6d85@sholland.org> Message-ID: <87cz8iry6y.fsf@igel.home> List-Id: To: opensbi@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Dez 17 2022, Anup Patel wrote: > On Mon, Dec 12, 2022 at 12:10 PM Samuel Holland wrote: >> >> On 12/11/22 04:18, Bin Meng wrote: >> > On Sun, Dec 11, 2022 at 6:08 PM Andreas Schwab wrote: >> >> >> >> On Dez 11 2022, Bin Meng wrote: >> >> >> >>> diff --git a/lib/utils/irqchip/plic.c b/lib/utils/irqchip/plic.c >> >>> index 73d7788..4df9020 100644 >> >>> --- a/lib/utils/irqchip/plic.c >> >>> +++ b/lib/utils/irqchip/plic.c >> >>> @@ -38,13 +38,13 @@ static void plic_set_priority(const struct plic_data *plic, u32 source, u32 val) >> >>> >> >>> void plic_priority_save(const struct plic_data *plic, u8 *priority) >> >>> { >> >>> - for (u32 i = 0; i < plic->num_src; i++) >> >>> + for (u32 i = 1; i <= plic->num_src; i++) >> >>> priority[i] = plic_get_priority(plic, i); >> >> >> >> That needs to adjust the index into the priority array. >> > >> > Does that help anything? It just confuses people more. >> > >> > I added function parameter descriptions in patch 2 to make it crystal >> > clear, that the priority array needs to include interrupt source 0. >> >> To me, it is more confusing that when I ask to save the priority for N >> sources, I need to allocate an array with >N elements. And leaving array >> element 0 unused wastes memory. > > This can be a separate improvement patch. It is a bug fix, not just an improvement. -- Andreas Schwab, schwab at linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."