All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Mark Yacoub <markyacoub@chromium.org>
Cc: robdclark@chromium.org, khaled.almahallawy@intel.com,
	vsuley@google.com, markyacoub@google.com,
	igt-dev@lists.freedesktop.org, kalin@google.com,
	seanpaul@chromium.org, ihf@google.com, matthewtlam@google.com,
	petri.latvala@intel.com, amstan@chromium.org
Subject: Re: [igt-dev] [PATCH] [NEW]kms_chamelium: Add new EDID stress resolution test
Date: Tue, 01 Nov 2022 16:04:29 -0700	[thread overview]
Message-ID: <87cza65laa.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20221101163042.942023-1-markyacoub@chromium.org>

On Tue, 01 Nov 2022 09:30:42 -0700, Mark Yacoub wrote:
> +static void edid_stress_resolution(data_t *data, struct chamelium_port *port,
> +				   monitor_edid edids_list[],
> +				   size_t edids_list_len)
> +{
> +	int i;
> +	struct chamelium *chamelium = data->chamelium;
> +	struct udev_monitor *mon = igt_watch_uevents();
> +
> +	for (i = 0; i < edids_list_len; ++i) {
> +		struct chamelium_edid *chamelium_edid;
> +		drmModeModeInfo mode;
> +		struct igt_fb fb = { 0 };
> +		igt_output_t *output;
> +		enum pipe pipe;
> +		bool is_video_stable;
> +		int screen_res_w, screen_res_h;
> +
> +		monitor_edid *monitor_edid = &edids_list[i];

No warnings please.

../tests/chamelium/kms_chamelium.c: In function ‘edid_stress_resolution’:
../tests/chamelium/kms_chamelium.c:2570:31: warning: declaration of ‘monitor_edid’ shadows a global declaration [-Wshadow]
 2570 |                 monitor_edid *monitor_edid = &edids_list[i];
      |                               ^~~~~~~~~~~~
In file included from ../lib/monitor_edids/dp_edids.h:15,
                 from ../tests/chamelium/kms_chamelium.c:33:
../lib/monitor_edids/monitor_edids_helper.h:25:3: note: shadowed declaration is here
   25 | } monitor_edid;
      |   ^~~~~~~~~~~~

  reply	other threads:[~2022-11-01 23:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-01 14:37 [igt-dev] [PATCH v2] [NEW]kms_chamelium: Add new EDID stress resolution test Mark Yacoub
2022-11-01 15:16 ` [igt-dev] ✗ GitLab.Pipeline: warning for kms_chamelium: Add new EDID stress resolution test (rev3) Patchwork
2022-11-01 15:37 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2022-11-01 16:30 ` [igt-dev] [PATCH] [NEW]kms_chamelium: Add new EDID stress resolution test Mark Yacoub
2022-11-01 23:04   ` Dixit, Ashutosh [this message]
2022-11-01 17:41 ` [igt-dev] ✓ Fi.CI.BAT: success for kms_chamelium: Add new EDID stress resolution test (rev4) Patchwork
2022-11-01 20:19 ` [igt-dev] ✗ Fi.CI.IGT: failure for kms_chamelium: Add new EDID stress resolution test (rev3) Patchwork
2022-11-01 20:38 ` [igt-dev] ✓ Fi.CI.IGT: success for kms_chamelium: Add new EDID stress resolution test (rev4) Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2022-10-28 16:42 [igt-dev] [PATCH] [NEW]kms_chamelium: Add new EDID stress resolution test Mark Yacoub
2022-10-31 11:13 ` Petri Latvala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cza65laa.wl-ashutosh.dixit@intel.com \
    --to=ashutosh.dixit@intel.com \
    --cc=amstan@chromium.org \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=ihf@google.com \
    --cc=kalin@google.com \
    --cc=khaled.almahallawy@intel.com \
    --cc=markyacoub@chromium.org \
    --cc=markyacoub@google.com \
    --cc=matthewtlam@google.com \
    --cc=petri.latvala@intel.com \
    --cc=robdclark@chromium.org \
    --cc=seanpaul@chromium.org \
    --cc=vsuley@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.