All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonas Bernoulli <jonas@bernoul.li>
To: git@vger.kernel.org
Subject: "submodule foreach" much slower than removed "submodule--helper --list"
Date: Sat, 15 Oct 2022 18:50:36 +0200	[thread overview]
Message-ID: <87czatrpyb.fsf@bernoul.li> (raw)

In v2.38.0 (31955475d1c283120d5d84247eb3fd55d9f5fdd9)
"submodule--helper --list" was remove because

> We're not getting anything useful from the "list | cut -f2"
> invocation that we couldn't get from "foreach 'echo $sm_path'".

But we get speed (this is with about one hundred modules):

$ time git submodule foreach -q 'echo $sm_path' > /dev/null

real    0m0.585s
user    0m0.413s
sys     0m0.182s

$ time git submodule--helper list > /dev/null

real    0m0.008s
user    0m0.004s
sys     0m0.004s

Please consider restoring this subcommand or providing something
equivalent that is just as fast.

     Thanks,
     Jonas

             reply	other threads:[~2022-10-15 16:56 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-15 16:50 Jonas Bernoulli [this message]
2022-10-15 17:34 ` "submodule foreach" much slower than removed "submodule--helper --list" Jonas Bernoulli
2022-10-15 18:13   ` Jeff King
2022-10-15 18:16     ` Junio C Hamano
2022-10-15 18:23       ` Jeff King
2022-10-15 18:37         ` Junio C Hamano
2022-10-15 22:40     ` Junio C Hamano
2022-10-17 17:02       ` Jeff King
2022-11-07 11:01       ` Matti Möll
2022-11-08  2:50         ` Taylor Blau
2022-11-08  3:37           ` Ævar Arnfjörð Bjarmason
2022-10-17 16:50   ` Ævar Arnfjörð Bjarmason
2022-10-17 17:46     ` Jeff King
2022-10-21 14:58     ` Jonas Bernoulli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87czatrpyb.fsf@bernoul.li \
    --to=jonas@bernoul.li \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.