From: Juan Quintela <quintela@redhat.com>
To: Fiona Ebner <f.ebner@proxmox.com>
Cc: qemu-devel@nongnu.org, dgilbert@redhat.com, berrange@redhat.com
Subject: Re: [PATCH v2] migration/channel-block: fix return value for qio_channel_block_{readv,writev}
Date: Fri, 14 Oct 2022 13:49:58 +0200 [thread overview]
Message-ID: <87czauwro9.fsf@secure.mitica> (raw)
In-Reply-To: <20221013084100.57740-1-f.ebner@proxmox.com> (Fiona Ebner's message of "Thu, 13 Oct 2022 10:41:00 +0200")
Fiona Ebner <f.ebner@proxmox.com> wrote:
> in the error case. The documentation in include/io/channel.h states
> that -1 or QIO_CHANNEL_ERR_BLOCK should be returned upon error. Simply
> passing along the return value from the bdrv-functions has the
> potential to confuse the call sides. Non-blocking mode is not
> implemented currently, so -1 it is.
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Queued in migration tree.
next prev parent reply other threads:[~2022-10-14 11:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 8:41 [PATCH v2] migration/channel-block: fix return value for qio_channel_block_{readv, writev} Fiona Ebner
2022-10-14 11:49 ` Juan Quintela [this message]
2022-10-17 9:54 ` Zhang, Chen
2022-10-18 7:01 ` Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czauwro9.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=f.ebner@proxmox.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.