Re: [PATCH v2] ALSA: hda/realtek: Enable 4-speaker output Dell Precision 5570 laptop

[Takashi Iwai <tiwai@suse.de>]

On Wed, 14 Sep 2022 11:14:00 +0200,
acheronfail wrote:
> 
> The Dell Precision 5570 uses the same 4-speakers-on-ALC289 just like the
> previous Precision 5560. I replicated that patch onto this one, and can
> confirm that the audio is much better (the woofers are now working);
> I've tested it on my Dell Precision 5570.
> 
> Signed-off-by: Callum Osmotherly <callum.osmotherly@gmail.com>
> 
> ---
> Thanks to Takashi for helping me out with the right formatting!

Glad to hear.  One more thing I forgot to mention, though:
if you keep the name in From field different from Signed-off-by line,
you can embed the From tag into the patch itself, too, so that it's
applied consistently.

That is, a patch text will be:

  From: Callum Osmotherly <callum.osmotherly@gmail.com> 

  The Dell Precision 5570 uses the same 4-speakers-on-ALC289 just like the
  previous Precision 5560. I replicated that patch onto this one, and can
  confirm that the audio is much better (the woofers are now working);
  I've tested it on my Dell Precision 5570.
 
  Signed-off-by: Callum Osmotherly <callum.osmotherly@gmail.com>
 
I already applied this patch with the correction in my side now, so
it's just a hint for the next submission :)


thanks,

Takashi