From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 40CF7ECAAA1 for ; Tue, 30 Aug 2022 10:43:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7F36010E047; Tue, 30 Aug 2022 10:43:26 +0000 (UTC) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3563A10E047; Tue, 30 Aug 2022 10:43:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661856204; x=1693392204; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=1JuE3MlMyluva+oTcotxIb88e/kWe/AXbzFxNtVjZ48=; b=XbHTJVFeRVnNQcBOIvOh1kF00+Os/eenr7cr3Bsqy4NFP73NURXzty6o O9xYFR3mSLbO+11TpjJvCC0V/uns7TGgQmbJO8dCkyZaW2m4071DJ9Juf VxqWfjQ/iq/QH49LzM55a7ayQu0IO3G/0RqsK9PmXqGBE/M7Emim9EvnN RL78TFV4i71Q9TfupDh83y44jIVHfXifiE1qD9A9rMak1M0+B9fRZTdNN GjLMfvYwdluIMG1sgKtSsf8GIXLKoZCkAyihd4+YN3Z8FmhnEB1YFVjlr zTtPIxilzLvyOcMokpLO7FpdVoRXlbYw94oZCPkVF1FF9myx5yEp8VxaG g==; X-IronPort-AV: E=McAfee;i="6500,9779,10454"; a="356857901" X-IronPort-AV: E=Sophos;i="5.93,274,1654585200"; d="scan'208";a="356857901" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2022 03:43:23 -0700 X-IronPort-AV: E=Sophos;i="5.93,274,1654585200"; d="scan'208";a="672807662" Received: from amrabet-mobl.ger.corp.intel.com (HELO localhost) ([10.252.41.211]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2022 03:43:15 -0700 From: Jani Nikula To: Geert Uytterhoeven , Maxime Ripard In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20220728-rpi-analog-tv-properties-v2-0-459522d653a7@cerno.tech> <20220728-rpi-analog-tv-properties-v2-14-459522d653a7@cerno.tech> Date: Tue, 30 Aug 2022 13:43:07 +0300 Message-ID: <87czcidnb8.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Intel-gfx] [PATCH v2 14/41] drm/modes: Move named modes parsing to a separate function X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Karol Herbst , David Airlie , Nouveau Dev , DRI Development , Phil Elwell , Emma Anholt , Samuel Holland , Jernej Skrabec , Chen-Yu Tsai , Ben Skeggs , linux-sunxi@lists.linux.dev, Thomas Zimmermann , Intel Graphics Development , Maxime Ripard , Rodrigo Vivi , Daniel Vetter , Linux ARM , Dom Cobley , Dave Stevenson , Linux Kernel Mailing List , Mateusz Kwiatkowski , Noralf =?utf-8?Q?Tr=C3=B8nnes?= , Philipp Zabel Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 30 Aug 2022, Geert Uytterhoeven wrote: > On Mon, Aug 29, 2022 at 3:13 PM Maxime Ripard wrote: >> +#define STR_STRICT_EQ(str, len, cmp) \ >> + ((strlen(cmp) == len) && !strncmp(str, cmp, len)) > > This is not part of the move, but newly added. The same construct is also duplicated elsewhere in the series, and I kept being confused by it. The above is precisely the same as: str_has_prefix(str, cmp) == len Which is more intuitive and available in string.h instead of being a local duplicate. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E60627C for ; Tue, 30 Aug 2022 10:43:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661856203; x=1693392203; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=1JuE3MlMyluva+oTcotxIb88e/kWe/AXbzFxNtVjZ48=; b=ZPqfZqh9kdZL496Ur0JCehwqJi1G0tc2+qDvcTklIgdLwBpDkPOOgYhf 5M5ipuSPOnFQHg9tm8m1AFYeSB6xsbvGB6D+mhKHBhMxDAsRouB1Yv3u/ Pm56NHCxBkJW/MhGnX5vC/AEKCh6PF9uUiuzgtcD7zdOvcN4r0xG58NNA qJMQKaSsiMV11gO9bcBzeqTYe8rtco1D346odGxS2KjJbiAAMj8pLAbyc 8kd7FpnV68i2gAgJtyqfXWIa/nI3oKagteHhWEW0u7ldRYAen8NBhkswf r1HqJK4Mo/JuJ4StBZnG8U5hH8NC/EUo5HxdE1ZHbxCLaq6NHpPwZJnDP Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10454"; a="275542467" X-IronPort-AV: E=Sophos;i="5.93,274,1654585200"; d="scan'208";a="275542467" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2022 03:43:23 -0700 X-IronPort-AV: E=Sophos;i="5.93,274,1654585200"; d="scan'208";a="672807662" Received: from amrabet-mobl.ger.corp.intel.com (HELO localhost) ([10.252.41.211]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2022 03:43:15 -0700 From: Jani Nikula To: Geert Uytterhoeven , Maxime Ripard Cc: Maxime Ripard , Ben Skeggs , David Airlie , Chen-Yu Tsai , Thomas Zimmermann , Lyude Paul , Philipp Zabel , Maarten Lankhorst , Rodrigo Vivi , Tvrtko Ursulin , Jernej Skrabec , Samuel Holland , Karol Herbst , Noralf =?utf-8?Q?Tr=C3=B8nnes?= , Emma Anholt , Daniel Vetter , Joonas Lahtinen , Hans de Goede , Linux ARM , Phil Elwell , Intel Graphics Development , Dave Stevenson , DRI Development , Dom Cobley , Linux Kernel Mailing List , Nouveau Dev , linux-sunxi@lists.linux.dev, Mateusz Kwiatkowski Subject: Re: [PATCH v2 14/41] drm/modes: Move named modes parsing to a separate function In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20220728-rpi-analog-tv-properties-v2-0-459522d653a7@cerno.tech> <20220728-rpi-analog-tv-properties-v2-14-459522d653a7@cerno.tech> Date: Tue, 30 Aug 2022 13:43:07 +0300 Message-ID: <87czcidnb8.fsf@intel.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Tue, 30 Aug 2022, Geert Uytterhoeven wrote: > On Mon, Aug 29, 2022 at 3:13 PM Maxime Ripard wrote: >> +#define STR_STRICT_EQ(str, len, cmp) \ >> + ((strlen(cmp) == len) && !strncmp(str, cmp, len)) > > This is not part of the move, but newly added. The same construct is also duplicated elsewhere in the series, and I kept being confused by it. The above is precisely the same as: str_has_prefix(str, cmp) == len Which is more intuitive and available in string.h instead of being a local duplicate. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 72F9DECAAD4 for ; Tue, 30 Aug 2022 10:43:39 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 677EC10E054; Tue, 30 Aug 2022 10:43:29 +0000 (UTC) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3563A10E047; Tue, 30 Aug 2022 10:43:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661856204; x=1693392204; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=1JuE3MlMyluva+oTcotxIb88e/kWe/AXbzFxNtVjZ48=; b=XbHTJVFeRVnNQcBOIvOh1kF00+Os/eenr7cr3Bsqy4NFP73NURXzty6o O9xYFR3mSLbO+11TpjJvCC0V/uns7TGgQmbJO8dCkyZaW2m4071DJ9Juf VxqWfjQ/iq/QH49LzM55a7ayQu0IO3G/0RqsK9PmXqGBE/M7Emim9EvnN RL78TFV4i71Q9TfupDh83y44jIVHfXifiE1qD9A9rMak1M0+B9fRZTdNN GjLMfvYwdluIMG1sgKtSsf8GIXLKoZCkAyihd4+YN3Z8FmhnEB1YFVjlr zTtPIxilzLvyOcMokpLO7FpdVoRXlbYw94oZCPkVF1FF9myx5yEp8VxaG g==; X-IronPort-AV: E=McAfee;i="6500,9779,10454"; a="356857901" X-IronPort-AV: E=Sophos;i="5.93,274,1654585200"; d="scan'208";a="356857901" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2022 03:43:23 -0700 X-IronPort-AV: E=Sophos;i="5.93,274,1654585200"; d="scan'208";a="672807662" Received: from amrabet-mobl.ger.corp.intel.com (HELO localhost) ([10.252.41.211]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2022 03:43:15 -0700 From: Jani Nikula To: Geert Uytterhoeven , Maxime Ripard In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20220728-rpi-analog-tv-properties-v2-0-459522d653a7@cerno.tech> <20220728-rpi-analog-tv-properties-v2-14-459522d653a7@cerno.tech> Date: Tue, 30 Aug 2022 13:43:07 +0300 Message-ID: <87czcidnb8.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Nouveau] [PATCH v2 14/41] drm/modes: Move named modes parsing to a separate function X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Nouveau Dev , Joonas Lahtinen , DRI Development , Phil Elwell , Emma Anholt , Samuel Holland , Jernej Skrabec , Chen-Yu Tsai , Ben Skeggs , linux-sunxi@lists.linux.dev, Intel Graphics Development , Maarten Lankhorst , Maxime Ripard , Hans de Goede , Rodrigo Vivi , Daniel Vetter , Linux ARM , Tvrtko Ursulin , Dom Cobley , Linux Kernel Mailing List , Mateusz Kwiatkowski , Noralf =?utf-8?Q?Tr=C3=B8nnes?= , Philipp Zabel Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" On Tue, 30 Aug 2022, Geert Uytterhoeven wrote: > On Mon, Aug 29, 2022 at 3:13 PM Maxime Ripard wrote: >> +#define STR_STRICT_EQ(str, len, cmp) \ >> + ((strlen(cmp) == len) && !strncmp(str, cmp, len)) > > This is not part of the move, but newly added. The same construct is also duplicated elsewhere in the series, and I kept being confused by it. The above is precisely the same as: str_has_prefix(str, cmp) == len Which is more intuitive and available in string.h instead of being a local duplicate. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 67F2CECAAA1 for ; Tue, 30 Aug 2022 11:00:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=m2dnJ/JQHOnRfEDTyJ/PmbRnN1aQb8JRabT8mHKBGyk=; b=ugLNjWTRro2EyI sccqbMHjc8x+ijEAb16xZ8z0lhLD7LDt7GbUa5Mbre6HxGdv0Qlnrn1v9e8lwagOibrMa2xYUehud 9g0G+OjDvNldpBfX2hULMRnBiRiiVJ76ljyVP3/GAE7jfyQOuuwTJJAvzhOi4IjMxdG7QDek9even aUxiSnTnM69lnXXwDFmW4bVEScDctLvcbjgIoBmI3aj7coCjAfMVOjxX1hQEyJzAIyPfseVvrTKxO A/Rk5+6FklFfU5juoNwUPuEwYjNOFG3fa7mHMh0Nnb17PAQmh2BUUA9B0+uXIaQ8DAMBbUE5WwfFb 4V6ZeRLSyD7mmsnIUsJQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oSypa-00GIKT-SC; Tue, 30 Aug 2022 10:50:54 +0000 Received: from mga14.intel.com ([192.55.52.115]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oSyiN-00GFoy-Dy for linux-arm-kernel@lists.infradead.org; Tue, 30 Aug 2022 10:43:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661856207; x=1693392207; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=1JuE3MlMyluva+oTcotxIb88e/kWe/AXbzFxNtVjZ48=; b=g6nIWyvyHyqwpIFY31hW8o2kK6Kxttpagr/ftFaG/IL+RgIBvZ9CxNv4 1rHL49yq16oc7gJ4aVtHEtuEt+PdLimtpL61iuzVAZr0F12b/MITV00uC ZfJA7XcbPW4sx9cfuB35wQrnWfsyKloKknO/xVEJ5kE6BFCA6SxcUqnbJ mQV6EZ2ptNytjqQbO49vxQ04aM0U9z9L4KTpUOlB/+m4xSC4cTuFjAD8O 0RBlNOofLQWQ+g8YMLREKCVZCaWJw5WAanogOVidzQ/jZd5PxVs+14gfS cK/KClayiwP746mTtubJI5+hSILctIYJp+oc2j/UWLFGGVMB6rHLyVFq6 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10454"; a="295143525" X-IronPort-AV: E=Sophos;i="5.93,274,1654585200"; d="scan'208";a="295143525" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2022 03:43:23 -0700 X-IronPort-AV: E=Sophos;i="5.93,274,1654585200"; d="scan'208";a="672807662" Received: from amrabet-mobl.ger.corp.intel.com (HELO localhost) ([10.252.41.211]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2022 03:43:15 -0700 From: Jani Nikula To: Geert Uytterhoeven , Maxime Ripard Cc: Maxime Ripard , Ben Skeggs , David Airlie , Chen-Yu Tsai , Thomas Zimmermann , Lyude Paul , Philipp Zabel , Maarten Lankhorst , Rodrigo Vivi , Tvrtko Ursulin , Jernej Skrabec , Samuel Holland , Karol Herbst , Noralf =?utf-8?Q?Tr=C3=B8nnes?= , Emma Anholt , Daniel Vetter , Joonas Lahtinen , Hans de Goede , Linux ARM , Phil Elwell , Intel Graphics Development , Dave Stevenson , DRI Development , Dom Cobley , Linux Kernel Mailing List , Nouveau Dev , linux-sunxi@lists.linux.dev, Mateusz Kwiatkowski Subject: Re: [PATCH v2 14/41] drm/modes: Move named modes parsing to a separate function In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20220728-rpi-analog-tv-properties-v2-0-459522d653a7@cerno.tech> <20220728-rpi-analog-tv-properties-v2-14-459522d653a7@cerno.tech> Date: Tue, 30 Aug 2022 13:43:07 +0300 Message-ID: <87czcidnb8.fsf@intel.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220830_034327_593936_01393E56 X-CRM114-Status: GOOD ( 10.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 30 Aug 2022, Geert Uytterhoeven wrote: > On Mon, Aug 29, 2022 at 3:13 PM Maxime Ripard wrote: >> +#define STR_STRICT_EQ(str, len, cmp) \ >> + ((strlen(cmp) == len) && !strncmp(str, cmp, len)) > > This is not part of the move, but newly added. The same construct is also duplicated elsewhere in the series, and I kept being confused by it. The above is precisely the same as: str_has_prefix(str, cmp) == len Which is more intuitive and available in string.h instead of being a local duplicate. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ADB6BC0502A for ; Tue, 30 Aug 2022 10:43:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C2EBD10E051; Tue, 30 Aug 2022 10:43:28 +0000 (UTC) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3563A10E047; Tue, 30 Aug 2022 10:43:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661856204; x=1693392204; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=1JuE3MlMyluva+oTcotxIb88e/kWe/AXbzFxNtVjZ48=; b=XbHTJVFeRVnNQcBOIvOh1kF00+Os/eenr7cr3Bsqy4NFP73NURXzty6o O9xYFR3mSLbO+11TpjJvCC0V/uns7TGgQmbJO8dCkyZaW2m4071DJ9Juf VxqWfjQ/iq/QH49LzM55a7ayQu0IO3G/0RqsK9PmXqGBE/M7Emim9EvnN RL78TFV4i71Q9TfupDh83y44jIVHfXifiE1qD9A9rMak1M0+B9fRZTdNN GjLMfvYwdluIMG1sgKtSsf8GIXLKoZCkAyihd4+YN3Z8FmhnEB1YFVjlr zTtPIxilzLvyOcMokpLO7FpdVoRXlbYw94oZCPkVF1FF9myx5yEp8VxaG g==; X-IronPort-AV: E=McAfee;i="6500,9779,10454"; a="356857901" X-IronPort-AV: E=Sophos;i="5.93,274,1654585200"; d="scan'208";a="356857901" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2022 03:43:23 -0700 X-IronPort-AV: E=Sophos;i="5.93,274,1654585200"; d="scan'208";a="672807662" Received: from amrabet-mobl.ger.corp.intel.com (HELO localhost) ([10.252.41.211]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2022 03:43:15 -0700 From: Jani Nikula To: Geert Uytterhoeven , Maxime Ripard Subject: Re: [PATCH v2 14/41] drm/modes: Move named modes parsing to a separate function In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20220728-rpi-analog-tv-properties-v2-0-459522d653a7@cerno.tech> <20220728-rpi-analog-tv-properties-v2-14-459522d653a7@cerno.tech> Date: Tue, 30 Aug 2022 13:43:07 +0300 Message-ID: <87czcidnb8.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Karol Herbst , David Airlie , Nouveau Dev , DRI Development , Phil Elwell , Emma Anholt , Samuel Holland , Jernej Skrabec , Chen-Yu Tsai , Ben Skeggs , linux-sunxi@lists.linux.dev, Thomas Zimmermann , Intel Graphics Development , Hans de Goede , Rodrigo Vivi , Linux ARM , Tvrtko Ursulin , Dom Cobley , Dave Stevenson , Linux Kernel Mailing List , Mateusz Kwiatkowski , Noralf =?utf-8?Q?Tr=C3=B8nnes?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, 30 Aug 2022, Geert Uytterhoeven wrote: > On Mon, Aug 29, 2022 at 3:13 PM Maxime Ripard wrote: >> +#define STR_STRICT_EQ(str, len, cmp) \ >> + ((strlen(cmp) == len) && !strncmp(str, cmp, len)) > > This is not part of the move, but newly added. The same construct is also duplicated elsewhere in the series, and I kept being confused by it. The above is precisely the same as: str_has_prefix(str, cmp) == len Which is more intuitive and available in string.h instead of being a local duplicate. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center