From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6688DC2BB41 for ; Thu, 18 Aug 2022 07:53:11 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 99DA8823; Thu, 18 Aug 2022 09:52:19 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 99DA8823 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1660809189; bh=NIsedd6pshshfRS6H8nefp33Iyva6S/0RygeQDFS1/s=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=YGPnew9FmZ9jNhbrPpraGEp/eJYtbzszmRwMa3U0HA93bbVwi5T8t/tksgv+dXqUI CdRJtdEVv2gHZwBY9rdkpykZrvxf3EPTqErcr8pkqPUulXZj5+n8oC9UqDbI8xOwLQ A1Xw46vKcYKf7HyQn0Wi7pfrVqLp8N9r2g6oxHlA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 3CB3AF8013D; Thu, 18 Aug 2022 09:52:19 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 496B3F80430; Thu, 18 Aug 2022 09:52:18 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E0E80F800EE for ; Thu, 18 Aug 2022 09:52:14 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E0E80F800EE Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="gG5BUgA2"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="BPWyzCtJ" Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8F00538DDF; Thu, 18 Aug 2022 07:52:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1660809134; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2CLInFa2NS+aQf9Xvdh1BZlno0kXzHMhezgPE6R2IeA=; b=gG5BUgA2jqL/IsWnc4UURQFB1k0OF65QobwbWHbvPHfmrNKcloGrIu8FPdk/17xYt2+20s 3bN5z9rDyv9lbmPE7qD1RFWv/R1CYg/xzmqiMYDUy9O6U82aMypFgPpi8wi2QNWmqKmWNe O8xsLTarwSLoBjdc0d1e1HInrwUqyNc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1660809134; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2CLInFa2NS+aQf9Xvdh1BZlno0kXzHMhezgPE6R2IeA=; b=BPWyzCtJ6M9IhL87EDheSZdTwJMUlrrZ2doXbEZUVyiNxO9dEIbPyzMZX/dUg/+q4uxteU xyBgRcm2YLa8EbCA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 48609133B5; Thu, 18 Aug 2022 07:52:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id GdPqEK7v/WI/XAAAMHmgww (envelope-from ); Thu, 18 Aug 2022 07:52:14 +0000 Date: Thu, 18 Aug 2022 09:52:13 +0200 Message-ID: <87czcy9efm.wl-tiwai@suse.de> From: Takashi Iwai To: Cezary Rojewski Subject: Re: [RESEND PATCH v2 0/6] ALSA: hda: Unify codec construction In-Reply-To: <20220816111727.3218543-1-cezary.rojewski@intel.com> References: <20220816111727.3218543-1-cezary.rojewski@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, kai.vehmanen@linux.intel.com, pierre-louis.bossart@linux.intel.com, tiwai@suse.com, hdegoede@redhat.com, broonie@kernel.org, amadeuszx.slawinski@linux.intel.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 16 Aug 2022 13:17:21 +0200, Cezary Rojewski wrote: > > A follow up to the recent HDAudio fixes series [1]. Given the recently > reported regression [2], before the page fault occurring on codec > shutdown can be fixed, codec construction procedure needs to be updated > for skylake and sof-intel drivers. Drivers: pci-hda and avs need no > changes - already making use of snd_hda_codec_device_init(). > > As subject touches code used by the sof-driver, additional review has > been conducted on thesofproject/linux [3]. > > Changes in v2: > > - dropped snd_hda_ext_core <-> snd_hda_codec dependency by calling > snd_hda_codec_device_init() directly in skylake and sof drivers probe > enumeration routines, as suggested by Takashi > - skylake/sof portion of the change has been split into two separate > patches > > - new functions that aim to replace hdac_ext codec init & exit > functionality are added first - for skylake and sof drivers both > - third patch in the series now combines the "field -> pointer" change > for hdac_hda_priv->codec plus the codec-enumeration adjustments for > skylake and sof drivers > Both above are here to keep git bisect happy, as suggested by Pierre > > [1]: https://lore.kernel.org/alsa-devel/20220706120230.427296-7-cezary.rojewski@intel.com/ > [2]: https://lore.kernel.org/alsa-devel/3c40df55-3aee-1e08-493b-7b30cd84dc00@linux.intel.com/ > [3]: https://github.com/thesofproject/linux/pull/3775 > > Cezary Rojewski (6): > ASoC: Intel: Skylake: Introduce HDA codec init and exit routines > ASoC: SOF: Intel: Introduce HDA codec init and exit routines > ASoC: Intel: Drop hdac_ext usage for codec device creation > ALSA: hda: Always free codec on the device release > ALSA: hda: Remove codec init and exit routines > ALSA: hda: Fix page fault in snd_hda_codec_shutdown() Applied all patches now to for-next branch. Thanks. Takashi