From: Jani Nikula <jani.nikula@intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v2 00/11] drm/i915: drm/i915/display: split out verification, hw readout and dump from intel_display.c
Date: Fri, 17 Jun 2022 11:57:59 +0300 [thread overview]
Message-ID: <87czf7vf8o.fsf@intel.com> (raw)
In-Reply-To: <Yqr/my9kwkXzvNfz@intel.com>
On Thu, 16 Jun 2022, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Thu, Jun 16, 2022 at 12:48:10PM +0300, Jani Nikula wrote:
>> v2 of [1]. Address review comments, drop crtc state compare move, add hw
>> state readout&sanitization split, and sprinkle some struct
>> drm_i915_private *i915 cleanups on top.
>>
>> BR,
>> Jani.
>>
>> [1] https://patchwork.freedesktop.org/series/105156/
>>
>>
>> Jani Nikula (11):
>> drm/i915/wm: move wm state verification to intel_pm.c
>> drm/i915/dpll: move shared dpll state verification to intel_dpll_mgr.c
>> drm/i915/mpllb: use I915_STATE_WARN() for state mismatch warnings
>> drm/i915/mpllb: move mpllb state check to intel_snps_phy.c
>> drm/i915/display: split out modeset verification code
>> drm/i915/display: split out crtc state dump to a separate file
>> drm/i915/display: change who adds [] around crtc state dump context
>> string
>> drm/i915/display: rename dev_priv -> i915 in crtc state dump
>> drm/i915/display: split out hw state readout and sanitize
>> drm/i915/display: some struct drm_i915_private *i915 conversions
>> drm/i915/display: convert modeset setup to struct drm_i915_private
>> *i915
>
> Series is
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Thanks for the review, pushed everything except patches 9 and 11 which
conflicted, will respin those shortly.
BR,
Jani.
>
>>
>> drivers/gpu/drm/i915/Makefile | 3 +
>> .../drm/i915/display/intel_crtc_state_dump.c | 314 +++
>> .../drm/i915/display/intel_crtc_state_dump.h | 16 +
>> drivers/gpu/drm/i915/display/intel_display.c | 1680 +----------------
>> drivers/gpu/drm/i915/display/intel_display.h | 18 +
>> drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 88 +
>> drivers/gpu/drm/i915/display/intel_dpll_mgr.h | 5 +
>> .../drm/i915/display/intel_modeset_setup.c | 724 +++++++
>> .../drm/i915/display/intel_modeset_setup.h | 15 +
>> .../drm/i915/display/intel_modeset_verify.c | 246 +++
>> .../drm/i915/display/intel_modeset_verify.h | 21 +
>> drivers/gpu/drm/i915/display/intel_snps_phy.c | 43 +
>> drivers/gpu/drm/i915/display/intel_snps_phy.h | 5 +-
>> drivers/gpu/drm/i915/intel_pm.c | 138 +-
>> drivers/gpu/drm/i915/intel_pm.h | 14 +-
>> 15 files changed, 1724 insertions(+), 1606 deletions(-)
>> create mode 100644 drivers/gpu/drm/i915/display/intel_crtc_state_dump.c
>> create mode 100644 drivers/gpu/drm/i915/display/intel_crtc_state_dump.h
>> create mode 100644 drivers/gpu/drm/i915/display/intel_modeset_setup.c
>> create mode 100644 drivers/gpu/drm/i915/display/intel_modeset_setup.h
>> create mode 100644 drivers/gpu/drm/i915/display/intel_modeset_verify.c
>> create mode 100644 drivers/gpu/drm/i915/display/intel_modeset_verify.h
>>
>> --
>> 2.30.2
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2022-06-17 8:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 9:48 [Intel-gfx] [PATCH v2 00/11] drm/i915: drm/i915/display: split out verification, hw readout and dump from intel_display.c Jani Nikula
2022-06-16 9:48 ` [Intel-gfx] [PATCH v2 01/11] drm/i915/wm: move wm state verification to intel_pm.c Jani Nikula
2022-06-16 9:48 ` [Intel-gfx] [PATCH v2 02/11] drm/i915/dpll: move shared dpll state verification to intel_dpll_mgr.c Jani Nikula
2022-06-16 9:48 ` [Intel-gfx] [PATCH v2 03/11] drm/i915/mpllb: use I915_STATE_WARN() for state mismatch warnings Jani Nikula
2022-06-16 9:48 ` [Intel-gfx] [PATCH v2 04/11] drm/i915/mpllb: move mpllb state check to intel_snps_phy.c Jani Nikula
2022-06-16 9:48 ` [Intel-gfx] [PATCH v2 05/11] drm/i915/display: split out modeset verification code Jani Nikula
2022-06-16 9:48 ` [Intel-gfx] [PATCH v2 06/11] drm/i915/display: split out crtc state dump to a separate file Jani Nikula
2022-06-16 9:48 ` [Intel-gfx] [PATCH v2 07/11] drm/i915/display: change who adds [] around crtc state dump context string Jani Nikula
2022-06-16 9:48 ` [Intel-gfx] [PATCH v2 08/11] drm/i915/display: rename dev_priv -> i915 in crtc state dump Jani Nikula
2022-06-16 9:48 ` [Intel-gfx] [PATCH v2 09/11] drm/i915/display: split out hw state readout and sanitize Jani Nikula
2022-06-16 9:48 ` [Intel-gfx] [PATCH v2 10/11] drm/i915/display: some struct drm_i915_private *i915 conversions Jani Nikula
2022-06-16 9:48 ` [Intel-gfx] [PATCH v2 11/11] drm/i915/display: convert modeset setup to struct drm_i915_private *i915 Jani Nikula
2022-06-16 10:02 ` [Intel-gfx] [PATCH v2 00/11] drm/i915: drm/i915/display: split out verification, hw readout and dump from intel_display.c Ville Syrjälä
2022-06-17 8:57 ` Jani Nikula [this message]
2022-06-16 13:03 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-06-16 13:03 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-06-16 13:24 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-06-16 18:54 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czf7vf8o.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.