All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Simon Ser <contact@emersion.fr>
Cc: David Airlie <airlied@linux.ie>, Sam Ravnborg <sam@ravnborg.org>,
	Claudio Suarez <cssk@net-c.es>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: change logs to print connectors in the form CONNECTOR:id:name
Date: Mon, 15 Nov 2021 12:38:43 +0200	[thread overview]
Message-ID: <87czn13dqk.fsf@intel.com> (raw)
In-Reply-To: <FA_pOwZDBfWW7NDxnHcCdMMqwbgstLNzftE9m4Dgtyewq8lYjHNSsdBZWpO_ULCLt2hCO0SVW5xku_qcEghQMtawUVdbmQeu7c4hBtg19pQ=@emersion.fr>

On Mon, 15 Nov 2021, Simon Ser <contact@emersion.fr> wrote:
> On Monday, November 15th, 2021 at 11:22, Jani Nikula <jani.nikula@linux.intel.com> wrote:
>
>> - Adding drm_dbg_connector() which would take drm_connector as context,
>>   and do drm_dbg_kms() with the above prefix.
>
> This wouldn't work great in case multiple connectors/planes/etc are involved,
> or when drm_dbg_atomic() is used.

That's a good point, though you could still roll those cases manually.

It's also misleading as otherwise drm_dbg_* are categories that can be
enabled/disabled via drm.debug.

Again, just musing here.

BR,
Jani.





-- 
Jani Nikula, Intel Open Source Graphics Center

  reply	other threads:[~2021-11-15 10:38 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-13 19:27 [PATCH] drm: change logs to print connectors in the form CONNECTOR:id:name Claudio Suarez
2021-11-13 20:39 ` Sam Ravnborg
2021-11-14 17:34   ` Claudio Suarez
2021-11-15 10:24     ` Jani Nikula
2021-11-15 19:40       ` Claudio Suarez
2021-11-15 20:17         ` Jani Nikula
2021-11-16 16:55           ` Claudio Suarez
2021-11-18  3:41         ` jim.cromie
2021-11-14 17:22 ` Claudio Suarez
2021-11-14 17:25 ` Claudio Suarez
2021-11-15 10:22 ` Jani Nikula
2021-11-15 10:24   ` Simon Ser
2021-11-15 10:38     ` Jani Nikula [this message]
2021-11-15 19:02   ` Claudio Suarez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87czn13dqk.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=airlied@linux.ie \
    --cc=contact@emersion.fr \
    --cc=cssk@net-c.es \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.