From: Juan Quintela <quintela@redhat.com>
To: Lukas Straub <lukasstraub2@web.de>
Cc: Leonardo Bras Soares Passos <lsoaresp@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>, Peter Xu <peterx@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH for 6.1] multifd: Unconditionally unregister yank function
Date: Thu, 09 Sep 2021 08:34:49 +0200 [thread overview]
Message-ID: <87czpicl4m.fsf@secure.mitica> (raw)
In-Reply-To: <20210804212632.77221bcf@gecko.fritz.box> (Lukas Straub's message of "Wed, 4 Aug 2021 21:26:32 +0200")
Lukas Straub <lukasstraub2@web.de> wrote:
> Unconditionally unregister yank function in multifd_load_cleanup().
> If it is not unregistered here, it will leak and cause a crash
> in yank_unregister_instance(). Now if the ioc is still in use
> afterwards, it will only lead to qemu not being able to recover
> from a hang related to that ioc.
>
> After checking the code, i am pretty sure that ref is always 1
> when arriving here. So all this currently does is remove the
> unneeded check.
>
> Signed-off-by: Lukas Straub <lukasstraub2@web.de>
Reviewed-by: Juan Quintela <quintela@redhat.com>
prev parent reply other threads:[~2021-09-09 7:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 19:26 [PATCH for 6.1] multifd: Unconditionally unregister yank function Lukas Straub
2021-08-04 19:39 ` Peter Xu
2021-08-04 20:13 ` Lukas Straub
2021-09-01 15:48 ` Lukas Straub
2021-09-09 6:34 ` Juan Quintela [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czpicl4m.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lsoaresp@redhat.com \
--cc=lukasstraub2@web.de \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.