From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D008C48BDF for ; Fri, 18 Jun 2021 08:01:36 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4B25661184 for ; Fri, 18 Jun 2021 08:01:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B25661184 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=axtens.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4G5rwZ5MW1z3c57 for ; Fri, 18 Jun 2021 18:01:34 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=axtens.net header.i=@axtens.net header.a=rsa-sha256 header.s=google header.b=K2YfIhhA; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=axtens.net (client-ip=2607:f8b0:4864:20::52a; helo=mail-pg1-x52a.google.com; envelope-from=dja@axtens.net; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=axtens.net header.i=@axtens.net header.a=rsa-sha256 header.s=google header.b=K2YfIhhA; dkim-atps=neutral Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4G5rw51fk4z306M for ; Fri, 18 Jun 2021 18:01:06 +1000 (AEST) Received: by mail-pg1-x52a.google.com with SMTP id e33so7156867pgm.3 for ; Fri, 18 Jun 2021 01:01:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axtens.net; s=google; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=q8VzHewpZe79pEmvix8QtaPFn2S5lJz4nZ38GYVSp1g=; b=K2YfIhhAMz+k3GXUUbKkMGSHD/j3AgeGpWrQkQL5jrlzpBU8BD5+WC2JLkzkt2llR5 3X9bdGn5XASN+cN0AnLHbpLiWfmyojWqHGAmW/GxYVQVaJrpHjn0KprSodWIKWZ/6xS5 OOsIoVScro/sWIpLB7p4STvyHlcCWagKCGdlg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=q8VzHewpZe79pEmvix8QtaPFn2S5lJz4nZ38GYVSp1g=; b=Y8jex/S/Q5NQwDr1nJL4t7Z71EzOUtf5IekTQf4ChNGSz3QwZVNBZy7DO2IPjGu2FD emJobQkBKyQAEb4sziMS5oXdT+tNgsU8oqMP4xnjBadijWyBdQDpU7CKRiEcwKANIRGX xarmrdZeSWqUTF4lBFqyX0CEN6BAg16bF3GP3SLdcnaQZdtjPqECcQalmt1j5YpZ/a38 dtK75IBl5AZ9dFwWZRwImlyx8qXA9xxjpu1Krp8R3zc64OqgExfCfEMxC6pZajpgigaT WuUKrtLA6ylPfxHvAeiRlHOwK0CEBvnHndk9V+ilHF2h46o7bLFyOHXmoqKtXXk8cdFe ZMMA== X-Gm-Message-State: AOAM532SRUsNTWtJxQk+bp2V7o39nKNwVRsQCYh1GcYj2/WVGwnIJ4En 4hef6/kVjzn8+Uh3eVd9M0yPKcDQAAiojN7j X-Google-Smtp-Source: ABdhPJwWZrEkq+tCSPBJbFhpklPxtoQ7coobU7qFXVYhmQlUEdhuP+YK6IVKVG/zU9+ghAuWfPbgFQ== X-Received: by 2002:a63:f10b:: with SMTP id f11mr8792367pgi.203.1624003263723; Fri, 18 Jun 2021 01:01:03 -0700 (PDT) Received: from localhost ([120.17.188.88]) by smtp.gmail.com with ESMTPSA id 18sm7161695pfx.71.2021.06.18.01.01.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Jun 2021 01:01:03 -0700 (PDT) From: Daniel Axtens To: Jordan Niethe , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 4/4] powerpc: Enable KFENCE on BOOK3S/64 In-Reply-To: <20210517061658.194708-5-jniethe5@gmail.com> References: <20210517061658.194708-1-jniethe5@gmail.com> <20210517061658.194708-5-jniethe5@gmail.com> Date: Fri, 18 Jun 2021 18:00:59 +1000 Message-ID: <87czsjsitg.fsf@dja-thinkpad.axtens.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jordan Niethe , npiggin@gmail.com, aneesh.kumar@linux.ibm.com Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" > +#ifdef CONFIG_PPC64 > +static inline bool kfence_protect_page(unsigned long addr, bool protect) > +{ > + struct page *page; > + > + page = virt_to_page(addr); > + if (protect) > + __kernel_map_pages(page, 1, 0); > + else > + __kernel_map_pages(page, 1, 1); I lose track of the type conversions and code conventions involved, but can we do something like __kernel_map_pages(page, 1, !!protect)? Apart from that, this seems good. Kind regards, Daniel