From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAFCFC433B4 for ; Wed, 7 Apr 2021 11:11:49 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D463861363 for ; Wed, 7 Apr 2021 11:11:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D463861363 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4FFhYH2YP7z30HW for ; Wed, 7 Apr 2021 21:11:47 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=maz@kernel.org; receiver=) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4FFhXx003hz302b for ; Wed, 7 Apr 2021 21:11:28 +1000 (AEST) Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BB8586128D; Wed, 7 Apr 2021 11:11:24 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lU65i-0063jU-IS; Wed, 07 Apr 2021 12:11:22 +0100 Date: Wed, 07 Apr 2021 12:11:21 +0100 Message-ID: <87czv6pcx2.wl-maz@kernel.org> From: Marc Zyngier To: Jonathan =?UTF-8?B?TmV1c2Now6RmZXI=?= Subject: Re: [PATCH v2 06/10] irqchip: Add driver for WPCM450 interrupt controller In-Reply-To: <20210406120921.2484986-7-j.neuschaefer@gmx.net> References: <20210406120921.2484986-1-j.neuschaefer@gmx.net> <20210406120921.2484986-7-j.neuschaefer@gmx.net> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: j.neuschaefer@gmx.net, openbmc@lists.ozlabs.org, tmaimon77@gmail.com, joel@jms.id.au, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, avifishman70@gmail.com, tali.perry1@gmail.com, venture@google.com, yuenn@google.com, benjaminfair@google.com, linux@armlinux.org.uk, tglx@linutronix.de X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Tomer Maimon , Avi Fishman , Patrick Venture , openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org, Tali Perry , Russell King , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Benjamin Fair Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Tue, 06 Apr 2021 13:09:17 +0100, Jonathan Neusch=C3=A4fer wrote: >=20 > The WPCM450 AIC ("Advanced Interrupt Controller") is the interrupt > controller found in the Nuvoton WPCM450 SoC and other Winbond/Nuvoton > SoCs. >=20 > The list of registers if based on the AMI vendor kernel and the > Nuvoton W90N745 datasheet. >=20 > Although the hardware supports other interrupt modes, the driver only > supports high-level interrupts at the moment, because other modes could > not be tested so far. >=20 > Signed-off-by: Jonathan Neusch=C3=A4fer > --- >=20 > v2: > - Rename IRQS macro to AIC_NUM_IRQS > - Fix IRQ range check > - Use linux/printk.h header instead of linux/console.h > - Add AIC_SCR_PRIORITY_MASK constant > - Add missing register descriptions > - Remove superfluous printk about IRQ flow type mismatch > - Use BIT() macro > - Rename _ack function to _eoi for accuracy, and use handle_fasteoi_irq > --- > arch/arm/mach-npcm/Kconfig | 1 + > drivers/irqchip/Kconfig | 6 ++ > drivers/irqchip/Makefile | 1 + > drivers/irqchip/irq-wpcm450-aic.c | 161 ++++++++++++++++++++++++++++++ > 4 files changed, 169 insertions(+) > create mode 100644 drivers/irqchip/irq-wpcm450-aic.c >=20 > diff --git a/arch/arm/mach-npcm/Kconfig b/arch/arm/mach-npcm/Kconfig > index 658c8efb4ca14..a71cf1d189ae5 100644 > --- a/arch/arm/mach-npcm/Kconfig > +++ b/arch/arm/mach-npcm/Kconfig > @@ -10,6 +10,7 @@ config ARCH_WPCM450 > bool "Support for WPCM450 BMC (Hermon)" > depends on ARCH_MULTI_V5 > select CPU_ARM926T > + select WPCM450_AIC > select NPCM7XX_TIMER > help > General support for WPCM450 BMC (Hermon). I can't take this patch with this particular hunk, as I don't have this file in my tree. I can either drop this line, or delay the merging of this patch to a later point in time. The driver otherwise looks ready. Thanks, M. --=20 Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B0FAC433B4 for ; Wed, 7 Apr 2021 11:13:38 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 86B7861363 for ; Wed, 7 Apr 2021 11:13:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 86B7861363 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Subject:Cc:To: From:Message-ID:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PBnVgmgaWCMzYUxXbbrYaeA7QdBW8LWzbexlD9a+h1s=; b=bFmeYO4mqw2CWVMI/+1MRFycy fudqEeLlahDYMVov4JtUj+9repgXzMB9GHdthW8QCvWXJC6y0qd69r1hkAJ+sg8YTwvdLCeKNW3FX oJ0fMD0TgkSSDVGi3kAv1fLSe1X653+FwwlZpKYwUxGAEYxR2LqwQoZHuAhgTqPX6ffm5h5Xy54bE SmRVKD9+hFjSgQaRDLa0jcCZFHrd3ApQZPkRkoxj+sZoCQrsC7cpy/X0Qxa2kD2jNpZzq2EPIL2Nn UQw7B06SQ4MvPZqQ2Q8sVL4SE1Lci/+1sqxQIu1ekSlzHaimmlecWQmUuJvD2nRgIHwZn5qR25GIY mbCHGey/A==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lU65u-004onG-FM; Wed, 07 Apr 2021 11:11:34 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lU65n-004omo-W8 for linux-arm-kernel@lists.infradead.org; Wed, 07 Apr 2021 11:11:30 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BB8586128D; Wed, 7 Apr 2021 11:11:24 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lU65i-0063jU-IS; Wed, 07 Apr 2021 12:11:22 +0100 Date: Wed, 07 Apr 2021 12:11:21 +0100 Message-ID: <87czv6pcx2.wl-maz@kernel.org> From: Marc Zyngier To: Jonathan =?UTF-8?B?TmV1c2Now6RmZXI=?= Cc: openbmc@lists.ozlabs.org, Tomer Maimon , Joel Stanley , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Avi Fishman , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Russell King , Thomas Gleixner Subject: Re: [PATCH v2 06/10] irqchip: Add driver for WPCM450 interrupt controller In-Reply-To: <20210406120921.2484986-7-j.neuschaefer@gmx.net> References: <20210406120921.2484986-1-j.neuschaefer@gmx.net> <20210406120921.2484986-7-j.neuschaefer@gmx.net> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: j.neuschaefer@gmx.net, openbmc@lists.ozlabs.org, tmaimon77@gmail.com, joel@jms.id.au, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, avifishman70@gmail.com, tali.perry1@gmail.com, venture@google.com, yuenn@google.com, benjaminfair@google.com, linux@armlinux.org.uk, tglx@linutronix.de X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210407_121128_454172_00DE548D X-CRM114-Status: GOOD ( 26.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCAwNiBBcHIgMjAyMSAxMzowOToxNyArMDEwMCwKSm9uYXRoYW4gTmV1c2Now6RmZXIg PGoubmV1c2NoYWVmZXJAZ214Lm5ldD4gd3JvdGU6Cj4gCj4gVGhlIFdQQ000NTAgQUlDICgiQWR2 YW5jZWQgSW50ZXJydXB0IENvbnRyb2xsZXIiKSBpcyB0aGUgaW50ZXJydXB0Cj4gY29udHJvbGxl ciBmb3VuZCBpbiB0aGUgTnV2b3RvbiBXUENNNDUwIFNvQyBhbmQgb3RoZXIgV2luYm9uZC9OdXZv dG9uCj4gU29Dcy4KPiAKPiBUaGUgbGlzdCBvZiByZWdpc3RlcnMgaWYgYmFzZWQgb24gdGhlIEFN SSB2ZW5kb3Iga2VybmVsIGFuZCB0aGUKPiBOdXZvdG9uIFc5ME43NDUgZGF0YXNoZWV0Lgo+IAo+ IEFsdGhvdWdoIHRoZSBoYXJkd2FyZSBzdXBwb3J0cyBvdGhlciBpbnRlcnJ1cHQgbW9kZXMsIHRo ZSBkcml2ZXIgb25seQo+IHN1cHBvcnRzIGhpZ2gtbGV2ZWwgaW50ZXJydXB0cyBhdCB0aGUgbW9t ZW50LCBiZWNhdXNlIG90aGVyIG1vZGVzIGNvdWxkCj4gbm90IGJlIHRlc3RlZCBzbyBmYXIuCj4g Cj4gU2lnbmVkLW9mZi1ieTogSm9uYXRoYW4gTmV1c2Now6RmZXIgPGoubmV1c2NoYWVmZXJAZ214 Lm5ldD4KPiAtLS0KPiAKPiB2MjoKPiAtIFJlbmFtZSBJUlFTIG1hY3JvIHRvIEFJQ19OVU1fSVJR Uwo+IC0gRml4IElSUSByYW5nZSBjaGVjawo+IC0gVXNlIGxpbnV4L3ByaW50ay5oIGhlYWRlciBp bnN0ZWFkIG9mIGxpbnV4L2NvbnNvbGUuaAo+IC0gQWRkIEFJQ19TQ1JfUFJJT1JJVFlfTUFTSyBj b25zdGFudAo+IC0gQWRkIG1pc3NpbmcgcmVnaXN0ZXIgZGVzY3JpcHRpb25zCj4gLSBSZW1vdmUg c3VwZXJmbHVvdXMgcHJpbnRrIGFib3V0IElSUSBmbG93IHR5cGUgbWlzbWF0Y2gKPiAtIFVzZSBC SVQoKSBtYWNybwo+IC0gUmVuYW1lIF9hY2sgZnVuY3Rpb24gdG8gX2VvaSBmb3IgYWNjdXJhY3ks IGFuZCB1c2UgaGFuZGxlX2Zhc3Rlb2lfaXJxCj4gLS0tCj4gIGFyY2gvYXJtL21hY2gtbnBjbS9L Y29uZmlnICAgICAgICB8ICAgMSArCj4gIGRyaXZlcnMvaXJxY2hpcC9LY29uZmlnICAgICAgICAg ICB8ICAgNiArKwo+ICBkcml2ZXJzL2lycWNoaXAvTWFrZWZpbGUgICAgICAgICAgfCAgIDEgKwo+ ICBkcml2ZXJzL2lycWNoaXAvaXJxLXdwY200NTAtYWljLmMgfCAxNjEgKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrCj4gIDQgZmlsZXMgY2hhbmdlZCwgMTY5IGluc2VydGlvbnMoKykKPiAg Y3JlYXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMvaXJxY2hpcC9pcnEtd3BjbTQ1MC1haWMuYwo+IAo+ IGRpZmYgLS1naXQgYS9hcmNoL2FybS9tYWNoLW5wY20vS2NvbmZpZyBiL2FyY2gvYXJtL21hY2gt bnBjbS9LY29uZmlnCj4gaW5kZXggNjU4YzhlZmI0Y2ExNC4uYTcxY2YxZDE4OWFlNSAxMDA2NDQK PiAtLS0gYS9hcmNoL2FybS9tYWNoLW5wY20vS2NvbmZpZwo+ICsrKyBiL2FyY2gvYXJtL21hY2gt bnBjbS9LY29uZmlnCj4gQEAgLTEwLDYgKzEwLDcgQEAgY29uZmlnIEFSQ0hfV1BDTTQ1MAo+ICAJ Ym9vbCAiU3VwcG9ydCBmb3IgV1BDTTQ1MCBCTUMgKEhlcm1vbikiCj4gIAlkZXBlbmRzIG9uIEFS Q0hfTVVMVElfVjUKPiAgCXNlbGVjdCBDUFVfQVJNOTI2VAo+ICsJc2VsZWN0IFdQQ000NTBfQUlD Cj4gIAlzZWxlY3QgTlBDTTdYWF9USU1FUgo+ICAJaGVscAo+ICAJICBHZW5lcmFsIHN1cHBvcnQg Zm9yIFdQQ000NTAgQk1DIChIZXJtb24pLgoKSSBjYW4ndCB0YWtlIHRoaXMgcGF0Y2ggd2l0aCB0 aGlzIHBhcnRpY3VsYXIgaHVuaywgYXMgSSBkb24ndCBoYXZlCnRoaXMgZmlsZSBpbiBteSB0cmVl LiBJIGNhbiBlaXRoZXIgZHJvcCB0aGlzIGxpbmUsIG9yIGRlbGF5IHRoZQptZXJnaW5nIG9mIHRo aXMgcGF0Y2ggdG8gYSBsYXRlciBwb2ludCBpbiB0aW1lLgoKVGhlIGRyaXZlciBvdGhlcndpc2Ug bG9va3MgcmVhZHkuCgpUaGFua3MsCgoJTS4KCi0tIApXaXRob3V0IGRldmlhdGlvbiBmcm9tIHRo ZSBub3JtLCBwcm9ncmVzcyBpcyBub3QgcG9zc2libGUuCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdAps aW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVh ZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CCBDC43460 for ; Wed, 7 Apr 2021 11:11:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 28D5E61369 for ; Wed, 7 Apr 2021 11:11:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347301AbhDGLLh convert rfc822-to-8bit (ORCPT ); Wed, 7 Apr 2021 07:11:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:35248 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234044AbhDGLLg (ORCPT ); Wed, 7 Apr 2021 07:11:36 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BB8586128D; Wed, 7 Apr 2021 11:11:24 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lU65i-0063jU-IS; Wed, 07 Apr 2021 12:11:22 +0100 Date: Wed, 07 Apr 2021 12:11:21 +0100 Message-ID: <87czv6pcx2.wl-maz@kernel.org> From: Marc Zyngier To: Jonathan =?UTF-8?B?TmV1c2Now6RmZXI=?= Cc: openbmc@lists.ozlabs.org, Tomer Maimon , Joel Stanley , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Avi Fishman , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Russell King , Thomas Gleixner Subject: Re: [PATCH v2 06/10] irqchip: Add driver for WPCM450 interrupt controller In-Reply-To: <20210406120921.2484986-7-j.neuschaefer@gmx.net> References: <20210406120921.2484986-1-j.neuschaefer@gmx.net> <20210406120921.2484986-7-j.neuschaefer@gmx.net> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: j.neuschaefer@gmx.net, openbmc@lists.ozlabs.org, tmaimon77@gmail.com, joel@jms.id.au, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, avifishman70@gmail.com, tali.perry1@gmail.com, venture@google.com, yuenn@google.com, benjaminfair@google.com, linux@armlinux.org.uk, tglx@linutronix.de X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, 06 Apr 2021 13:09:17 +0100, Jonathan Neuschäfer wrote: > > The WPCM450 AIC ("Advanced Interrupt Controller") is the interrupt > controller found in the Nuvoton WPCM450 SoC and other Winbond/Nuvoton > SoCs. > > The list of registers if based on the AMI vendor kernel and the > Nuvoton W90N745 datasheet. > > Although the hardware supports other interrupt modes, the driver only > supports high-level interrupts at the moment, because other modes could > not be tested so far. > > Signed-off-by: Jonathan Neuschäfer > --- > > v2: > - Rename IRQS macro to AIC_NUM_IRQS > - Fix IRQ range check > - Use linux/printk.h header instead of linux/console.h > - Add AIC_SCR_PRIORITY_MASK constant > - Add missing register descriptions > - Remove superfluous printk about IRQ flow type mismatch > - Use BIT() macro > - Rename _ack function to _eoi for accuracy, and use handle_fasteoi_irq > --- > arch/arm/mach-npcm/Kconfig | 1 + > drivers/irqchip/Kconfig | 6 ++ > drivers/irqchip/Makefile | 1 + > drivers/irqchip/irq-wpcm450-aic.c | 161 ++++++++++++++++++++++++++++++ > 4 files changed, 169 insertions(+) > create mode 100644 drivers/irqchip/irq-wpcm450-aic.c > > diff --git a/arch/arm/mach-npcm/Kconfig b/arch/arm/mach-npcm/Kconfig > index 658c8efb4ca14..a71cf1d189ae5 100644 > --- a/arch/arm/mach-npcm/Kconfig > +++ b/arch/arm/mach-npcm/Kconfig > @@ -10,6 +10,7 @@ config ARCH_WPCM450 > bool "Support for WPCM450 BMC (Hermon)" > depends on ARCH_MULTI_V5 > select CPU_ARM926T > + select WPCM450_AIC > select NPCM7XX_TIMER > help > General support for WPCM450 BMC (Hermon). I can't take this patch with this particular hunk, as I don't have this file in my tree. I can either drop this line, or delay the merging of this patch to a later point in time. The driver otherwise looks ready. Thanks, M. -- Without deviation from the norm, progress is not possible.