From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7580DC433E0 for ; Fri, 12 Mar 2021 09:00:19 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ECDE564F6A for ; Fri, 12 Mar 2021 09:00:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ECDE564F6A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FQV22BKIGHhooCM1SzV3w8swsON5+bNt5winh9+jsH0=; b=R4DMqd/2awV2fBRyQAn0lfi/8 KxRZAspEZFn85ShruxhkKrxxfB2R2aMqi+TcHwItQNI2GQ2RptzUb1PgSlRK5xObr8osYu71szajb qX8E4agC7480vxdIJL/EvyJpfmjK5FjMkqz2Hl7MSxTNpEpDtGvgjmOtWvAB3Nf22OOezJda8PfP6 WfKeuOqq+XawVZWG7/U5I/WaN44cHerhP4PjXyRGF1Wx5fvtXumY+Hr6Aj4AITJAlYCX15/QGnDKX 9ZoKM05yiBbq3q7ZqFqCc3EQ1iPQ72x7xWWQEIY97zkJB4ZB7GcX5Z1RdH5PhWaZ/joLTARVccOkx n4jIGw8AA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lKdd5-00AwYd-8E; Fri, 12 Mar 2021 08:58:43 +0000 Received: from relay10.mail.gandi.net ([217.70.178.230]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lKdd0-00AwXZ-N0 for linux-arm-kernel@lists.infradead.org; Fri, 12 Mar 2021 08:58:41 +0000 Received: from localhost (lfbn-lyo-1-1912-141.w90-65.abo.wanadoo.fr [90.65.91.141]) (Authenticated sender: gregory.clement@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 8628924000B; Fri, 12 Mar 2021 08:58:34 +0000 (UTC) From: Gregory CLEMENT To: Marek =?utf-8?Q?Beh=C3=BAn?= Cc: linux-arm-kernel@lists.infradead.org, pali@kernel.org, Marek =?utf-8?Q?Beh=C3=BAn?= , stable@vger.kernel.org Subject: Re: [PATCH mvebu + mvebu/dt64 4/4] arm64: dts: marvell: armada-37xx: move firmware node to generic dtsi file In-Reply-To: <20210308153703.23097-4-kabel@kernel.org> References: <20210308153703.23097-1-kabel@kernel.org> <20210308153703.23097-4-kabel@kernel.org> Date: Fri, 12 Mar 2021 09:58:34 +0100 Message-ID: <87czw4kath.fsf@BL-laptop> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210312_085839_054230_339C913B X-CRM114-Status: GOOD ( 18.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGVsbG8gTWFyZWssCgo+IEZyb206IFBhbGkgUm9ow6FyIDxwYWxpQGtlcm5lbC5vcmc+Cj4KPiBN b3ZlIHRoZSB0dXJyaXMtbW94LXJ3dG0gZmlybXdhcmUgbm9kZSBmcm9tIFR1cnJpcyBNT1gnIGRl dmljZSB0cmVlIGludG8KPiB0aGUgZ2VuZXJpYyBhcm1hZGEtMzd4eC5kdHNpIGZpbGUuCgpJIGRp c2FncmVlIHdpdGggdGhpcyBwYXRjaC4gVGhpcyBmaXJtd2FyZSBpcyBzcGVjaWZpYyB0byBUdXJy aXMgTU9YIHNvCml0IGlzIG5vdCBzb21ldGhpbmcgdGhhdCBzaG91bGQgYmUgZXhwb3NlZCB0byBh bGwgdGhlIEFybWFkYSAzNzAwIGJhc2VkCmJvYXJkcy4KCklmIHlvdSB3YW50IHlvdSBzdGlsbCBj YW4gY3JlYXRlIGFuIGR0c2kgZm9yIHRoaXMgYW5kIGluY2x1ZGUgaXQgd2hlbgpuZWVkZWQuCgpH cmVnb3J5Cgo+Cj4gVGhlIFR1cnJpcyBNT1ggcldUTSBmaXJtd2FyZSBjYW4gYmUgdXNlZCBvbiBh bnkgQXJtYWRhIDM3eHggZGV2aWNlLAo+IGdpdmluZyB0aGVtIGFjY2VzcyB0byB0aGUgcldUTSBo YXJkd2FyZSByYW5kb20gbnVtYmVyIGdlbmVyYXRvciwgd2hpY2gKPiBpcyBvdGhlcndpc2UgdW5h dmFpbGFibGUuCj4KPiBUaGlzIGNoYW5nZSBhbGxvd3MgTGludXggdG8gbG9hZCB0aGUgdHVycmlz LW1veC1yd3RtLmtvIG1vZHVsZSBvbiB0aGVzZQo+IGJvYXJkcy4KPgo+IFRlc3RlZCBvbiBFU1BS RVNTT2JpbiB2NSB3aXRoIGJvdGggZGVmYXVsdCBNYXJ2ZWxsIFdUTUkgZmlybXdhcmUgYW5kCj4g Q1ouTklDJ3MgZmlybXdhcmUuIFdpdGggZGVmYXVsdCBXVE1JIGZpcm13YXJlIHRoZSB0dXJyaXMt bW94LXJ3dG0gZmFpbHMKPiB0byBwcm9iZSwgd2hpbGUgd2l0aCBDWi5OSUMncyBmaXJtd2FyZSBp dCByZWdpc3RlcnMgdGhlIEhXIHJhbmRvbSBudW1iZXIKPiBnZW5lcmF0b3IuCj4KPiBTaWduZWQt b2ZmLWJ5OiBQYWxpIFJvaMOhciA8cGFsaUBrZXJuZWwub3JnPgo+IFNpZ25lZC1vZmYtYnk6IE1h cmVrIEJlaMO6biA8a2FiZWxAa2VybmVsLm9yZz4KPiBDYzogPHN0YWJsZUB2Z2VyLmtlcm5lbC5v cmc+ICMgNS40KzogNDZkMmY2ZDBjOTlmICgiYXJtNjQ6IGR0czogYXJtYWRhLTM3MjAtdHVycmlz LW1veDogYWRkIGZpcm13YXJlIG5vZGUiKQo+IC0tLQo+ICBhcmNoL2FybTY0L2Jvb3QvZHRzL21h cnZlbGwvYXJtYWRhLTM3MjAtdHVycmlzLW1veC5kdHMgfCA4IC0tLS0tLS0tCj4gIGFyY2gvYXJt NjQvYm9vdC9kdHMvbWFydmVsbC9hcm1hZGEtMzd4eC5kdHNpICAgICAgICAgICB8IDggKysrKysr KysKPiAgMiBmaWxlcyBjaGFuZ2VkLCA4IGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0pCj4K PiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm02NC9ib290L2R0cy9tYXJ2ZWxsL2FybWFkYS0zNzIwLXR1 cnJpcy1tb3guZHRzIGIvYXJjaC9hcm02NC9ib290L2R0cy9tYXJ2ZWxsL2FybWFkYS0zNzIwLXR1 cnJpcy1tb3guZHRzCj4gaW5kZXggZDIzOWFiNzBlZDk5Li44NDQ3ZjMwM2EyOTQgMTAwNjQ0Cj4g LS0tIGEvYXJjaC9hcm02NC9ib290L2R0cy9tYXJ2ZWxsL2FybWFkYS0zNzIwLXR1cnJpcy1tb3gu ZHRzCj4gKysrIGIvYXJjaC9hcm02NC9ib290L2R0cy9tYXJ2ZWxsL2FybWFkYS0zNzIwLXR1cnJp cy1tb3guZHRzCj4gQEAgLTEwNywxNCArMTA3LDYgQEAgc2ZwOiBzZnAgewo+ICAJCS8qIGVuYWJs ZWQgYnkgVS1Cb290IGlmIFNGUCBtb2R1bGUgaXMgcHJlc2VudCAqLwo+ICAJCXN0YXR1cyA9ICJk aXNhYmxlZCI7Cj4gIAl9Owo+IC0KPiAtCWZpcm13YXJlIHsKPiAtCQl0dXJyaXMtbW94LXJ3dG0g ewo+IC0JCQljb21wYXRpYmxlID0gImN6bmljLHR1cnJpcy1tb3gtcnd0bSI7Cj4gLQkJCW1ib3hl cyA9IDwmcnd0bSAwPjsKPiAtCQkJc3RhdHVzID0gIm9rYXkiOwo+IC0JCX07Cj4gLQl9Owo+ICB9 Owo+ICAKPiAgJmkyYzAgewo+IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0L2Jvb3QvZHRzL21hcnZl bGwvYXJtYWRhLTM3eHguZHRzaSBiL2FyY2gvYXJtNjQvYm9vdC9kdHMvbWFydmVsbC9hcm1hZGEt Mzd4eC5kdHNpCj4gaW5kZXggN2EyZGYxNDhjNmEzLi4zMTEyNmYxZmZlNWIgMTAwNjQ0Cj4gLS0t IGEvYXJjaC9hcm02NC9ib290L2R0cy9tYXJ2ZWxsL2FybWFkYS0zN3h4LmR0c2kKPiArKysgYi9h cmNoL2FybTY0L2Jvb3QvZHRzL21hcnZlbGwvYXJtYWRhLTM3eHguZHRzaQo+IEBAIC01MDMsNCAr NTAzLDEyIEBAIHBjaWVfaW50YzogaW50ZXJydXB0LWNvbnRyb2xsZXIgewo+ICAJCQl9Owo+ICAJ CX07Cj4gIAl9Owo+ICsKPiArCWZpcm13YXJlIHsKPiArCQl0dXJyaXMtbW94LXJ3dG0gewo+ICsJ CQljb21wYXRpYmxlID0gImN6bmljLHR1cnJpcy1tb3gtcnd0bSI7Cj4gKwkJCW1ib3hlcyA9IDwm cnd0bSAwPjsKPiArCQkJc3RhdHVzID0gIm9rYXkiOwo+ICsJCX07Cj4gKwl9Owo+ICB9Owo+IC0t IAo+IDIuMjYuMgo+CgotLSAKR3JlZ29yeSBDbGVtZW50LCBCb290bGluCkVtYmVkZGVkIExpbnV4 IGFuZCBLZXJuZWwgZW5naW5lZXJpbmcKaHR0cDovL2Jvb3RsaW4uY29tCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxp bmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 552D2C433DB for ; Fri, 12 Mar 2021 08:59:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1349E64FD0 for ; Fri, 12 Mar 2021 08:59:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232424AbhCLI7B convert rfc822-to-8bit (ORCPT ); Fri, 12 Mar 2021 03:59:01 -0500 Received: from relay10.mail.gandi.net ([217.70.178.230]:33133 "EHLO relay10.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232296AbhCLI6g (ORCPT ); Fri, 12 Mar 2021 03:58:36 -0500 Received: from localhost (lfbn-lyo-1-1912-141.w90-65.abo.wanadoo.fr [90.65.91.141]) (Authenticated sender: gregory.clement@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 8628924000B; Fri, 12 Mar 2021 08:58:34 +0000 (UTC) From: Gregory CLEMENT To: Marek =?utf-8?Q?Beh=C3=BAn?= Cc: linux-arm-kernel@lists.infradead.org, pali@kernel.org, Marek =?utf-8?Q?Beh=C3=BAn?= , stable@vger.kernel.org Subject: Re: [PATCH mvebu + mvebu/dt64 4/4] arm64: dts: marvell: armada-37xx: move firmware node to generic dtsi file In-Reply-To: <20210308153703.23097-4-kabel@kernel.org> References: <20210308153703.23097-1-kabel@kernel.org> <20210308153703.23097-4-kabel@kernel.org> Date: Fri, 12 Mar 2021 09:58:34 +0100 Message-ID: <87czw4kath.fsf@BL-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Hello Marek, > From: Pali Rohár > > Move the turris-mox-rwtm firmware node from Turris MOX' device tree into > the generic armada-37xx.dtsi file. I disagree with this patch. This firmware is specific to Turris MOX so it is not something that should be exposed to all the Armada 3700 based boards. If you want you still can create an dtsi for this and include it when needed. Gregory > > The Turris MOX rWTM firmware can be used on any Armada 37xx device, > giving them access to the rWTM hardware random number generator, which > is otherwise unavailable. > > This change allows Linux to load the turris-mox-rwtm.ko module on these > boards. > > Tested on ESPRESSObin v5 with both default Marvell WTMI firmware and > CZ.NIC's firmware. With default WTMI firmware the turris-mox-rwtm fails > to probe, while with CZ.NIC's firmware it registers the HW random number > generator. > > Signed-off-by: Pali Rohár > Signed-off-by: Marek Behún > Cc: # 5.4+: 46d2f6d0c99f ("arm64: dts: armada-3720-turris-mox: add firmware node") > --- > arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts | 8 -------- > arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 8 ++++++++ > 2 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts > index d239ab70ed99..8447f303a294 100644 > --- a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts > +++ b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts > @@ -107,14 +107,6 @@ sfp: sfp { > /* enabled by U-Boot if SFP module is present */ > status = "disabled"; > }; > - > - firmware { > - turris-mox-rwtm { > - compatible = "cznic,turris-mox-rwtm"; > - mboxes = <&rwtm 0>; > - status = "okay"; > - }; > - }; > }; > > &i2c0 { > diff --git a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi > index 7a2df148c6a3..31126f1ffe5b 100644 > --- a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi > +++ b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi > @@ -503,4 +503,12 @@ pcie_intc: interrupt-controller { > }; > }; > }; > + > + firmware { > + turris-mox-rwtm { > + compatible = "cznic,turris-mox-rwtm"; > + mboxes = <&rwtm 0>; > + status = "okay"; > + }; > + }; > }; > -- > 2.26.2 > -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com